Limit Partner.countries to only allow locations that are type == Country

Co-authored-by: Carson Full <[email protected]>

Author: William Harris

src/components/partner/partner.service.ts

@@ -2,17 +2,20 @@ import { forwardRef, Inject, Injectable } from '@nestjs/common';
 import {
   DuplicateException,
   ID,
+  IdOf,
   InputException,
+  loadManyIgnoreMissingThrowAny,
   NotFoundException,
   ObjectView,
   ServerException,
   Session,
   UnauthorizedException,
   UnsecuredDto,
 } from '../../common';
-import { HandleIdLookup, ILogger, Logger } from '../../core';
+import { HandleIdLookup, ILogger, Logger, ResourceLoader } from '../../core';
 import { mapListResults } from '../../core/database/results';
 import { Privileges } from '../authorization';
+import { Location, LocationLoader, LocationType } from '../location';
 import { FinancialReportingType } from '../partnership/dto/financial-reporting-type';
 import {
   IProject,
@@ -38,6 +41,7 @@ export class PartnerService {
     @Inject(forwardRef(() => ProjectService))
     private readonly projectService: ProjectService & {},
     private readonly repo: PartnerRepository,
+    private readonly resourceLoader: ResourceLoader,
   ) {}
 
   async create(input: CreatePartner, session: Session): Promise<Partner> {
@@ -55,6 +59,10 @@ export class PartnerService {
       );
     }
 
+    if (input.countries) {
+      await this.verifyCountries(input.countries);
+    }
+
     const id = await this.repo.create(input, session);
 
     this.logger.debug(`Partner created`, { id });
@@ -150,6 +158,8 @@ export class PartnerService {
     }
 
     if (countries) {
+      await this.verifyCountries(countries);
+
       try {
         await this.repo.updateRelationList({
           id: partner.id,
@@ -249,4 +259,26 @@ export class PartnerService {
       ? false
       : true;
   }
+
+  private async verifyCountries(ids: ReadonlyArray<IdOf<Location>>) {
+    const loader = await this.resourceLoader.getLoader(LocationLoader);
+    const locations = await loadManyIgnoreMissingThrowAny(loader, ids);
+    const invalidIds = locations.flatMap((location) =>
+      location.type.value !== 'Country' ? location.id : [],
+    );
+    if (invalidIds.length === 0) {
+      return;
+    }
+    const ex = new LocationTypeException([LocationType.Country], invalidIds);
+    throw ex.withField('partner.countries');
+  }
+}
+
+class LocationTypeException extends InputException {
+  constructor(
+    readonly allowedTypes: readonly LocationType[],
+    readonly invalidIds: ID[],
+  ) {
+    super('Given locations do not match the expected type');
+  }
 }