Allow updates to objects that have missing fields if the update reduces the missing number

This allows us to fill these missing data points on our bad data.
Hopefully this is temporary.

Author: CarsonF

src/common/required-when.ts

@@ -41,23 +41,37 @@ export const RequiredWhen =
       ...fieldOptions,
     });
 
-RequiredWhen.verify = <TResourceStatic extends ResourceShape<any>>(
+RequiredWhen.calc = <TResourceStatic extends ResourceShape<any>>(
   resource: TResourceStatic,
   obj: UnsecuredDto<TResourceStatic['prototype']>,
 ) => {
   const res = EnhancedResource.of(resource);
-  const missing = [...res.props].flatMap((prop: string) => {
+  const conditions = [...res.props].flatMap((prop: string) => {
     const condition = RequiredWhenMetadata.get(resource, prop);
-    return condition?.isEnabled(obj) &&
-      (condition.isMissing?.(obj) ?? obj[prop] == null)
+    return condition ? { ...condition, field: prop } : [];
+  });
+  const missing = conditions.flatMap((condition) => {
+    return condition.isEnabled(obj) &&
+      (condition.isMissing?.(obj) ?? obj[condition.field] == null)
       ? {
-          field: condition.field ?? prop,
+          field: condition.field,
           description: condition.description,
         }
       : [];
   });
   if (missing.length > 0) {
-    throw new MissingRequiredFieldsException(res, { id: obj.id }, missing);
+    return new MissingRequiredFieldsException(res, { id: obj.id }, missing);
+  }
+  return undefined;
+};
+
+RequiredWhen.verify = <TResourceStatic extends ResourceShape<any>>(
+  resource: TResourceStatic,
+  obj: UnsecuredDto<TResourceStatic['prototype']>,
+) => {
+  const ex = RequiredWhen.calc(resource, obj);
+  if (ex) {
+    throw ex;
   }
 };
 

src/components/engagement/engagement.service.ts

@@ -196,7 +196,14 @@ export class EngagementService {
       changeset,
     );
 
-    RequiredWhen.verify(LanguageEngagement, updated);
+    const prevMissing = RequiredWhen.calc(LanguageEngagement, previous);
+    const nowMissing = RequiredWhen.calc(LanguageEngagement, updated);
+    if (
+      nowMissing &&
+      (!prevMissing || nowMissing.missing.length >= prevMissing.missing.length)
+    ) {
+      throw nowMissing;
+    }
 
     const event = new EngagementUpdatedEvent(
       updated,
@@ -245,7 +252,14 @@ export class EngagementService {
       changeset,
     );
 
-    RequiredWhen.verify(InternshipEngagement, updated);
+    const prevMissing = RequiredWhen.calc(InternshipEngagement, previous);
+    const nowMissing = RequiredWhen.calc(InternshipEngagement, updated);
+    if (
+      nowMissing &&
+      (!prevMissing || nowMissing.missing.length >= prevMissing.missing.length)
+    ) {
+      throw nowMissing;
+    }
 
     const event = new EngagementUpdatedEvent(
       updated,

src/components/project/project.service.ts

@@ -343,7 +343,14 @@ export class ProjectService {
 
     updated = await this.repo.update(updated, changes, changeset);
 
-    RequiredWhen.verify(IProject, updated);
+    const prevMissing = RequiredWhen.calc(IProject, currentProject);
+    const nowMissing = RequiredWhen.calc(IProject, updated);
+    if (
+      nowMissing &&
+      (!prevMissing || nowMissing.missing.length >= prevMissing.missing.length)
+    ) {
+      throw nowMissing;
+    }
 
     const event = new ProjectUpdatedEvent(
       updated,