Skip to content

Commit 624b085

Browse files
authored
Data loader strategies do not need to be request scoped (#3648)
1 parent ed83214 commit 624b085

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/core/data-loader/loader-factory.decorator.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Injectable, Scope, type Type } from '@nestjs/common';
1+
import { Injectable, type Type } from '@nestjs/common';
22
import { createMetadataDecorator } from '@seedcompany/nest';
33
import type { ValueOf } from 'type-fest';
44
import type { Many } from '~/common';
@@ -42,7 +42,7 @@ export const LoaderFactory =
4242
options?: LoaderOptions,
4343
): (<LoaderCtor extends DataLoaderCtor>(target: LoaderCtor) => void) =>
4444
(target) => {
45-
Injectable({ scope: Scope.REQUEST })(target);
45+
Injectable()(target);
4646

4747
LoaderFactoryMetadata(resource, {
4848
...options,

src/core/resources/loader.registry.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
1-
import {
2-
Injectable,
3-
type OnModuleInit,
4-
Scope,
5-
type Type,
6-
} from '@nestjs/common';
1+
import { Injectable, type OnModuleInit, type Type } from '@nestjs/common';
72
import { ModulesContainer } from '@nestjs/core';
83
import { many } from '~/common';
94
import { type DataLoaderStrategy } from '~/core/data-loader';
@@ -25,7 +20,6 @@ export class ResourceLoaderRegistry implements OnModuleInit {
2520
async onModuleInit() {
2621
const loaderFactories = [...this.modulesContainer.values()]
2722
.flatMap((nestModule) => [...nestModule.providers.values()])
28-
.filter((provider) => provider.scope === Scope.REQUEST)
2923
.flatMap((provider) => {
3024
if (!provider.metatype) {
3125
return [];

0 commit comments

Comments
 (0)