Fix impersonator to use ALS

Author: CarsonF

src/components/authentication/authentication.service.ts

@@ -231,10 +231,11 @@ export class AuthenticationService {
   }
 
   async asUser<R>(
-    userId: ID<'User'>,
+    user: ID<'User'> | Session,
     fn: (session: Session) => Promise<R>,
   ): Promise<R> {
-    const session = await this.sessionForUser(userId);
+    const session =
+      typeof user === 'string' ? await this.sessionForUser(user) : user;
     return await this.sessionHost.withSession(session, () => fn(session));
   }
 

src/components/authentication/session.resolver.ts

@@ -115,16 +115,16 @@ export class SessionResolver {
   async impersonator(
     @Parent() { session }: SessionOutput,
   ): Promise<User | null> {
-    if (session.anonymous || !session.impersonator) {
+    const { impersonator } = session;
+    if (session.anonymous || !impersonator) {
       return null;
     }
     // Edge case: Load the impersonator, as the impersonator, rather than the impersonatee.
     // They should still be able to see their own props from this field.
     // Otherwise, it could be that the impersonatee can't see the impersonator's roles,
     // and now the UI can't stop impersonating because it doesn't know the impersonator's roles.
-    return await this.users.readOne(
-      session.impersonator.userId,
-      session.impersonator, // instead of `session`
+    return await this.authentication.asUser(impersonator, (_) =>
+      this.users.readOne(impersonator.userId, _),
     );
   }