Skip to content

Commit 67dfe8d

Browse files
CarsonFCarsonF
committed
Rename transitions to describe action
1 parent 2909183 commit 67dfe8d

File tree

7 files changed

+177
-184
lines changed

7 files changed

+177
-184
lines changed

‎src/components/authorization/policies/by-role/consultant.policy.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { member, Policy, Role } from '../util';
33

44
export const projectTransitions = () =>
55
ProjectWorkflow.pickNames(
6-
'Pending Consultant Endorsement -> Prep for Financial Endorsement With Consultant Endorsement',
7-
'Pending Consultant Endorsement -> Prep for Financial Endorsement Without Consultant Endorsement',
6+
'Consultant Endorses Proposal',
7+
'Consultant Opposes Proposal',
88
);
99

1010
// NOTE: There could be other permissions for this role from other policies

‎src/components/authorization/policies/by-role/controller.policy.ts‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ import { Policy, Role } from '../util';
66
r.Organization.delete,
77
r.Partner.delete,
88
r.ProjectWorkflowEvent.read.transitions(
9-
'Pending & On Hold Finance Confirmation -> Active',
10-
'Pending Finance Confirmation -> Pending Regional Director Approval',
11-
'Pending Finance Confirmation -> Did Not Develop',
12-
'Pending Finance Confirmation -> On Hold Finance Confirmation',
13-
'Pending & On Hold Finance Confirmation -> Finalizing Proposal',
14-
'Pending & On Hold Finance Confirmation -> Rejected',
15-
'Pending Change To Plan Confirmation -> Discussing Change To Plan',
16-
'Pending Change To Plan Confirmation -> Active Changed Plan',
17-
'Pending Change To Plan Confirmation -> Back To Active',
9+
'Finance Approves Proposal',
10+
'Finance Holds for Confirmation',
11+
'Finance Requests Proposal Changes',
12+
'Finance Requests Multiplication Changes',
13+
'Finance Rejects Proposal',
14+
'Finance Ends Development',
15+
'Finance Approves Change To Plan',
16+
'Finance Requests Changes for Change To Plan',
17+
'Finance Rejects Change To Plan',
1818
).execute,
1919
])
2020
export class ControllerPolicy {}

‎src/components/authorization/policies/by-role/field-operations-director.policy.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ import { Policy, Role } from '../util';
1616
r.Project.edit,
1717
r.ProjectMember.edit.create.delete,
1818
r.ProjectWorkflowEvent.read.transitions(
19-
'Pending Zone Director Approval -> Pending Finance Confirmation',
20-
'Pending Zone Director Approval -> Finalizing Proposal',
21-
'Pending Zone Director Approval -> Rejected',
19+
'Field Ops Approves Proposal',
20+
'Field Ops Requests Proposal Changes',
21+
'Field Ops Rejects Proposal',
2222
).execute,
2323
r.PeriodicReport.edit,
2424
r.StepProgress.edit,

‎src/components/authorization/policies/by-role/financial-analyst.policy.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ import {
1010

1111
export const projectTransitions = () =>
1212
ProjectWorkflow.pickNames(
13-
'Pending Financial Endorsement -> Finalizing Proposal With Financial Endorsement',
14-
'Pending Financial Endorsement -> Finalizing Proposal Without Financial Endorsement',
15-
'Finalizing Completion -> Back To Active',
16-
'Finalizing Completion -> Completed',
13+
'Finance Endorses Proposal',
14+
'Finance Opposes Proposal',
15+
'Not Ready for Completion',
16+
'Complete',
1717
);
1818

1919
// NOTE: There could be other permissions for this role from other policies

‎src/components/authorization/policies/by-role/project-manager.policy.ts‎

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -20,42 +20,42 @@ const stepsUntilFinancialEndorsement = takeWhile(
2020
);
2121

2222
export const projectTransitions = () =>
23-
ProjectWorkflow.pickNames([
24-
'Early Conversations -> Pending Regional Director Approval',
25-
'Early Conversations -> Pending Concept Approval',
26-
'Early Conversations -> Did Not Develop',
27-
'Prep for Consultant Endorsement -> Pending Consultant Endorsement',
28-
'Prep for Consultant & Financial Endorsement & Finalizing Proposal -> Pending Concept Approval',
29-
'Prep for Consultant & Financial Endorsement & Finalizing Proposal -> Did Not Develop',
30-
'Prep for Financial Endorsement -> Pending Financial Endorsement',
31-
'Prep for Financial Endorsement & Finalizing Proposal -> Pending Consultant Endorsement',
32-
'Finalizing Proposal -> Pending Regional Director Approval',
33-
'Finalizing Proposal -> Pending Financial Endorsement',
34-
'Active -> Discussing Change To Plan',
35-
'Active -> Discussing Termination',
36-
'Active -> Finalizing Completion',
37-
'Discussing Change To Plan -> Pending Change To Plan Approval',
38-
'Discussing Change To Plan -> Discussing Suspension',
39-
'Discussing Change To Plan -> Back To Active',
40-
'Pending Change To Plan Approval -> Discussing Change To Plan',
41-
'Pending Change To Plan Approval -> Pending Change To Plan Confirmation',
42-
'Pending Change To Plan Approval -> Back To Active',
43-
'Discussing Suspension -> Pending Suspension Approval',
44-
'Discussing Suspension -> Back To Active',
45-
'Suspended -> Discussing Reactivation',
46-
'Suspended & Discussing Reactivation -> Discussing Termination',
47-
'Discussing Reactivation -> Pending Reactivation Approval',
48-
'Discussing Termination -> Pending Termination Approval',
49-
'Discussing Termination -> Back To Most Recent',
50-
'Finalizing Completion -> Back To Active',
51-
'Finalizing Completion -> Completed',
52-
]);
23+
ProjectWorkflow.pickNames(
24+
'Propose Multiplication',
25+
'Request Concept Approval',
26+
'End Conversation',
27+
'Request Consultant Endorsement',
28+
'Re-request Concept Approval',
29+
'End Proposal',
30+
'Request Financial Endorsement',
31+
'Re-request Consultant Endorsement',
32+
'Request Proposal Approval',
33+
'Re-request Financial Endorsement',
34+
'Discuss Change To Plan',
35+
'Discuss Terminating Active Project',
36+
'Finalize Completion',
37+
'Request Change To Plan Approval',
38+
'Discuss Suspension out of Change to Plan Discussion',
39+
'End Change To Plan Discussion',
40+
'Request Changes for Change To Plan',
41+
'Approve Change To Plan',
42+
'Reject Change To Plan',
43+
'Request Suspension Approval',
44+
'End Suspension Discussion',
45+
'Discuss Reactivation',
46+
'Discuss Terminating Suspended Project',
47+
'Request Reactivation Approval',
48+
'Request Termination Approval',
49+
'End Termination Discussion',
50+
'Not Ready for Completion',
51+
'Complete',
52+
);
5353

5454
export const momentumProjectsTransitions = () =>
55-
ProjectWorkflow.pickNames([
56-
'Pending Consultant Endorsement -> Prep for Financial Endorsement With Consultant Endorsement',
57-
'Pending Consultant Endorsement -> Prep for Financial Endorsement Without Consultant Endorsement',
58-
]);
55+
ProjectWorkflow.pickNames(
56+
'Consultant Endorses Proposal',
57+
'Consultant Opposes Proposal',
58+
);
5959

6060
// NOTE: There could be other permissions for this role from other policies
6161
@Policy(

‎src/components/authorization/policies/by-role/regional-director.policy.ts‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,25 @@ import * as PM from './project-manager.policy';
1414
PM.momentumProjectsTransitions,
1515
).execute,
1616
r.ProjectWorkflowEvent.read.transitions(
17-
'Early Conversations -> Pending Finance Confirmation',
18-
'Pending Concept Approval -> Prep for Consultant Endorsement',
19-
'Pending Concept Approval -> Early Conversations',
20-
'Pending Concept Approval -> Rejected',
21-
'Pending Regional Director Approval -> Early Conversations',
22-
'Pending Regional Director Approval -> Pending Finance Confirmation',
23-
'Pending Regional Director Approval -> Pending Zone Director Approval',
24-
'Pending Regional Director Approval -> Finalizing Proposal',
25-
'Pending Regional Director Approval -> Did Not Develop',
26-
'Pending Regional Director Approval -> Rejected',
27-
'Pending Suspension Approval -> Discussing Suspension',
28-
'Pending Suspension Approval -> Suspended',
29-
'Pending Suspension Approval -> Back To Active',
30-
'Pending Reactivation Approval -> Active Changed Plan',
31-
'Pending Reactivation Approval -> Discussing Reactivation',
32-
'Pending Reactivation Approval -> Discussing Termination',
33-
'Pending Termination Approval -> Terminated',
34-
'Pending Termination Approval -> Discussing Termination',
35-
'Pending Termination Approval -> Back To Most Recent',
17+
'RD Proposes Multiplication & Approves',
18+
'Approve Concept',
19+
'Request Concept Changes',
20+
'Reject Concept',
21+
'RD Requests Multiplication Concept Changes',
22+
'RD Approves Proposal',
23+
'RD Approves Proposal & Defers to Fields Ops',
24+
'RD Requests Proposal Changes',
25+
'RD Ends Development',
26+
'RD Rejects Proposal',
27+
'Request Changes for Suspension',
28+
'Approve Suspension',
29+
'Reject Suspension',
30+
'Approve Reactivation',
31+
'Request Changes for Reactivation',
32+
'Discussing Terminating Suspended Project By Reactivation Approver',
33+
'Approve Termination',
34+
'Request Changes for Termination',
35+
'End Termination Discussion By Approver',
3636
).execute,
3737
])
3838
export class RegionalDirectorPolicy {}

0 commit comments

Comments
 (0)