Change types to correctly convey a necessary condition

Author: CarsonF

src/common/date-filter.input.ts

@@ -1,7 +1,7 @@
 import { Field, InputType } from '@nestjs/graphql';
-import { DateTime } from 'luxon';
+import { type DateTime } from 'luxon';
 import { DateField, DateTimeField } from './luxon.graphql';
-import { CalendarDate } from './temporal';
+import { type CalendarDate } from './temporal';
 
 @InputType({
   description: 'A filter range designed for date fields',
@@ -11,25 +11,25 @@ export abstract class DateFilter {
     description: 'After this day',
     nullable: true,
   })
-  after?: CalendarDate;
+  after?: CalendarDate | null;
 
   @DateField({
     description: 'After or equal to this day',
     nullable: true,
   })
-  afterInclusive?: CalendarDate;
+  afterInclusive?: CalendarDate | null;
 
   @DateField({
     description: 'Before this day',
     nullable: true,
   })
-  before?: CalendarDate;
+  before?: CalendarDate | null;
 
   @DateField({
     description: 'Before or equal to this day',
     nullable: true,
   })
-  beforeInclusive?: CalendarDate;
+  beforeInclusive?: CalendarDate | null;
 
   @Field({ description: 'Whether the field is null or not', nullable: true })
   isNull?: boolean;
@@ -43,25 +43,25 @@ export abstract class DateTimeFilter {
     description: 'After this time',
     nullable: true,
   })
-  after?: DateTime;
+  after?: DateTime | null;
 
   @DateTimeField({
     description: 'After or equal to this time',
     nullable: true,
   })
-  afterInclusive?: DateTime;
+  afterInclusive?: DateTime | null;
 
   @DateTimeField({
     description: 'Before this time',
     nullable: true,
   })
-  before?: DateTime;
+  before?: DateTime | null;
 
   @DateTimeField({
     description: 'Before or equal to this time',
     nullable: true,
   })
-  beforeInclusive?: DateTime;
+  beforeInclusive?: DateTime | null;
 
   @Field({ description: 'Whether the field is null or not', nullable: true })
   isNull?: boolean;

src/common/exceptions/service-unavailable.exception.ts

@@ -5,7 +5,7 @@ export class TransientException extends ServerException {}
 
 export class ServiceUnavailableException extends TransientException {
   readonly status = HttpStatus.SERVICE_UNAVAILABLE;
-  constructor(message: string, previous?: Error) {
+  constructor(message?: string, previous?: Error) {
     super(message ?? 'Service Unavailable', previous);
   }
 }

src/common/name-field.ts

@@ -51,9 +51,13 @@ export const NameField = (options: NameFieldParams = {}) =>
  */
 const InferredTypeOrStringField =
   (options: FieldOptions): PropertyDecorator | MethodDecorator =>
-  (prototype, property, descriptor) => {
+  (prototype, property, descriptorRaw) => {
     const propertyKey = property as string;
     const applyMetadataFn = () => {
+      // fix linter false positive thinking it always exists, property decorators don't have it
+      const descriptor = descriptorRaw as
+        | TypedPropertyDescriptor<unknown>
+        | undefined;
       const isResolver = !!descriptor;
       const isResolverMethod = !!descriptor?.value;
       const resolveType = (typeFn?: ReturnTypeFunc) =>

src/common/variant.dto.ts

@@ -90,7 +90,7 @@ export const VariantInputField = <
       ? resource.Variants.find((v) => v.key === value)
       : value;
   const defaultVariant = many
-    ? (defaultValue as any[])?.map(resolveVariant)
+    ? (defaultValue as any[] | undefined)?.map(resolveVariant)
     : resolveVariant(defaultValue as VariantOf<Res>);
 
   return applyDecorators(

src/components/authorization/policy/executor/condition-optimizer.ts

@@ -34,7 +34,7 @@ export class ConditionOptimizer implements OnModuleInit {
     // Optimize leaves first, walking up to root.
     // This means smaller expressions are optimized before tackling larger ones.
     if (condition instanceof AggregateConditions) {
-      let changed = false;
+      let changed = Boolean(false);
       const newSubs = condition.conditions.map((sub) => {
         const next = this.doOptimize(sub);
         if (next !== sub) {

src/components/authorization/policy/executor/policy-executor.ts

@@ -222,7 +222,7 @@ export class PolicyExecutor {
         return c;
       }
 
-      let changed = false;
+      let changed = Boolean(false);
       const children = c.conditions.map((sub) => {
         const next = walkAndReform(sub);
         if (next !== sub) {

src/components/notifications/dto/mark-notification-read.args.ts

@@ -7,5 +7,5 @@ export abstract class MarkNotificationReadArgs {
   readonly id: ID<'Notification'>;
 
   @Field(() => Boolean, { nullable: true })
-  readonly unread = false;
+  readonly unread: boolean = false;
 }

src/components/product/product.resolver.ts

@@ -149,9 +149,9 @@ export class ProductResolver {
     }
     const produces = product.produces.value;
     // All of our producibles have a name field, so instead of enumerating
-    // through them just fake the type and grab it directly.
+    // through them, just fake the type and grab it directly.
     // This also assumes the user can read the name, which is completely unvalidated.
-    return (produces as unknown as { name: string }).name ?? null;
+    return (produces as unknown as { name?: string }).name ?? null;
   }
 
   @ResolveField(() => String, {

src/components/product/product.service.ts

@@ -128,10 +128,9 @@ export class ProductService {
           );
     }
 
-    const type =
-      'title' in input && input.title !== undefined
-        ? ProducibleType.OtherProduct
-        : producibleType ?? ProducibleType.DirectScriptureProduct;
+    const type = otherInput
+      ? ProducibleType.OtherProduct
+      : producibleType ?? ProducibleType.DirectScriptureProduct;
     const availableSteps = getAvailableSteps({
       type,
       methodology: input.methodology,
@@ -144,16 +143,15 @@ export class ProductService {
       Number: input.progressTarget ?? 1,
     });
 
-    const id =
-      'title' in input && input.title !== undefined
-        ? await this.repo.createOther({ ...input, progressTarget, steps })
-        : await this.repo.create({
-            ...input,
-            progressTarget,
-            steps,
-            totalVerses,
-            totalVerseEquivalents,
-          });
+    const id = otherInput
+      ? await this.repo.createOther({ ...otherInput, progressTarget, steps })
+      : await this.repo.create({
+          ...input,
+          progressTarget,
+          steps,
+          totalVerses,
+          totalVerseEquivalents,
+        });
 
     this.logger.debug(`product created`, { id });
     const created = await this.readOne(id).catch((e) => {

src/core/authentication/authentication.repository.ts

@@ -209,7 +209,7 @@ export class AuthenticationRepository {
       .return<{
         userId: ID | null;
         roles: readonly Role[];
-        impersonateeRoles: readonly Role[] | null;
+        impersonateeRoles?: readonly Role[] | null;
       }>([
         'user.id as userId',
         'roles',