Merge pull request #3485 from SeedCompany/tests/auto-cleanup-dbs

Author: CarsonF

src/core/config/config.service.ts

@@ -5,8 +5,8 @@ import type {
 } from '@seedcompany/nestjs-email';
 import type { Server as HttpServer } from 'http';
 import { type LRUCache } from 'lru-cache';
-import { Duration, type DurationLike } from 'luxon';
-import { nanoid } from 'nanoid';
+import { DateTime, Duration, type DurationLike } from 'luxon';
+import { customAlphabet } from 'nanoid';
 import { type Config as Neo4JDriverConfig } from 'neo4j-driver';
 import { BehaviorSubject } from 'rxjs';
 import type { Class, Merge, ReadonlyDeep } from 'type-fest';
@@ -175,7 +175,9 @@ export const makeConfig = (env: EnvironmentService) =>
         username,
         password,
         database: this.jest
-          ? `test.${nanoid().replace(/[-_]/g, '')}`
+          ? `test.${DateTime.now().toFormat(
+              'y-MM-dd.HH-mm-ss',
+            )}.${customAlphabet('abcdefghjkmnpqrstuvwxyz', 7)()}`
           : database,
         ephemeral: this.jest,
         driverConfig,

src/core/database/database.module.ts

@@ -40,6 +40,9 @@ export class DatabaseModule implements OnApplicationShutdown {
 
   async onApplicationShutdown() {
     if (this.config.neo4j.ephemeral) {
+      if (this.config.jest) {
+        await this.dbService.dropStaleTestDbs();
+      }
       await this.dbService.dropDb();
     }
     await this.db.close();

src/core/database/database.service.ts

@@ -3,8 +3,14 @@ import { entries, mapKeys } from '@seedcompany/common';
 import { Connection, node, type Query, relation } from 'cypher-query-builder';
 import { LazyGetter } from 'lazy-get-decorator';
 import { pickBy, startCase } from 'lodash';
-import { Duration } from 'luxon';
-import { defer, firstValueFrom, shareReplay, takeUntil } from 'rxjs';
+import { DateTime, Duration } from 'luxon';
+import {
+  defer,
+  EmptyError,
+  firstValueFrom,
+  shareReplay,
+  takeUntil,
+} from 'rxjs';
 import {
   DuplicateException,
   type ID,
@@ -209,6 +215,24 @@ export class DatabaseService {
     await this.runAdminCommand('DROP', dbName);
   }
 
+  async dropStaleTestDbs() {
+    const info = await this.getServerInfo().catch((e) => {
+      if (e instanceof EmptyError) return null;
+      throw e;
+    });
+    const staleTestDbs = (info?.databases ?? []).filter(({ name }) => {
+      const match = /test\.([\d-]+\.[\d-]+)\..+/.exec(name);
+      if (!match) {
+        return false;
+      }
+      const dt = DateTime.fromFormat(match[1], 'y-MM-dd.HH-mm-ss');
+      return dt.diffNow().as('hours') < -1;
+    });
+    for (const staleTestDb of staleTestDbs) {
+      await this.runAdminCommand('DROP', staleTestDb.name);
+    }
+  }
+
   private async runAdminCommand(action: 'CREATE' | 'DROP', dbName: string) {
     // @ts-expect-error Yes this is private, but we have a special use case.
     // We need to run this query with a session that's not configured to use the