Move "root" directory creation logic to FileService

The previous logic stopped working because we started
assuming with hydrate that a FileNode would have an attachment point,
aka not be orphaned.

With the Project root directory previous process, it would be "orphaned"
at first until the next query ran relating the node to the project.

Now it's just created all at once, which is better anyways.

Author: CarsonF

src/components/file/file.repository.ts

@@ -26,6 +26,7 @@ import {
   ILogger,
   Logger,
   OnIndex,
+  ResourceRef,
 } from '../../core';
 import {
   ACTIVE,
@@ -406,6 +407,42 @@ export class FileRepository extends CommonRepository {
     return result.id;
   }
 
+  async createRootDirectory({
+    resource,
+    relation,
+    name,
+    public: isPublic,
+    session,
+  }: {
+    resource: ResourceRef<any>;
+    relation: string;
+    name: string;
+    public?: boolean;
+    session: Session;
+  }) {
+    const initialProps = {
+      name,
+      public: isPublic,
+    };
+
+    const query = this.db
+      .query()
+      .apply(await createNode(Directory, { initialProps }))
+      .apply(
+        createRelationships(Directory, {
+          in: { [relation]: ['BaseNode', resource.id] },
+          out: { createdBy: ['User', session.userId] },
+        }),
+      )
+      .return<{ id: ID }>('node.id as id');
+
+    const result = await query.first();
+    if (!result) {
+      throw new ServerException('Failed to create directory');
+    }
+    return result.id;
+  }
+
   async createFile({
     fileId,
     name,

src/components/file/file.service.ts

@@ -227,6 +227,12 @@ export class FileService {
     return await this.getDirectory(id, session);
   }
 
+  async createRootDirectory(
+    ...args: Parameters<FileRepository['createRootDirectory']>
+  ) {
+    return await this.repo.createRootDirectory(...args);
+  }
+
   async requestUpload(): Promise<RequestUploadOutput> {
     const id = await generateId();
     const url = await this.bucket.getSignedUrl(PutObject, {

src/components/file/handlers/attach-project-root-directory.handler.ts

@@ -1,6 +1,4 @@
-import { node, relation } from 'cypher-query-builder';
-import { DateTime } from 'luxon';
-import { DatabaseService, EventsHandler, IEventHandler } from '../../../core';
+import { DatabaseService, EventsHandler, IEventHandler } from '~/core';
 import { ProjectCreatedEvent } from '../../project/events';
 import { FileService } from '../file.service';
 
@@ -15,32 +13,17 @@ export class AttachProjectRootDirectoryHandler
 
   async handle(event: ProjectCreatedEvent) {
     const { project, session } = event;
-    const { id } = project;
 
-    const rootDir = await this.files.createDirectory(
-      undefined,
-      `${id} root directory`,
+    const rootDirId = await this.files.createRootDirectory({
+      resource: project,
+      relation: 'rootDirectory',
+      name: `${project.id} root directory`,
       session,
-    );
+    });
 
-    await this.db
-      .query()
-      .match([
-        [node('project', 'Project', { id })],
-        [node('dir', 'Directory', { id: rootDir.id })],
-      ])
-      .create([
-        node('project'),
-        relation('out', '', 'rootDirectory', {
-          active: true,
-          createdAt: DateTime.local(),
-        }),
-        node('dir'),
-      ])
-      .run();
     event.project = {
       ...event.project,
-      rootDirectory: rootDir.id,
+      rootDirectory: rootDirId,
     };
 
     const folders = [
@@ -50,7 +33,7 @@ export class AttachProjectRootDirectoryHandler
       'Photos',
     ];
     for (const folder of folders) {
-      await this.files.createDirectory(rootDir.id, folder, session);
+      await this.files.createDirectory(rootDirId, folder, session);
     }
   }
 }

test/utility/create-directory.ts

@@ -14,14 +14,14 @@ export async function createRootDirectory(app: TestApp, name?: string) {
     .get(AuthenticationService)
     .resumeSession(app.graphql.authToken);
   const session = loggedInSession(rawSession);
-  const actual = await app
-    .get(FileService)
-    .createDirectory(undefined, name, session);
-
-  expect(actual).toBeTruthy();
-  expect(actual.name).toBe(name);
-
-  return actual;
+  const id = await app.get(FileService).createRootDirectory({
+    // An attachment point is required, so just use the current user.
+    resource: { __typename: 'User', id: session.userId },
+    relation: 'dir',
+    name,
+    session,
+  });
+  return await app.get(FileService).getDirectory(id, session);
 }
 
 export async function createDirectory(