Merge pull request #3319 from SeedCompany/fastify/adjust-ex-handling

Author: CarsonF

src/core/exception/exception.filter.ts

@@ -24,8 +24,15 @@ export class ExceptionFilter implements IExceptionFilter {
   ) {}
 
   async catch(exception: Error, args: ArgumentsHost) {
-    if (exception && (exception as any).type === 'request.aborted') {
-      this.logger.warning('Request aborted');
+    // Ignore aborted requests
+    if (
+      (exception as any).code === 'ECONNRESET' ||
+      // There is some false positive with @fastify/compress and aborted requests
+      (exception as any).code === 'ERR_STREAM_PREMATURE_CLOSE'
+    ) {
+      if (process.env.NODE_ENV !== 'production') {
+        this.logger.warning('Request aborted');
+      }
       return;
     }
 

src/core/exception/exception.normalizer.test.ts

@@ -1,5 +1,6 @@
 // eslint-disable-next-line no-restricted-imports,@seedcompany/no-restricted-imports
 import * as Nest from '@nestjs/common';
+import * as Fastify from 'fastify';
 import { InputException, ServerException } from '~/common';
 import { ConstraintError } from '../database';
 import { ExceptionNormalizer } from './exception.normalizer';
@@ -10,6 +11,23 @@ describe('ExceptionNormalizer', () => {
   const orig = sut.normalize.bind(sut);
   sut.normalize = (...args) => JSON.parse(JSON.stringify(orig(...args)));
 
+  describe('Fastify', () => {
+    it('Client', () => {
+      const ex = new Fastify.errorCodes.FST_ERR_CTP_BODY_TOO_LARGE();
+      const res = sut.normalize({ ex });
+      expect(res.message).toEqual('Request body is too large');
+      expect(res.code).toEqual('FST_ERR_CTP_BODY_TOO_LARGE');
+      expect(res.codes).toEqual(['FST_ERR_CTP_BODY_TOO_LARGE', 'Client']);
+    });
+    it('Server', () => {
+      const ex = new Fastify.errorCodes.FST_ERR_HOOK_INVALID_TYPE();
+      const res = sut.normalize({ ex });
+      expect(res.message).toEqual('The hook name must be a string');
+      expect(res.code).toEqual('FST_ERR_HOOK_INVALID_TYPE');
+      expect(res.codes).toEqual(['FST_ERR_HOOK_INVALID_TYPE', 'Server']);
+    });
+  });
+
   describe('HttpException', () => {
     it('simple', () => {
       const ex = new Nest.NotFoundException();

src/core/exception/exception.normalizer.ts

@@ -174,6 +174,23 @@ export class ExceptionNormalizer {
       return { codes: ['GraphQL', 'Server'] };
     }
 
+    // Fastify convention
+    if (
+      'code' in ex &&
+      typeof ex.code === 'string' &&
+      ex.code.startsWith('FST_')
+    ) {
+      const statusCode =
+        'statusCode' in ex && typeof ex.statusCode === 'number'
+          ? ex.statusCode
+          : undefined;
+      const codes = [
+        ex.code,
+        statusCode && statusCode < 500 ? 'Client' : 'Server',
+      ];
+      return { codes };
+    }
+
     // Fallback to generic Error
     return { codes: ['Server'] };
   }