Skip to content

Commit b31a24a

Browse files
committed
Drop Language.isWiderComm
I believe the thought here was that "wider communication" was a standardized piece of info that was declared, agreed upon, externally. And then this flag would limit the languages allowed for `Partner.languageOfWiderCommunication`. After reviewing with Seth/business, this relationship could really be to any language we have. And because of this there's no need to restrict. And now I'm doubting that this flag would serve the purpose, in practice, that I described above.
1 parent 1e7d1f4 commit b31a24a

File tree

8 files changed

+1
-23
lines changed

8 files changed

+1
-23
lines changed

dbschema/language.gel

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,6 @@ module default {
5252
default := false;
5353
};
5454

55-
required isWiderComm: bool {
56-
default := false;
57-
};
58-
5955
registryOfLanguageVarietiesCode: str {
6056
constraint exclusive;
6157
constraint regexp(r'^[0-9]{5}$');

dbschema/migrations/00019-m1w3qgq.edgeql

Lines changed: 1 addition & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/language/dto/create-language.dto.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,6 @@ export abstract class CreateLanguage {
106106
@Transform(({ value }) => uniq(value))
107107
readonly tags?: string[] = [];
108108

109-
@OptionalField()
110-
readonly isWiderComm?: boolean = false;
111-
112109
@OptionalField()
113110
readonly isAvailableForReporting?: boolean = false;
114111
}

src/components/language/dto/language.dto.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,6 @@ export class Language extends Interfaces {
169169
@Field()
170170
readonly tags: SecuredTags;
171171

172-
@Field()
173-
readonly isWiderComm: SecuredBoolean;
174-
175172
@Field()
176173
readonly isAvailableForReporting: SecuredBoolean;
177174

src/components/language/dto/list-language.dto.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,6 @@ export abstract class LanguageFilters {
6666
@FilterField(() => EthnologueLanguageFilters)
6767
readonly ethnologue?: EthnologueLanguageFilters & {};
6868

69-
@OptionalField()
70-
readonly isWiderComm?: boolean;
71-
7269
@OptionalField()
7370
readonly isAvailableForReporting?: boolean;
7471
}

src/components/language/dto/update-language.dto.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,6 @@ export abstract class UpdateLanguage {
111111
@ListField(() => String, { optional: true })
112112
readonly tags?: readonly string[];
113113

114-
@OptionalField()
115-
readonly isWiderComm?: boolean;
116-
117114
@OptionalField()
118115
readonly isAvailableForReporting?: boolean;
119116
}

src/components/language/language.repository.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ export class LanguageRepository extends DtoRepository<
8484
hasExternalFirstScripture: input.hasExternalFirstScripture,
8585
tags: input.tags,
8686
isAvailableForReporting: input.isAvailableForReporting,
87-
isWiderComm: input.isWiderComm,
8887
canDelete: true,
8988
};
9089

@@ -304,7 +303,6 @@ export const languageFilters = filter.define(() => LanguageFilters, {
304303
isSignLanguage: filter.propVal(),
305304
isDialect: filter.propVal(),
306305
isAvailableForReporting: filter.propVal(),
307-
isWiderComm: filter.propVal(),
308306
registryOfDialectsCode: filter.propPartialVal(
309307
'registryOfLanguageVarietiesCode',
310308
),

src/components/language/migrations/add-flags.migration.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { Language } from '../dto';
44
@Migration('2025-07-04T09:40:00')
55
export class AddLanguageFlagsMigration extends BaseMigration {
66
async up() {
7-
await this.addProperty(Language, 'isWiderComm', false);
87
await this.addProperty(Language, 'isAvailableForReporting', false);
98
}
109
}

0 commit comments

Comments
 (0)