Merge pull request #3244 from SeedCompany/project-workflow

Author: CarsonF

src/components/authorization/policies/conditions/creator.condition.ts

@@ -14,6 +14,7 @@ import {
   AsCypherParams,
   Condition,
   IsAllowedParams,
+  MissingContextException,
 } from '../../policy/conditions';
 
 const CQL_VAR = 'requestingUser';
@@ -27,7 +28,7 @@ class CreatorCondition<TResourceStatic extends ResourceShape<HasCreator>>
 {
   isAllowed({ object, session }: IsAllowedParams<TResourceStatic>) {
     if (!object) {
-      throw new Error("Needed object but wasn't given");
+      throw new MissingContextException();
     }
 
     const creator = (() => {

src/components/authorization/policies/conditions/enum-field.condition.ts

@@ -8,6 +8,7 @@ import {
   Condition,
   eqlInLiteralSet,
   IsAllowedParams,
+  MissingContextException,
 } from '../../policy/conditions';
 
 export class EnumFieldCondition<
@@ -25,14 +26,18 @@ export class EnumFieldCondition<
     // Double check at runtime that object has these, since they are usually
     // declared from DB, which cannot be verified.
     if (!object) {
-      throw new Error(`Needed object's ${this.path} but object wasn't given`);
+      throw new MissingContextException(
+        `Needed object's ${this.path} but object wasn't given`,
+      );
     }
     const value = get(object, this.path) as
       | Get<InstanceType<TResourceStatic>, Path>
       | undefined;
     const actual = unwrapSecured(value);
     if (!actual) {
-      throw new Error(`Needed object's ${this.path} but it wasn't found`);
+      throw new MissingContextException(
+        `Needed object's ${this.path} but it wasn't found`,
+      );
     }
 
     return this.allowed.has(actual);

src/components/authorization/policies/conditions/self.condition.ts

@@ -7,6 +7,7 @@ import {
   Condition,
   fqnRelativeTo,
   IsAllowedParams,
+  MissingContextException,
 } from '../../policy/conditions';
 
 const CQL_VAR = 'requestingUser';
@@ -16,7 +17,7 @@ class SelfCondition<TResourceStatic extends typeof User>
 {
   isAllowed({ object, session }: IsAllowedParams<TResourceStatic>) {
     if (!object) {
-      throw new Error("Needed user object but wasn't given");
+      throw new MissingContextException();
     }
     return object.id === session.userId;
   }

src/components/authorization/policies/conditions/sensitivity.condition.ts

@@ -7,6 +7,7 @@ import {
   Condition,
   fqnRelativeTo,
   IsAllowedParams,
+  MissingContextException,
 } from '../../policy/conditions';
 
 const sensitivityRank = { High: 3, Medium: 2, Low: 1 };
@@ -32,14 +33,14 @@ export class SensitivityCondition<
     // Double check at runtime that object has these, since they are usually
     // declared from DB which cannot be verified.
     if (!object) {
-      throw new Error("Needed object's sensitivity but object wasn't given");
+      throw new MissingContextException();
     }
     const actual: Sensitivity | undefined =
       Reflect.get(object, EffectiveSensitivity) ??
       Reflect.get(object, 'sensitivity');
 
     if (!actual) {
-      throw new Error(
+      throw new MissingContextException(
         "Needed object's sensitivity but object's sensitivity wasn't given",
       );
     }

src/components/authorization/policies/conditions/variant.condition.ts

@@ -6,6 +6,7 @@ import {
   Condition,
   eqlInLiteralSet,
   IsAllowedParams,
+  MissingContextException,
 } from '../../policy/conditions';
 
 const VariantForCondition = Symbol('Variant');
@@ -21,7 +22,7 @@ export class VariantCondition<TResourceStatic extends ResourceShape<any>>
 
   isAllowed({ object }: IsAllowedParams<TResourceStatic>) {
     if (!object) {
-      throw new Error("Needed object but wasn't given");
+      throw new MissingContextException();
     }
 
     const current = Reflect.get(

src/components/authorization/policy/conditions/index.ts

@@ -1,4 +1,5 @@
 export * from './condition.interface';
+export * from './missing-context.exception';
 export * from './aggregate.condition';
 export * from './calculated.condition';
 export * from './eql.util';

src/components/authorization/policy/conditions/missing-context.exception.ts

@@ -0,0 +1,7 @@
+import { ServerException } from '~/common';
+
+export class MissingContextException extends ServerException {
+  constructor(message?: string, cause?: Error) {
+    super(message ?? "Needed context object but wasn't given", cause);
+  }
+}

src/components/project/workflow/dto/execute-progress-report-transition.input.ts renamed to src/components/project/workflow/dto/execute-project-transition.input.ts

@@ -1,3 +1,3 @@
-export * from './execute-progress-report-transition.input';
+export * from './execute-project-transition.input';
 export * from './workflow-event.dto';
 export * from './workflow-transition.dto';

src/components/project/workflow/dto/index.ts

@@ -57,10 +57,6 @@ export class ProjectWorkflowService extends WorkflowService(
     );
   }
 
-  canBypass(session: Session) {
-    return this.privileges.for(session, WorkflowEvent).can('create');
-  }
-
   async executeTransition(
     input: ExecuteProjectTransitionInput,
     session: Session,