Remove session where not needed

Author: CarsonF

src/components/budget/budget.repository.ts

@@ -45,11 +45,7 @@ export class BudgetRepository extends DtoRepository<
     super();
   }
 
-  async create(
-    input: CreateBudget,
-    universalTemplateFileId: FileId,
-    session: Session,
-  ) {
+  async create(input: CreateBudget, universalTemplateFileId: FileId) {
     const initialProps = {
       status: Status.Pending,
       universalTemplateFile: universalTemplateFileId,

src/components/budget/budget.service.ts

@@ -54,7 +54,6 @@ export class BudgetService {
       const budgetId = await this.budgetRepo.create(
         { projectId, ...input },
         universalTemplateFileId,
-        session,
       );
 
       this.logger.debug(`Created Budget`, {

src/components/ceremony/ceremony.repository.ts

@@ -24,7 +24,7 @@ export class CeremonyRepository extends DtoRepository<
   typeof Ceremony,
   [session: Session]
 >(Ceremony) {
-  async create(input: CreateCeremony, session: Session) {
+  async create(input: CreateCeremony) {
     const initialProps = {
       type: input.type,
       planned: input.planned,

src/components/ceremony/ceremony.service.ts

@@ -27,9 +27,9 @@ export class CeremonyService {
     @Logger('ceremony:service') private readonly logger: ILogger,
   ) {}
 
-  async create(input: CreateCeremony, session: Session): Promise<ID> {
+  async create(input: CreateCeremony): Promise<ID> {
     try {
-      const result = await this.ceremonyRepo.create(input, session);
+      const result = await this.ceremonyRepo.create(input);
 
       if (!result) {
         throw new ServerException('failed to create a ceremony');

src/components/ceremony/handlers/create-engagement-default-ceremony.handler.ts

@@ -15,14 +15,14 @@ export class CreateEngagementDefaultCeremonyHandler
   ) {}
 
   async handle(event: EngagementCreatedEvent) {
-    const { engagement, session } = event;
+    const { engagement } = event;
     const input = {
       type:
         engagement.__typename === 'LanguageEngagement'
           ? CeremonyType.Dedication
           : CeremonyType.Certification,
     };
-    const ceremonyId = await this.ceremonies.create(input, session);
+    const ceremonyId = await this.ceremonies.create(input);
 
     // connect ceremonyId to engagement
     await this.db

src/components/changeset/changeset.repository.ts

@@ -8,15 +8,15 @@ import {
   or,
   relation,
 } from 'cypher-query-builder';
-import { ID, NotFoundException, Session } from '../../common';
+import { ID, NotFoundException } from '../../common';
 import { DtoRepository } from '../../core';
 import { ACTIVE, path, variable } from '../../core/database/query';
 import { BaseNode } from '../../core/database/results';
 import { Changeset, ChangesetDiff } from './dto';
 
 @Injectable()
 export class ChangesetRepository extends DtoRepository(Changeset) {
-  async difference(id: ID, _session: Session, parent?: ID) {
+  async difference(id: ID, parent?: ID) {
     const importVars = ['changeset', ...(parent ? ['parent'] : [])];
     const limitToParentSubTree = parent
       ? {

src/components/changeset/changeset.resolver.ts

@@ -31,7 +31,7 @@ export class ChangesetResolver {
     })
     parent?: ID,
   ): Promise<ChangesetDiff> {
-    const diff = await this.repo.difference(changeset.id, session, parent);
+    const diff = await this.repo.difference(changeset.id, parent);
     const load = (node: BaseNode, view?: ObjectView) =>
       this.resources.loadByBaseNode(node, view ?? { changeset: changeset.id });
     const [added, removed, changed] = await Promise.all([

src/components/ethno-art/ethno-art.repository.ts

@@ -1,7 +1,7 @@
 import { Injectable } from '@nestjs/common';
 import { Query } from 'cypher-query-builder';
 import { ChangesOf } from '~/core/database/changes';
-import { ID, Session } from '../../common';
+import { ID } from '../../common';
 import { DbTypeOf, DtoRepository } from '../../core';
 import {
   createNode,
@@ -23,7 +23,7 @@ export class EthnoArtRepository extends DtoRepository(EthnoArt) {
   constructor(private readonly scriptureRefs: ScriptureReferenceRepository) {
     super();
   }
-  async create(input: CreateEthnoArt, _session: Session) {
+  async create(input: CreateEthnoArt) {
     const initialProps = {
       name: input.name,
       canDelete: true,
@@ -45,7 +45,7 @@ export class EthnoArtRepository extends DtoRepository(EthnoArt) {
     await this.updateProperties(existing, simpleChanges);
   }
 
-  async list(input: EthnoArtListInput, _session: Session) {
+  async list(input: EthnoArtListInput) {
     const result = await this.db
       .query()
       .matchNode('node', 'EthnoArt')

src/components/ethno-art/ethno-art.service.ts

@@ -38,7 +38,7 @@ export class EthnoArtService {
     }
 
     try {
-      const result = await this.repo.create(input, session);
+      const result = await this.repo.create(input);
 
       if (!result) {
         throw new ServerException('Failed to create ethno art');
@@ -127,7 +127,7 @@ export class EthnoArtService {
   async list(input: EthnoArtListInput, session: Session) {
     // -- don't need a check for canList. all roles are allowed to see at least one prop,
     //    and this isn't a sensitive component.
-    const results = await this.repo.list(input, session);
+    const results = await this.repo.list(input);
     return await mapListResults(results, (dto) => this.secure(dto, session));
   }
 }

src/components/field-region/field-region.repository.ts

@@ -28,7 +28,7 @@ import {
 
 @Injectable()
 export class FieldRegionRepository extends DtoRepository(FieldRegion) {
-  async create(input: CreateFieldRegion, session: Session) {
+  async create(input: CreateFieldRegion) {
     if (!(await this.isUnique(input.name))) {
       throw new DuplicateException(
         'fieldRegion.name',