Ensure that invalid reads immediately following a creation throw a server error

CarsonF · CarsonF · commit c2b679a0ecb8 · 2025-04-17T10:43:33.000-05:00
This is a server problem, not a client one.
diff --git a/src/common/exceptions/creation-failed.exception.ts b/src/common/exceptions/creation-failed.exception.ts
@@ -13,3 +13,16 @@ export class CreationFailed extends ServerException {
     this.resource = res;
   }
 }
+
+export class ReadAfterCreationFailed extends CreationFailed {
+  constructor(
+    resource: ResourceLike,
+    options?: { message?: string; cause?: Error },
+  ) {
+    const res = EnhancedResource.resolve(resource);
+    super(res, {
+      message: `Failed to retrieve ${res.name} after creation`,
+      ...options,
+    });
+  }
+}
diff --git a/src/components/engagement/engagement.repository.ts b/src/components/engagement/engagement.repository.ts
@@ -20,6 +20,7 @@ import {
   labelForView,
   NotFoundException,
   ObjectView,
+  ReadAfterCreationFailed,
   ServerException,
   Session,
   typenameForView,
@@ -286,7 +287,11 @@ export class EngagementRepository extends CommonRepository {
       result.id,
       session,
       viewOfChangeset(changeset),
-    )) as UnsecuredDto<LanguageEngagement>;
+    ).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(LanguageEngagement)
+        : e;
+    })) as UnsecuredDto<LanguageEngagement>;
   }
 
   async createInternshipEngagement(
@@ -377,7 +382,11 @@ export class EngagementRepository extends CommonRepository {
       result.id,
       session,
       viewOfChangeset(changeset),
-    )) as UnsecuredDto<InternshipEngagement>;
+    ).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(InternshipEngagement)
+        : e;
+    })) as UnsecuredDto<InternshipEngagement>;
   }
 
   getActualLanguageChanges = getChanges(LanguageEngagement);
diff --git a/src/components/ethno-art/ethno-art.repository.ts b/src/components/ethno-art/ethno-art.repository.ts
@@ -4,7 +4,9 @@ import {
   CreationFailed,
   DuplicateException,
   ID,
+  NotFoundException,
   PaginatedListType,
+  ReadAfterCreationFailed,
   Session,
   UnsecuredDto,
 } from '~/common';
@@ -64,7 +66,11 @@ export class EthnoArtRepository extends DtoRepository(EthnoArt) {
       session,
     );
 
-    return await this.readOne(result.id);
+    return await this.readOne(result.id).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(EthnoArt)
+        : e;
+    });
   }
 
   async update(input: UpdateEthnoArt) {
diff --git a/src/components/field-region/field-region.repository.ts b/src/components/field-region/field-region.repository.ts
@@ -4,6 +4,8 @@ import {
   CreationFailed,
   DuplicateException,
   ID,
+  NotFoundException,
+  ReadAfterCreationFailed,
   SecuredList,
   Session,
   UnsecuredDto,
@@ -58,7 +60,11 @@ export class FieldRegionRepository extends DtoRepository(FieldRegion) {
       throw new CreationFailed(FieldRegion);
     }
 
-    return await this.readOne(result.id);
+    return await this.readOne(result.id).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(FieldRegion)
+        : e;
+    });
   }
 
   async update(changes: UpdateFieldRegion) {
diff --git a/src/components/field-zone/field-zone.repository.ts b/src/components/field-zone/field-zone.repository.ts
@@ -5,6 +5,8 @@ import {
   CreationFailed,
   DuplicateException,
   ID,
+  NotFoundException,
+  ReadAfterCreationFailed,
   SecuredList,
   Session,
   UnsecuredDto,
@@ -58,7 +60,11 @@ export class FieldZoneRepository extends DtoRepository(FieldZone) {
       throw new CreationFailed(FieldZone);
     }
 
-    return await this.readOne(result.id);
+    return await this.readOne(result.id).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(FieldZone)
+        : e;
+    });
   }
 
   protected hydrate() {
diff --git a/src/components/film/film.repository.ts b/src/components/film/film.repository.ts
@@ -4,7 +4,9 @@ import {
   CreationFailed,
   DuplicateException,
   ID,
+  NotFoundException,
   PaginatedListType,
+  ReadAfterCreationFailed,
   Session,
   UnsecuredDto,
 } from '~/common';
@@ -59,7 +61,11 @@ export class FilmRepository extends DtoRepository(Film) {
       session,
     );
 
-    return await this.readOne(result.id);
+    return await this.readOne(result.id).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(Film)
+        : e;
+    });
   }
 
   async update(input: UpdateFilm) {
diff --git a/src/components/funding-account/funding-account.service.ts b/src/components/funding-account/funding-account.service.ts
@@ -5,6 +5,7 @@ import {
   ID,
   NotFoundException,
   ObjectView,
+  ReadAfterCreationFailed,
   SecuredList,
   ServerException,
   Session,
@@ -51,7 +52,11 @@ export class FundingAccountService {
 
       this.logger.info(`funding account created`, { id: result.id });
 
-      return await this.readOne(result.id, session);
+      return await this.readOne(result.id, session).catch((e) => {
+        throw e instanceof NotFoundException
+          ? new ReadAfterCreationFailed(FundingAccount)
+          : e;
+      });
     } catch (err) {
       this.logger.error('Could not create funding account for user', {
         exception: err,
diff --git a/src/components/language/ethnologue-language/ethnologue-language.repository.ts b/src/components/language/ethnologue-language/ethnologue-language.repository.ts
@@ -4,6 +4,8 @@ import {
   CreationFailed,
   DuplicateException,
   ID,
+  NotFoundException,
+  ReadAfterCreationFailed,
   ServerException,
 } from '~/common';
 import { DtoRepository, UniquenessError } from '~/core/database';
@@ -56,7 +58,11 @@ export class EthnologueLanguageRepository extends DtoRepository(
       throw new CreationFailed(EthnologueLanguage);
     }
 
-    return await this.readOne(result.id);
+    return await this.readOne(result.id).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(EthnologueLanguage)
+        : e;
+    });
   }
 
   async update(changes: UpdateEthnologueLanguage & { id: ID }) {
diff --git a/src/components/language/language.repository.ts b/src/components/language/language.repository.ts
@@ -15,6 +15,7 @@ import {
   labelForView,
   NotFoundException,
   ObjectView,
+  ReadAfterCreationFailed,
   ServerException,
   Session,
   UnsecuredDto,
@@ -126,7 +127,11 @@ export class LanguageRepository extends DtoRepository<
       throw new CreationFailed(Language);
     }
 
-    return await this.readOne(result.id, session);
+    return await this.readOne(result.id, session).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(Language)
+        : e;
+    });
   }
 
   async update(
diff --git a/src/components/location/location.repository.ts b/src/components/location/location.repository.ts
@@ -6,6 +6,8 @@ import {
   DuplicateException,
   generateId,
   ID,
+  NotFoundException,
+  ReadAfterCreationFailed,
   ServerException,
   Session,
   UnsecuredDto,
@@ -74,7 +76,11 @@ export class LocationRepository extends DtoRepository(Location) {
       throw new CreationFailed(Location);
     }
 
-    const dto = await this.readOne(result.id);
+    const dto = await this.readOne(result.id).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(Location)
+        : e;
+    });
 
     await this.files.createDefinedFile(
       mapImageId,
diff --git a/src/components/organization/organization.repository.ts b/src/components/organization/organization.repository.ts
@@ -4,6 +4,8 @@ import {
   CreationFailed,
   DuplicateException,
   ID,
+  NotFoundException,
+  ReadAfterCreationFailed,
   Session,
   UnsecuredDto,
 } from '~/common';
@@ -64,7 +66,11 @@ export class OrganizationRepository extends DtoRepository<
       throw new CreationFailed(Organization);
     }
 
-    return await this.readOne(result.id, session);
+    return await this.readOne(result.id, session).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(Organization)
+        : e;
+    });
   }
 
   async update(changes: UpdateOrganization, session: Session) {
diff --git a/src/components/partner/partner.repository.ts b/src/components/partner/partner.repository.ts
@@ -7,6 +7,8 @@ import {
   DuplicateException,
   ID,
   InputException,
+  NotFoundException,
+  ReadAfterCreationFailed,
   Session,
   UnsecuredDto,
 } from '~/common';
@@ -104,7 +106,11 @@ export class PartnerRepository extends DtoRepository<
       throw new CreationFailed(Partner);
     }
 
-    return await this.readOne(result.id, session);
+    return await this.readOne(result.id, session).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(Partner)
+        : e;
+    });
   }
 
   async update(changes: UpdatePartner, session: Session) {
diff --git a/src/components/partnership/partnership.service.ts b/src/components/partnership/partnership.service.ts
@@ -3,7 +3,9 @@ import {
   CreationFailed,
   ID,
   InputException,
+  NotFoundException,
   ObjectView,
+  ReadAfterCreationFailed,
   ServerException,
   Session,
   UnsecuredDto,
@@ -90,7 +92,11 @@ export class PartnershipService {
         result.id,
         session,
         viewOfChangeset(changeset),
-      );
+      ).catch((e) => {
+        throw e instanceof NotFoundException
+          ? new ReadAfterCreationFailed(Partnership)
+          : e;
+      });
 
       this.privileges
         .for(session, Partnership, partnership)
diff --git a/src/components/product/product.service.ts b/src/components/product/product.service.ts
@@ -6,6 +6,7 @@ import {
   InputException,
   NotFoundException,
   ObjectView,
+  ReadAfterCreationFailed,
   ServerException,
   Session,
   UnsecuredDto,
@@ -154,7 +155,11 @@ export class ProductService {
           });
 
     this.logger.debug(`product created`, { id });
-    const created = await this.readOne(id, session);
+    const created = await this.readOne(id, session).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(Product)
+        : e;
+    });
 
     this.privileges
       .for(session, resolveProductType(created), created)
diff --git a/src/components/project-change-request/project-change-request.service.ts b/src/components/project-change-request/project-change-request.service.ts
@@ -2,7 +2,9 @@ import { forwardRef, Inject, Injectable } from '@nestjs/common';
 import {
   ID,
   InputException,
+  NotFoundException,
   ObjectView,
+  ReadAfterCreationFailed,
   ServerException,
   Session,
   UnsecuredDto,
@@ -52,7 +54,11 @@ export class ProjectChangeRequestService {
 
     const id = await this.repo.create(input);
 
-    return await this.readOne(id, session);
+    return await this.readOne(id, session).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(ProjectChangeRequest)
+        : e;
+    });
   }
 
   @HandleIdLookup(ProjectChangeRequest)
diff --git a/src/components/project/project.service.ts b/src/components/project/project.service.ts
@@ -10,6 +10,7 @@ import {
   many,
   NotFoundException,
   ObjectView,
+  ReadAfterCreationFailed,
   Role,
   SecuredList,
   ServerException,
@@ -151,7 +152,11 @@ export class ProjectService {
 
     try {
       const { id } = await this.repo.create(input);
-      const project = await this.readOneUnsecured(id, session);
+      const project = await this.readOneUnsecured(id, session).catch((e) => {
+        throw e instanceof NotFoundException
+          ? new ReadAfterCreationFailed(IProject)
+          : e;
+      });
 
       // Add creator to the project team with their global roles
       await this.projectMembers.create(
diff --git a/src/components/story/story.repository.ts b/src/components/story/story.repository.ts
@@ -4,7 +4,9 @@ import {
   CreationFailed,
   DuplicateException,
   ID,
+  NotFoundException,
   PaginatedListType,
+  ReadAfterCreationFailed,
   Session,
   UnsecuredDto,
 } from '~/common';
@@ -59,7 +61,11 @@ export class StoryRepository extends DtoRepository(Story) {
       session,
     );
 
-    return await this.readOne(result.id);
+    return await this.readOne(result.id).catch((e) => {
+      throw e instanceof NotFoundException
+        ? new ReadAfterCreationFailed(Story)
+        : e;
+    });
   }
 
   async update(input: UpdateStory) {
diff --git a/src/components/user/education/education.repository.ts b/src/components/user/education/education.repository.ts
diff --git a/src/components/user/unavailability/unavailability.repository.ts b/src/components/user/unavailability/unavailability.repository.ts
diff --git a/src/components/user/user.resolver.ts b/src/components/user/user.resolver.ts
