Merge pull request #3505 from SeedCompany/date-range-bugs

Author: CarsonF

src/components/engagement/handlers/validate-eng-date-overrides-on-project-change.handler.ts

@@ -3,7 +3,7 @@ import { EventsHandler, type IEventHandler } from '~/core';
 import { ProjectUpdatedEvent } from '../../project/events';
 import { EngagementService } from '../engagement.service';
 
-@EventsHandler(ProjectUpdatedEvent)
+@EventsHandler([ProjectUpdatedEvent, 10])
 export class ValidateEngDateOverridesOnProjectChangeHandler
   implements IEventHandler<ProjectUpdatedEvent>
 {

src/components/partnership/handlers/validate-partnership-date-overrides-on-project-change.handler.ts

@@ -5,7 +5,7 @@ import { OrganizationLoader } from '../../organization';
 import { ProjectUpdatedEvent } from '../../project/events';
 import { PartnershipService } from '../partnership.service';
 
-@EventsHandler(ProjectUpdatedEvent)
+@EventsHandler([ProjectUpdatedEvent, 10])
 export class ValidatePartnershipDateOverridesOnProjectChangeHandler
   implements IEventHandler<ProjectUpdatedEvent>
 {

src/components/periodic-report/handlers/sync-progress-report-to-engagement.handler.ts

@@ -1,3 +1,4 @@
+import { Settings } from 'luxon';
 import { DateInterval, type UnsecuredDto } from '~/common';
 import { EventsHandler, type IEventHandler, ILogger, Logger } from '~/core';
 import { EngagementService } from '../../engagement';
@@ -89,12 +90,33 @@ export class SyncProgressReportToEngagementDateRange
         : [event.engagement];
 
     for (const engagement of engagements) {
+      Settings.throwOnInvalid = false;
       const [updated, prev] =
         event instanceof ProjectUpdatedEvent
           ? this.intervalsFromProjectChange(engagement, event)
           : event instanceof EngagementCreatedEvent
           ? [engagementRange(event.engagement), null]
-          : [engagementRange(event.updated), engagementRange(event.previous)];
+          : [
+              engagementRange(event.updated), //
+              engagementRange(event.previous),
+            ];
+      Settings.throwOnInvalid = true;
+      if (prev && !prev.isValid) {
+        this.logger.error('Found invalid date range for event', {
+          eventType: event.constructor.name,
+          diffSide: 'before',
+          event,
+        });
+        throw new Error('Invalid engagement date range');
+      }
+      if (updated && !updated.isValid) {
+        this.logger.error('Found invalid date range for event', {
+          eventType: event.constructor.name,
+          diffSide: 'after',
+          event,
+        });
+        throw new Error('Invalid engagement date range');
+      }
 
       const diff = this.diffBy(updated, prev, 'quarter');