Expose FieldRegion.projects & FieldZone.projects #3530

rdonigian · 2025-07-18T21:11:43Z

No description provided.

github-actions · 2025-07-18T21:27:25Z

🗞 GraphQL Summary

View schema changes

@@ -1736,8 +1736,11 @@
   director: SecuredUser!
   fieldZone: SecuredFieldZone!
   id: ID!
   name: SecuredString!
+
+  """The list of projects in this field region"""
+  projects(input: ProjectListInput = {count: 25, order: ASC, page: 1, sort: "name"}): SecuredProjectList!
 }
 
 input FieldRegionFilters {
   director: UserFilters
@@ -1781,8 +1784,11 @@
   createdAt: DateTime!
   director: SecuredUser!
   id: ID!
   name: SecuredString!
+
+  """The list of projects in regions within this field zone"""
+  projects(input: ProjectListInput = {count: 25, order: ASC, page: 1, sort: "name"}): SecuredProjectList!
 }
 
 input FieldZoneFilters {
   director: UserFilters

… FieldRegionModule imports ProjectModule

coderabbitai · 2025-07-21T14:05:25Z

📝 Walkthrough

Walkthrough

This change introduces a projects property to both FieldRegion and FieldZone entities at the schema, DTO, service, and GraphQL resolver levels. Supporting migrations and module dependency adjustments are included to enable traversal and listing of related projects for these entities, along with updated service methods and module registrations.

Changes

Files/Paths	Change Summary
`dbschema/field-region.gel`, `dbschema/field-zone.gel`	Added computed multi-valued `projects` property to `FieldRegion` and `FieldZone` types.
`dbschema/migrations/00020-m1cjlgl.edgeql`	Migration adding multi links `projects` to `FieldRegion` and `FieldZone`.
`src/components/field-region/dto/field-region.dto.ts`, `src/components/field-zone/dto/field-zone.dto.ts`	Added static `Relations` property mapping `projects` relation for DTOs.
`src/components/field-region/field-region-projects.resolver.ts`, `src/components/field-zone/field-zone-projects.resolver.ts`	Added new GraphQL resolvers for `projects` field on `FieldRegion` and `FieldZone`.
`src/components/field-region/field-region.service.ts`, `src/components/field-zone/field-zone.service.ts`	Added `listProjects` method and injected `ProjectService` dependency.
`src/components/field-region/field-region.module.ts`, `src/components/field-zone/field-zone.module.ts`	Updated modules to import `ProjectModule` (with forwardRef) and register new resolvers.
`src/components/location/location.module.ts`, `src/components/organization/organization.module.ts`	Changed imports to use `forwardRef` for module dependencies.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Possibly related issues

Add Projects list to Field Region/Zone Pages cord-field#1709: Implements projects lists for Field Region/Zone pages, directly matching the new projects property and related resolvers/services.
Expose FieldRegion.projects & ProjectFilter.fieldRegion #3500: Exposes FieldRegion.projects and potentially FieldZone.projects, which is addressed by the new schema properties and supporting code.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2ea758 and dd8615f.

📒 Files selected for processing (8)

src/components/field-region/dto/field-region.dto.ts (1 hunks)
src/components/field-region/field-region-projects.resolver.ts (1 hunks)
src/components/field-region/field-region.module.ts (2 hunks)
src/components/field-region/field-region.service.ts (3 hunks)
src/components/field-zone/dto/field-zone.dto.ts (1 hunks)
src/components/field-zone/field-zone-projects.resolver.ts (1 hunks)
src/components/field-zone/field-zone.module.ts (2 hunks)
src/components/field-zone/field-zone.service.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (8)

src/components/field-region/field-region.module.ts
src/components/field-zone/field-zone.module.ts
src/components/field-zone/dto/field-zone.dto.ts
src/components/field-zone/field-zone.service.ts
src/components/field-region/dto/field-region.dto.ts
src/components/field-zone/field-zone-projects.resolver.ts
src/components/field-region/field-region.service.ts
src/components/field-region/field-region-projects.resolver.ts

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch region-zone-projects

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

CarsonF

Looks good, just need to spread in the sub filter objects

src/components/field-zone/field-zone.service.ts

Add projects computed links to FieldRegion and FieldZone

419a896

Fix circular dependencies, prevents module initialization errors when…

d61a667

… FieldRegionModule imports ProjectModule

rdonigian force-pushed the region-zone-projects branch 2 times, most recently from 91c9d80 to d2ea758 Compare July 21, 2025 12:40

rdonigian marked this pull request as ready for review July 21, 2025 14:01

rdonigian requested a review from CarsonF as a code owner July 21, 2025 14:01

rdonigian mentioned this pull request Jul 21, 2025

Region zone project grid SeedCompany/cord-field#1718

Open

rdonigian mentioned this pull request Jul 21, 2025

Expose FieldRegion.projects & ProjectFilter.fieldRegion #3500

Open

CarsonF requested changes Jul 28, 2025

View reviewed changes

src/components/field-zone/field-zone.service.ts Show resolved Hide resolved

rdonigian added 2 commits July 29, 2025 13:24

Expose FieldRegion.projects relationship in GraphQL API

7406ab8

Expose FieldZone.projects relationship in GraphQL API

dd8615f

rdonigian force-pushed the region-zone-projects branch from d2ea758 to dd8615f Compare July 29, 2025 17:24

rdonigian requested a review from CarsonF August 8, 2025 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expose FieldRegion.projects & FieldZone.projects #3530

Expose FieldRegion.projects & FieldZone.projects #3530

Uh oh!

rdonigian commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 21, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

CarsonF left a comment

Uh oh!

Uh oh!

Uh oh!

Expose FieldRegion.projects & FieldZone.projects #3530

Are you sure you want to change the base?

Expose FieldRegion.projects & FieldZone.projects #3530

Uh oh!

Conversation

rdonigian commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗞 GraphQL Summary

Uh oh!

coderabbitai bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

CarsonF left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

coderabbitai bot commented Jul 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)