updated sp test

Author: notTanveer

tests/test_embit_utils.py

@@ -437,20 +437,72 @@ def test_bip352_encode_silent_payment_address():
 
     Test vectors from the BIP: https://github.com/bitcoin/bips/blob/master/bip-0352/send_and_receive_test_vectors.json#L76
     """
-    spend_priv_key = "9d6ad855ce3417ef84e836892e5a56392bfba05fa5d97ccea30e266f540e08b3"
-    scan_priv_key = "0f694e068028a717f8af6b9411f9a133dd3565258714cc226594b34db90c1f2c"
-
-    spend_pk = PrivateKey(unhexlify(spend_priv_key))
-    scan_pk = PrivateKey(unhexlify(scan_priv_key))
-
-    scan_pubkey = scan_pk.get_public_key()
-    spend_pubkey = spend_pk.get_public_key()
-
-    payment_addr = embit_utils.encode_silent_payment_address(scan_pubkey, spend_pubkey)
-    assert payment_addr == "sp1qqgste7k9hx0qftg6qmwlkqtwuy6cycyavzmzj85c6qdfhjdpdjtdgqjuexzk6murw56suy3e0rd2cgqvycxttddwsvgxe2usfpxumr70xc9pkqwv"
+    BASIC_TEST_VECTORS = [
+        {
+        "spend_priv_key": "9d6ad855ce3417ef84e836892e5a56392bfba05fa5d97ccea30e266f540e08b3",
+        "scan_priv_key": "0f694e068028a717f8af6b9411f9a133dd3565258714cc226594b34db90c1f2c",
+        "sp_address": "sp1qqgste7k9hx0qftg6qmwlkqtwuy6cycyavzmzj85c6qdfhjdpdjtdgqjuexzk6murw56suy3e0rd2cgqvycxttddwsvgxe2usfpxumr70xc9pkqwv"
+        },
+        {
+        "spend_priv_key": "0000000000000000000000000000000000000000000000000000000000000001",
+        "scan_priv_key": "0000000000000000000000000000000000000000000000000000000000000002",
+        "sp_address": "sp1qqtrqglu5g8kh6mfsg4qxa9wq0nv9cauwfwxw70984wkqnw2uwz0w2qnehen8a7wuhwk9tgrzjh8gwzc8q2dlekedec5djk0js9d3d7qhnq6lqj3s"
+        }
+    ]
+
+    for vector in BASIC_TEST_VECTORS:
+        spend_pk = PrivateKey(unhexlify(vector["spend_priv_key"]))
+        scan_pk = PrivateKey(unhexlify(vector["scan_priv_key"]))
+
+        scan_pubkey = scan_pk.get_public_key()
+        spend_pubkey = spend_pk.get_public_key()
+
+        payment_addr = embit_utils.encode_silent_payment_address(scan_pubkey, spend_pubkey)
+        assert payment_addr == vector["sp_address"]
 
     # Test network payment addrs should start with "tsp"
     test_networks = [k for k in NETWORKS.keys() if k != "main"]
     for network in test_networks:
         payment_addr = embit_utils.encode_silent_payment_address(scan_pubkey, spend_pubkey, network=network)
-        assert payment_addr.startswith("tsp")
+        assert payment_addr.startswith("tsp")
+
+
+def test_bip352_encode_silent_payment_labeled_address():
+    LABEL_TEST_VECTORS = {
+    "spend_priv_key": "9d6ad855ce3417ef84e836892e5a56392bfba05fa5d97ccea30e266f540e08b3",
+    "scan_priv_key": "0f694e068028a717f8af6b9411f9a133dd3565258714cc226594b34db90c1f2c",
+    "labels": [
+        2,
+        3,
+        1001337
+        ],
+    "addresses": [
+        "sp1qqgste7k9hx0qftg6qmwlkqtwuy6cycyavzmzj85c6qdfhjdpdjtdgqjex54dmqmmv6rw353tsuqhs99ydvadxzrsy9nuvk74epvee55drs734pqq",
+        "sp1qqgste7k9hx0qftg6qmwlkqtwuy6cycyavzmzj85c6qdfhjdpdjtdgqsg59z2rppn4qlkx0yz9sdltmjv3j8zgcqadjn4ug98m3t6plujsq9qvu5n",
+        "sp1qqgste7k9hx0qftg6qmwlkqtwuy6cycyavzmzj85c6qdfhjdpdjtdgq7c2zfthc6x3a5yecwc52nxa0kfd20xuz08zyrjpfw4l2j257yq6qgnkdh5"
+        ]
+    }
+
+    spend_priv_key = PrivateKey(unhexlify(LABEL_TEST_VECTORS["spend_priv_key"]))
+    scan_priv_key = PrivateKey(unhexlify(LABEL_TEST_VECTORS["scan_priv_key"]))
+    
+    for label, address in zip(LABEL_TEST_VECTORS["labels"], LABEL_TEST_VECTORS["addresses"]):
+        sp_address = embit_utils.encode_labeled_silent_payment_address(scan_priv_key, spend_priv_key.get_public_key(), label)
+        assert sp_address == address
+
+    # Label may also be a string, but the bip does not provide any test vectors
+    embit_utils.encode_labeled_silent_payment_address(scan_priv_key, spend_priv_key.get_public_key(), label="tenant 6102")
+
+    # Label may also be passed in as bytes
+    embit_utils.encode_labeled_silent_payment_address(scan_priv_key, spend_priv_key.get_public_key(), label="i am bytes".encode())
+
+    # Label may also be a integer
+    embit_utils.encode_labeled_silent_payment_address(scan_priv_key, spend_priv_key.get_public_key(), label=42)
+
+    with pytest.raises(Exception):
+        # Label is required
+        embit_utils.encode_labeled_silent_payment_address(scan_priv_key, spend_priv_key.get_public_key())
+
+    with pytest.raises(Exception):
+        # Label must be an int, str, or bytes
+        embit_utils.encode_labeled_silent_payment_address(scan_priv_key, spend_priv_key.get_public_key(), label=1.0)