Merge pull request #153 from techie66/bugfix_140

ackPeng · web-flow · commit ad48756e56d4 · 2025-02-06T10:22:56.000+08:00
Change order of TX buffer fill to ensure in-order sending of frames.
diff --git a/src/mcp2515_can.cpp b/src/mcp2515_can.cpp
@@ -1038,7 +1038,7 @@ byte mcp2515_can::mcp2515_getNextFreeTXBuf(byte* txbuf_n) {               // get
     }
 
     // check all 3 TX-Buffers except reserved
-    for (i = 0; i < MCP_N_TXBUFFERS - nReservedTx; i++) {
+    for (i = MCP_N_TXBUFFERS - nReservedTx; i >= 0; i--) {
         if ((status & txStatusPendingFlag(i)) == 0) {
             *txbuf_n = txCtrlReg(i) + 1;                                   // return SIDH-address of Buffer
             mcp2515_modifyRegister(MCP_CANINTF, txIfFlag(i), 0);

Original file line number	Diff line number	Diff line change
`@@ -1038,7 +1038,7 @@ byte mcp2515_can::mcp2515_getNextFreeTXBuf(byte* txbuf_n) { // get`
`1038`	`1038`	`}`
`1039`	`1039`
`1040`	`1040`	`// check all 3 TX-Buffers except reserved`
`1041`		`- for (i = 0; i < MCP_N_TXBUFFERS - nReservedTx; i++) {`
	`1041`	`+ for (i = MCP_N_TXBUFFERS - nReservedTx; i >= 0; i--) {`
`1042`	`1042`	`if ((status & txStatusPendingFlag(i)) == 0) {`
`1043`	`1043`	`*txbuf_n = txCtrlReg(i) + 1; // return SIDH-address of Buffer`
`1044`	`1044`	`mcp2515_modifyRegister(MCP_CANINTF, txIfFlag(i), 0);`