Skip to content

Commit 5e79f36

Browse files
authored
549-bug-country-not-loaded-in-pdf (#550)
* ADD: test with full address for pdf creation Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com> * FIX: use the name of country instead of object Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com> * FORMAT Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com> * FORMAT Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com> --------- Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
1 parent 7080b74 commit 5e79f36

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

invoice/pdf_generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def render_address(x, y, address, prefix_lines=(), suffix_lines=()):
5757
address.line_2,
5858
address.line_3,
5959
f"{address.postcode} {address.city}",
60-
address.country,
60+
address.country.name,
6161
]
6262
if line
6363
]

invoice/tests.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1861,6 +1861,25 @@ def test_forbidden(self):
18611861
response = self.client.get(reverse("invoice-pdf", kwargs={"invoice_id": self.invoice.pk}))
18621862
self.assertEqual(response.status_code, 403)
18631863

1864+
def test_with_full_address(self):
1865+
address = Address.objects.create(
1866+
line_1="Teststreet 1",
1867+
line_2="Building 4",
1868+
line_3="Floor 3",
1869+
postcode="12345",
1870+
city="Testcity",
1871+
state="Bayern",
1872+
country="DE",
1873+
)
1874+
vendor = Vendor.objects.create(name="Vendor 2", address=address, user=self.user)
1875+
customer = Customer.objects.create(address=address, vendor=vendor)
1876+
invoice = Invoice.objects.create(invoice_number=1, vendor=vendor, customer=customer, date=now())
1877+
self.client.force_login(self.user)
1878+
response = self.client.get(reverse("invoice-pdf", kwargs={"invoice_id": invoice.pk}), follow=True)
1879+
self.assertEqual(response.status_code, 200)
1880+
self.assertEqual(response.get("Content-Type"), "application/pdf")
1881+
self.assertEqual(response.status_code, 200)
1882+
18641883

18651884
class InvoiceListViewTestCase(TestCase):
18661885
@classmethod

0 commit comments

Comments
 (0)