Merge branch 'main' into 353-bug-ui-paid-should-not-be-available-if-invoice-is-not-final

Author: iTitus

invoice/models.py

@@ -4,7 +4,7 @@
 from decimal import Decimal
 from functools import reduce
 from math import isnan, isinf
-from typing import Dict
+from typing import Dict, List
 
 try:
     from warnings import deprecated
@@ -186,8 +186,10 @@ def save(self, *args, **kwargs):
         super().save(*args, **kwargs)
 
     @property
-    def items(self):
-        """Get list of invoice items."""
+    def items(self) -> List['InvoiceItem']:
+        """Get list of invoice items. Returns empty list if the invoice is not saved yet."""
+        if self.pk is None:
+            return []
         return list(self.invoiceitem_set.all())
 
     @property

invoice/tests.py

@@ -1078,6 +1078,12 @@ def test_tax_amount_strings_exclude_zero_rate(self):
                                    tax=Decimal('0'))
         self.assertEqual(invoice.tax_amount_strings, {'19%': '19.00 EUR'})
 
+    def test_invoice_items_without_save(self):
+        invoice = Invoice(invoice_number=1, vendor=Vendor.objects.first(),
+                          customer=Customer.objects.first(), date=now())
+        self.assertEqual(len(invoice.items), 0)
+
+
 class InvoicePDFViewTestCase(TestCase):
     @classmethod
     def setUpClass(cls):