Internal set / modify.cpp add-name is failing on matching prefixes instead of exact matches

[iamnove]

@Seifert69 for add-name this is failing on false positives due to matching prefixes, some names can't be added

Originally posted by @iamnove in 494ac0a

[Seifert69]

At a quick glance that looks like a risky change.

Can you please write a test() that would fail before and work with your fix? I'm not entirely sure what you're saying is broken? And maybe it's by design (a name is not allowed to be a substring of an existing name AFAIR - but it's hidden far away in memory so an example would help me understand your suggestions better).

Thank you

[iamnove]

For names list: {"trick bag", "bag"}

"set bag add-name bag of tricks" says the name was added but actually fails silently because the common "bag" prefix stops it.

Final name order should be longer to shorter (ideal state would be just inserting it in correct position when doing add-name), but old behaviour you can just add the new name then del-name and add-name bag to put it back in correct order.

With the new check it says it works but doesn't, then if you don't have an additional name to rely on you have to add-name a dummy name "temp123", del-name "bag", then add-name "bag of tricks", then add-name "bag", then del-name "temp123".

The behaviour is also inconsistent with nset (the set.zon DIL version), which just appends it regardless.

[Seifert69]

Ok, I see, thanks for the explanation. Why don't you make it part of the Names class?

We already have AppendName:

ed->names.AppendName(strarg);

So how about adding your insert_comma_names to the class in some form, as a class member?