Allow disabling event timing

Author: davschneller

AbstractAPI.h

@@ -94,7 +94,7 @@ struct AbstractAPI {
 
   virtual void streamWaitMemory(void* streamPtr, uint32_t* location, uint32_t value) = 0;
 
-  virtual void* createEvent() = 0;
+  virtual void* createEvent(bool withTiming = false) = 0;
   virtual void destroyEvent(void* eventPtr) = 0;
   virtual void syncEventWithHost(void* eventPtr) = 0;
   virtual bool isEventCompleted(void* eventPtr) = 0;

interfaces/cuda/CudaWrappedAPI.h

@@ -85,7 +85,7 @@ class ConcreteAPI : public AbstractAPI {
 
   void streamWaitMemory(void* streamPtr, uint32_t* location, uint32_t value) override;
 
-  void* createEvent() override;
+  void* createEvent(bool withTiming) override;
   void destroyEvent(void* eventPtr) override;
   void syncEventWithHost(void* eventPtr) override;
   bool isEventCompleted(void* eventPtr) override;

interfaces/cuda/Events.cu

@@ -13,9 +13,14 @@
 
 using namespace device;
 
-void* ConcreteAPI::createEvent() {
-  cudaEvent_t event;
-  APIWRAP(cudaEventCreate(&event));
+void* ConcreteAPI::createEvent(bool withTiming) {
+  cudaEvent_t event{};
+  if (withTiming) {
+    APIWRAP(cudaEventCreate(&event));
+  }
+  else {
+    APIWRAP(cudaEventCreateWithFlags(&event, cudaEventDisableTiming));
+  }
   CHECK_ERR;
   return static_cast<void*>(event);
 }

interfaces/hip/Events.cpp

@@ -14,9 +14,14 @@
 
 using namespace device;
 
-void* ConcreteAPI::createEvent() {
+void* ConcreteAPI::createEvent(bool withTiming) {
   hipEvent_t event;
-  APIWRAP(hipEventCreate(&event));
+  if (withTiming) {
+    APIWRAP(hipEventCreate(&event));
+  }
+  else {
+    APIWRAP(hipEventCreateWithFlags(&event, hipEventDisableTiming));
+  }
   return static_cast<void*>(event);
 }
 

interfaces/hip/HipWrappedAPI.h

@@ -85,7 +85,7 @@ class ConcreteAPI : public AbstractAPI {
 
   void streamWaitMemory(void* streamPtr, uint32_t* location, uint32_t value) override;
 
-  void* createEvent() override;
+  void* createEvent(bool withTiming) override;
   void destroyEvent(void* eventPtr) override;
   void syncEventWithHost(void* eventPtr) override;
   bool isEventCompleted(void* eventPtr) override;

interfaces/sycl/Events.cpp

@@ -23,7 +23,7 @@ struct Event {
 };
 } // namespace
 
-void* ConcreteAPI::createEvent() {
+void* ConcreteAPI::createEvent(bool withTiming) {
   return new Event();
 }
 

interfaces/sycl/SyclWrappedAPI.h

@@ -119,7 +119,7 @@ class ConcreteAPI : public AbstractAPI {
 
   void streamWaitMemory(void* streamPtr, uint32_t* location, uint32_t value) override;
 
-  void* createEvent() override;
+  void* createEvent(bool withTiming) override;
   void destroyEvent(void* eventPtr) override;
   void syncEventWithHost(void* eventPtr) override;
   bool isEventCompleted(void* eventPtr) override;

tests/CMakeLists.txt

@@ -2,7 +2,7 @@
 #
 # SPDX-License-Identifier: BSD-3-Clause
 
-cmake_minimum_required(VERSION 3.5)
+cmake_minimum_required(VERSION 3.14)
 project(examples)
 
 #set(CMAKE_CXX_CLANG_TIDY clang-tidy)