chore: move the Seismic tx test helpers into their own crate (#483)

Fixes SEI-343

reth-seismic-primitives exported 458 lines of test helpers as `pub mod
test_utils` — transaction builders, client-side encryption, signing
fixtures with hardcoded private keys — from the default public API of a
crate every consumer depends on, the production node included. They now
live in crates/seismic/test-utils
(`reth-seismic-test-utils`), reached only through a `[dev-dependencies]`
line. `[dev-dependencies]` are in scope for the listing crate's test,
bench, and example targets, so `use reth_seismic_test_utils::…` from a
crate's `src/` does not resolve.

Nothing marks a crate dev-only workspace-wide — someone can always move
the line into `[dependencies]` — but that is one visible line in the
manifest of the crate doing it, caught in review. What a dev-dependency
rules out is the leak a feature cannot avoid: features unify across a
build and dev-dependency features fold in whenever test targets are
built, so under a `test-utils` feature on the primitives crate, one
crate's dev-dependency would turn the module on for every crate in the
same `cargo test --workspace`. Production code in reth-seismic-node
could import the helpers, compile clean in CI's test job, and break only
in a later `cargo build` of the binary — an error in a crate nobody
touched.

The file moves verbatim. reth-seismic-primitives drops the module and
the ten dependencies only those helpers used: seismic-crypto,
seismic-alloy-network, seismic-alloy-rpc-types, alloy-signer-local,
alloy-rpc-types, alloy-dyn-abi, alloy-network, enr, k256, and anyhow.
Its manifest now lists what the primitives actually need. secp256k1 is
the one that stays: the rest of the crate reaches it only from the
`arbitrary` impl, so it becomes optional under the `arbitrary` feature
and a dev-dependency for the crate's own tests, the shape rand_08
already has there.

Call sites take the new import path with a dev-dependency:
primitives/src/transaction/signed.rs, rpc/src/eth/receipt.rs,
rpc/src/eth/utils.rs, txpool/src/transaction.rs, and
txpool/benches/eviction_scan.rs. reth-seismic-node's `utils::test_utils`
re-export goes away — its only consumers are that crate's own e2e tests,
which depend on the new crate directly — and the module keeps
`get_nonce` behind the node's `test-utils` feature.

primitives dev-depends on a crate that depends on primitives. Cargo
allows dev-dependency cycles: dev edges do not participate in the lib
build graph, and this repo already leans on the self-cycle
reth-seismic-node dev-depending on itself with `features =
["test-utils"]`.

Author: samlaf

Cargo.lock

@@ -21,6 +21,7 @@ members = [
     "crates/seismic/primitives/",
     "crates/seismic/reth/",
     "crates/seismic/rpc/",
+    "crates/seismic/test-utils/",
     "crates/seismic/txpool/",
     "crates/seismic/hardforks",
     "crates/seismic/fuzz",
@@ -358,6 +359,7 @@ reth-seismic-payload-builder = { path = "crates/seismic/payload" }
 reth-seismic-primitives = { path = "crates/seismic/primitives" }
 reth-seismic-reth = { path = "crates/seismic/reth" }
 reth-seismic-rpc = { path = "crates/seismic/rpc" }
+reth-seismic-test-utils = { path = "crates/seismic/test-utils" }
 reth-seismic-txpool = { path = "crates/seismic/txpool" }
 reth-seismic-forks = { path = "crates/seismic/hardforks", default-features = false }
 reth-seismic-fuzz = { path = "crates/seismic/fuzz" }

Cargo.toml

@@ -95,6 +95,7 @@ reth-e2e-test-utils = { workspace = true }
 reth-rpc-e2e-tests.workspace = true
 reth-seismic-evm.workspace = true
 reth-seismic-chainspec.workspace = true
+reth-seismic-test-utils.workspace = true
 alloy-network = { workspace = true }
 alloy-chains.workspace = true
 alloy-signer-local = { workspace = true }

crates/seismic/node/Cargo.toml

@@ -94,24 +94,14 @@ pub mod e2e {
     }
 }
 
-/// RPC test utilities: nonce helpers, re-exported test helpers.
+/// RPC test utilities: nonce helpers.
 pub mod test_utils {
     use alloy_primitives::Address;
     use alloy_rpc_types::{Block, Header, Transaction, TransactionReceipt};
     use jsonrpsee::http_client::HttpClient;
     use reth_rpc_eth_api::EthApiClient;
     use seismic_alloy_rpc_types::SeismicTransactionRequest;
 
-    pub use reth_seismic_primitives::test_utils::{
-        client_decrypt, client_encrypt, get_ciphertext, get_client_io_sk, get_encryption_nonce,
-        get_network_public_key, get_plaintext, get_seismic_elements, get_seismic_metadata,
-        get_seismic_tx, get_signed_read_seismic_metadata, get_signed_seismic_call_bytes,
-        get_signed_seismic_call_typed_data, get_signed_seismic_tx, get_signed_seismic_tx_bytes,
-        get_signed_seismic_tx_encoding, get_signed_seismic_tx_typed_data, get_signing_private_key,
-        get_unsigned_seismic_call_request, get_unsigned_seismic_tx_request,
-        get_unsigned_seismic_tx_typed_data, get_wrong_private_key, sign_seismic_tx, sign_tx,
-    };
-
     /// Get the nonce from the client
     pub async fn get_nonce(client: &HttpClient, address: Address) -> u64 {
         let nonce = EthApiClient::<

crates/seismic/node/src/utils.rs

@@ -16,9 +16,10 @@ use jsonrpsee::{core::client::ClientT, http_client::HttpClientBuilder, rpc_param
 use rand::{rngs::SmallRng, Rng, SeedableRng};
 use reth_seismic_node::utils::{
     e2e::{ensure_mock_purpose_keys, setup},
-    test_utils::{get_nonce, get_signed_seismic_tx_bytes},
+    test_utils::get_nonce,
 };
 use reth_seismic_rpc::ext::EthApiOverrideClient;
+use reth_seismic_test_utils::get_signed_seismic_tx_bytes;
 use tracing::{info, trace};
 
 /// Number of random payloads per fuzz batch

crates/seismic/node/tests/e2e/fuzz.rs

@@ -31,18 +31,16 @@ use reth_e2e_test_utils::wallet::Wallet;
 use reth_rpc_eth_api::EthApiClient;
 use reth_seismic_node::utils::{
     e2e::{ensure_mock_purpose_keys, setup, SeismicTestNode},
-    test_utils::{
-        client_decrypt, get_nonce, get_plaintext, get_signed_read_seismic_metadata,
-        get_signed_seismic_call_bytes, get_signed_seismic_call_typed_data,
-        get_signed_seismic_tx_bytes, get_unsigned_seismic_call_request,
-        get_unsigned_seismic_tx_request,
-    },
-};
-use reth_seismic_primitives::{
-    test_utils::{get_unsigned_legacy_tx_request, sign_tx},
-    SeismicBlock, SeismicTransactionSigned,
+    test_utils::get_nonce,
 };
+use reth_seismic_primitives::{SeismicBlock, SeismicTransactionSigned};
 use reth_seismic_rpc::ext::EthApiOverrideClient;
+use reth_seismic_test_utils::{
+    client_decrypt, get_plaintext, get_signed_read_seismic_metadata, get_signed_seismic_call_bytes,
+    get_signed_seismic_call_typed_data, get_signed_seismic_tx_bytes,
+    get_unsigned_legacy_tx_request, get_unsigned_seismic_call_request,
+    get_unsigned_seismic_tx_request, sign_tx,
+};
 use seismic_alloy_consensus::SeismicTxEnvelope;
 use seismic_alloy_network::{
     reth::builder::seismic_reth_tx_builder, wallet::SeismicWallet, SeismicReth,

crates/seismic/node/tests/e2e/integration.rs

@@ -19,10 +19,8 @@ use reth_seismic_node::{
     engine::SeismicPayloadTypes,
     utils::e2e::{ensure_mock_purpose_keys, setup},
 };
-use reth_seismic_primitives::{
-    test_utils::{get_unsigned_legacy_tx_request, sign_tx},
-    SeismicBlock, SeismicTransactionSigned,
-};
+use reth_seismic_primitives::{SeismicBlock, SeismicTransactionSigned};
+use reth_seismic_test_utils::{get_unsigned_legacy_tx_request, sign_tx};
 use std::time::Duration;
 
 /// A block containing a transaction signed for a different chain must be rejected by

crates/seismic/node/tests/e2e/wrong_chain_import.rs

@@ -12,8 +12,6 @@ description = "Seismic primitive types"
 workspace = true
 
 [dependencies]
-seismic-crypto.workspace = true
-
 # reth
 reth-primitives-traits = { workspace = true, features = ["serde"] }
 reth-codecs = { workspace = true, optional = true }
@@ -26,11 +24,9 @@ alloy-primitives = { workspace = true, features = ["serde"] }
 alloy-consensus.workspace = true
 alloy-rlp.workspace = true
 alloy-eips = { workspace = true, features = ["k256"] }
-alloy-network = { workspace = true }
 
 # seismic
 seismic-alloy-consensus.workspace = true
-seismic-alloy-network = { workspace = true }
 seismic-revm.workspace = true
 
 # codec
@@ -41,31 +37,24 @@ serde_with = { workspace = true, optional = true }
 
 # misc
 derive_more = { workspace = true, features = ["deref", "from", "into", "constructor"] }
-secp256k1 = { workspace = true, features = ["rand", "std", "global-context", "recovery"] }
-anyhow.workspace = true
+secp256k1 = { workspace = true, features = ["rand", "std", "global-context", "recovery"], optional = true }
 tracing.workspace = true
 
 # test
 arbitrary = { workspace = true, features = ["derive"], optional = true }
 rand_08 = { workspace = true, optional = true }
 proptest = { workspace = true, optional = true }
 
-# test utils
-alloy-signer-local.workspace = true
-alloy-rpc-types.workspace = true
-k256.workspace = true
-enr = { workspace = true, features = ["rust-secp256k1"] }
-alloy-dyn-abi.workspace = true
-seismic-alloy-rpc-types.workspace = true
-
 [dev-dependencies]
 arbitrary.workspace = true
 proptest-arbitrary-interop.workspace = true
 proptest.workspace = true
 rand.workspace = true
 rand_08.workspace = true
 reth-codecs = { workspace = true, features = ["test-utils"] }
+reth-seismic-test-utils.workspace = true
 rstest.workspace = true
+secp256k1 = { workspace = true, features = ["rand", "std", "global-context", "recovery"] }
 serde_json.workspace = true
 bincode.workspace = true
 
@@ -81,17 +70,14 @@ std = [
     "serde?/std",
     "bytes?/std",
     "derive_more/std",
-    "secp256k1/std",
+    "secp256k1?/std",
     "alloy-rlp/std",
     "reth-zstd-compressors?/std",
     "seismic-alloy-consensus/std",
     "revm-context/std",
     "serde_json/std",
     "alloy-evm/std",
     "serde_with?/std",
-    "k256/std",
-    "seismic-alloy-network/std",
-    "seismic-alloy-rpc-types/std",
     "tracing/std",
 ]
 reth-codec = [
@@ -114,13 +100,9 @@ serde = [
     "reth-codecs?/serde",
     "seismic-alloy-consensus/serde",
     "rand/serde",
-    "secp256k1/serde",
+    "secp256k1?/serde",
     "revm-context/serde",
-    "enr/serde",
-    "k256/serde",
     "rand_08?/serde",
-    "seismic-alloy-network/serde",
-    "seismic-alloy-rpc-types/serde",
     "seismic-revm/serde",
 ]
 serde-bincode-compat = [
@@ -134,7 +116,7 @@ serde-bincode-compat = [
 arbitrary = [
     "std",
     "dep:arbitrary",
-    # "dep:secp256k1",
+    "dep:secp256k1",
     "secp256k1/rand",
     "reth-primitives-traits/arbitrary",
     "reth-codecs?/arbitrary",
@@ -143,7 +125,4 @@ arbitrary = [
     "alloy-eips/arbitrary",
     "alloy-primitives/arbitrary",
     "rand_08",
-    "alloy-dyn-abi/arbitrary",
-    "alloy-rpc-types/arbitrary",
-    "seismic-alloy-rpc-types/arbitrary",
 ]

crates/seismic/primitives/Cargo.toml

@@ -18,7 +18,6 @@ pub use transaction::{
 
 mod receipt;
 pub use receipt::SeismicReceipt;
-pub mod test_utils;
 
 /// Seismic-specific block type.
 pub type SeismicBlock = alloy_consensus::Block<SeismicTransactionSigned>;

crates/seismic/primitives/src/lib.rs

@@ -724,7 +724,7 @@ pub mod serde_bincode_compat {
 mod tests {
     use core::str::FromStr;
 
-    use crate::test_utils::{get_signed_seismic_tx, get_signing_private_key};
+    use reth_seismic_test_utils::{get_signed_seismic_tx, get_signing_private_key};
 
     use super::*;
     use alloy_primitives::{aliases::U96, hex, U256};