Commit f55cf48
fix(rpc): surface StorageOverrideNotPermitted from seismic-evm (#384)
## Summary
Companion to
[seismic-evm#52](SeismicSystems/seismic-evm#52),
which rejects `state` / `stateDiff` overrides at the
`apply_account_override` chokepoint to close an audit finding where
signed reads could be evaluated against attacker-controlled storage.
- Adds `EthApiError::StorageOverrideNotPermitted(Address)` next to the
existing `CodeOverrideNotPermitted` variant.
- Includes it in the `invalid_params_rpc_err` arm so it surfaces as
`-32602` (matching the code-override behavior).
- Maps the underlying `StateOverrideError::StorageOverrideNotPermitted`
through `From<StateOverrideError> for EthApiError`.
- Bumps `alloy-evm` / `alloy-seismic-evm` to the seismic-evm branch tip
(`e644240`) so the new variant resolves.
## Merge order
**Do not merge this PR until:**
1.
[seismic-evm#52](SeismicSystems/seismic-evm#52)
is merged to `seismic`.
2. The `alloy-evm` / `alloy-seismic-evm` rev in `Cargo.toml` (lines
794-795) is re-bumped to the **post-merge commit on `seismic`** — the
current pin points at the branch commit, which will differ from the
merge commit (squash / merge / rebase).
## Test plan
- [ ] After dep re-bump: `cargo check -p reth-rpc-eth-types` builds
clean for the error module changes. (Note: the base
`veridise-audit-april-2026` has pre-existing `Url: serde` errors
unrelated to this PR — verified by building the baseline without these
changes.)
- [ ] Signed `eth_call` with a `stateDiff` override returns `-32602
invalid params` with the storage-override message.
---------
Co-authored-by: henry-ai <henrymbaldwin+ai@proton.me>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent e97866d commit f55cf48
4 files changed
Lines changed: 157 additions & 4 deletions
File tree
- crates
- rpc/rpc-eth-types/src/error
- seismic/node/tests/e2e
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
792 | 792 | | |
793 | 793 | | |
794 | 794 | | |
795 | | - | |
796 | | - | |
| 795 | + | |
| 796 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
121 | 124 | | |
122 | 125 | | |
123 | 126 | | |
| |||
258 | 261 | | |
259 | 262 | | |
260 | 263 | | |
| 264 | + | |
261 | 265 | | |
262 | 266 | | |
263 | 267 | | |
| |||
356 | 360 | | |
357 | 361 | | |
358 | 362 | | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
359 | 366 | | |
360 | 367 | | |
361 | 368 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1390 | 1390 | | |
1391 | 1391 | | |
1392 | 1392 | | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
| 1407 | + | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
| 1447 | + | |
| 1448 | + | |
| 1449 | + | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
| 1467 | + | |
| 1468 | + | |
| 1469 | + | |
| 1470 | + | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
| 1534 | + | |
| 1535 | + | |
| 1536 | + | |
| 1537 | + | |
| 1538 | + | |
0 commit comments