LogRecord->with does not transfers "formatted" value

[Justinas-Jurciukonis]

Monolog version 3.2.0

When PsrLogMessageProcessor processes message, it returns new instance of LogRecord using code

return $record->with(message: strtr($record->message, $replacements), context: $context);

and inside LogRecord->with there is missing formatted key to be copied over, so if any previous processor set any information inside LogRecord->formatted it will be lost.

Seems like same issue with toArray

[Seldaek]

Normally formatting happens after processing, so this should never be a problem. Have you experienced an actual issue?

[Justinas-Jurciukonis]

@Seldaek Yes, since we use custom logic to format all records.

Basically logic was as follows:

1. Create new structure to formatted property
2. Every processor adds it's own information to this formatted to the place where it needs to be
3. Formatter converts log record to JSON or Plain text log, but keeps structure from formatted. Means formatters only responsible for final output, but not structure of log itself

With this approach formatters does not care about structure, just how format LogRecord to string. Processors are responsible for it's own parts of LogRecord->formatted processing.

E.g. Adding information about current user can come from 3 different processors and it merges under key LogRecord->formatted->user

[stof]

This looks like the use case for LogRecord->extra instead

[Seldaek]

Right, exactly my thinking @stof - sounds to me like these processors should all record stuff in extra as they are meant to, and then the final formatter can use the info in context/extra to generate the final formatted record.