chore(ci): Fix linting in the seldon_core Python package(mainly) (#7015)

* Fix 1 lint error

* Fix more lint errors

* Remove old conda version dev dep in python folder

* Add git diff to understand why diffing the licensing fails

* Disable otherworkflows white investingating

* Add pwd and ls

* Make licenses for python

* Tweak makefile to correctly point to git repo root

* Attempt to make the git folder discoverable after checkout in container

* Add 'and' operator for all commands in make lint

* notebooks lint

* make lint: run black only

* make lint: run isort only

* make lint: run flake8 only

* make lint: run nbqa black only

* make lint: run nbqa isort only

* make lint: run git diff only

* Print git version in workflow

* lint workflow: downgrade checkout action from 4 to 2

* Set fetch-depth to 0 when cloning repo

* Resolve repo root in a different way

* add steps for the workflow to commit changes in licenses

* Mark dir as safe

* Add git push

* resolve branch

* push if push event

* Turn on the rest of the workflows

* Manually commit licenses

Author: vtaskow

.github/workflows/python_lint.yml

@@ -2,20 +2,55 @@ name: V1 Python Lint
 
 on:
   push:
-    branches: [ master ]
+    branches:
+      - master
+      - release-1.19.0-prep
   pull_request:
     # TODO revert before merge to master
-    branches: [ release-1.19.0-prep ]
+    branches: [ master, release-1.19.0-prep ]
   workflow_dispatch:
 
+env:
+  GITHUB_USER: seldondev
+
 jobs:
   python-lint:
-
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
     container: seldonio/python-builder:0.9
 
     steps:
-    - uses: actions/checkout@v2
-    - name: lint-python
+    - name: Resolve branch
+      run: |
+        if [ "${{ github.event_name }}" = "push" ]; then
+          echo "BRANCH=${GITHUB_REF#refs/heads/}" >> $GITHUB_ENV
+        else
+          echo "BRANCH=${{ github.head_ref }}" >> $GITHUB_ENV
+        fi
+
+    - uses: actions/checkout@v4
+      with:
+        ref: ${{ env.BRANCH }}
+        fetch-depth: '0'
+
+    - name: Install dev deps
+      run: make -C python install_dev update_package install
+
+    - name: Lint
+      run: make -C python lint
+
+    - name: Make licenses
+      run: make -C python licenses
+
+    - name: Configure git user
+      run: |
+        git config --global user.name "${GITHUB_USER}"
+        git config --global user.email "${GITHUB_USER}@users.noreply.github.com"
+        git config --global --add safe.directory "$GITHUB_WORKSPACE"
+
+    - name: Commit changes in licensing
+      if: github.event_name == 'push'
       run: |
-        make -C python install_dev lint
+        git add python/ && git commit -m "chore: automatically push the changed licenses files" || echo "Nothing to commit"
+        git push

.github/workflows/python_tests.yml

@@ -2,10 +2,12 @@ name: V1 Python Tests
 
 on:
   push:
-    branches: [ master ]
+    branches:
+      - master
+      - release-1.19.0-prep
   pull_request:
     # TODO revert before merge to master
-    branches: [ release-1.19.0-prep ]
+    branches: [ master, release-1.19.0-prep ]
   workflow_dispatch:
 
 jobs:

.github/workflows/security_code_tests_v1.yml

@@ -2,12 +2,12 @@ name: V1 Security code Tests
 
 on:
   push:
-    branches: [ master ]
-  pull_request:
-    # TODO remove release-1.19.0-prep before merge to master
     branches:
       - master
       - release-1.19.0-prep
+  pull_request:
+    # TODO revert before merge to master
+    branches: [ master, release-1.19.0-prep ]
   workflow_dispatch:
 
 jobs:

.github/workflows/security_tests_go_v1.yml

@@ -2,12 +2,12 @@ name: V1 Security Tests Go Images
 
 on:
   push:
-    branches: [ master ]
-  pull_request:
-    # TODO remove release-1.19.0-prep before merge to master
     branches:
       - master
       - release-1.19.0-prep
+  pull_request:
+    # TODO revert before merge to master
+    branches: [ master, release-1.19.0-prep ]
   workflow_dispatch:
 
 jobs:

.github/workflows/security_tests_python_v1.yml

@@ -2,13 +2,14 @@ name: V1 Security Tests Python Images
 
 on:
   push:
-    branches: [ master ]
-  pull_request:
-    # TODO remove release-1.19.0-prep before merge to master
     branches:
       - master
       - release-1.19.0-prep
+  pull_request:
+    # TODO revert before merge to master
+    branches: [ master, release-1.19.0-prep ]
   workflow_dispatch:
+
 jobs:
   build-upload-scan-base-images:
     runs-on: ubuntu-latest

.github/workflows/test-executor.yml

@@ -1,13 +1,13 @@
----
 name: V1 Executor Lint & Tests
 
 on:
   push:
-    branches: [ master ]
+    branches:
+      - master
+      - release-1.19.0-prep
   pull_request:
     # TODO revert before merge to master
-    branches: [release-1.19.0-prep]
-
+    branches: [ master, release-1.19.0-prep ]
   workflow_dispatch:
 
 env:

.github/workflows/test-operator.yml

@@ -1,13 +1,13 @@
----
 name: V1 Operator Lint & Tests
 
 on:
   push:
-    branches: [master]
+    branches:
+      - master
+      - release-1.19.0-prep
   pull_request:
     # TODO revert before merge to master
-    branches: [release-1.19.0-prep]
-
+    branches: [ master, release-1.19.0-prep ]
   workflow_dispatch:
 
 env: