Skip to content

Commit 96ce155

Browse files
authored
fix(mlserver): turn off logging request logs by default (#7042)
* turn off logging request logs by default * remove accidental generated manifests * revert * copyright
1 parent 03383ad commit 96ce155

File tree

7 files changed

+19
-0
lines changed

7 files changed

+19
-0
lines changed

k8s/helm-charts/seldon-core-v2-setup/templates/_components-statefulsets.tpl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1581,6 +1581,8 @@ spec:
15811581
- env:
15821582
- name: MLSERVER_PARALLEL_WORKERS
15831583
value: '{{ .Values.serverConfig.mlserver.parallel_workers }}'
1584+
- name: MLSERVER_DEBUG
1585+
value: '{{ .Values.serverConfig.mlserver.debug }}'
15841586
- name: MLSERVER_HTTP_PORT
15851587
value: "9000"
15861588
- name: MLSERVER_GRPC_PORT

k8s/helm-charts/seldon-core-v2-setup/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,7 @@ serverConfig:
306306
serverCapabilities: "mlserver,alibi-detect,alibi-explain,huggingface,lightgbm,mlflow,python,sklearn,spark-mlib,xgboost"
307307
modelVolumeStorage: 1Gi
308308
parallel_workers: 1
309+
debug: "false"
309310
resources:
310311
cpu: 100m
311312
memory: 1Gi

k8s/helm-charts/seldon-core-v2-setup/values.yaml.template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,7 @@ serverConfig:
306306
serverCapabilities: "mlserver,alibi-detect,alibi-explain,huggingface,lightgbm,mlflow,python,sklearn,spark-mlib,xgboost"
307307
modelVolumeStorage: 1Gi
308308
parallel_workers: 1
309+
debug: "false"
309310
resources:
310311
cpu: 100m
311312
memory: 1Gi

k8s/kustomize/helm-components-sc/patch_mlserver.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ spec:
9494
env:
9595
- name: MLSERVER_PARALLEL_WORKERS
9696
value: '{{ .Values.serverConfig.mlserver.parallel_workers }}'
97+
- name: MLSERVER_DEBUG
98+
value: '{{ .Values.serverConfig.mlserver.debug }}'
9799
resources:
98100
requests:
99101
cpu: '{{ .Values.serverConfig.mlserver.resources.cpu }}'

k8s/yaml/components.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1391,6 +1391,8 @@ spec:
13911391
- env:
13921392
- name: MLSERVER_PARALLEL_WORKERS
13931393
value: '1'
1394+
- name: MLSERVER_DEBUG
1395+
value: 'false'
13941396
- name: MLSERVER_HTTP_PORT
13951397
value: "9000"
13961398
- name: MLSERVER_GRPC_PORT

operator/config/serverconfigs/mlserver.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,8 @@ spec:
179179
value: "false"
180180
- name: MLSERVER_GRPC_MAX_MESSAGE_LENGTH
181181
value: "1048576000" # 100MB (100 * 1024 * 1024)
182+
- name: MLSERVER_DEBUG
183+
value: "false"
182184
resources:
183185
requests:
184186
cpu: 1

tests/integration/godog/steps/assertions/pipeline_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
/*
2+
Copyright (c) 2024 Seldon Technologies Ltd.
3+
4+
Use of this software is governed BY
5+
(1) the license included in the LICENSE file or
6+
(2) if the license included in the LICENSE file is the Business Source License 1.1,
7+
the Change License after the Change Date as each is defined in accordance with the LICENSE file.
8+
*/
9+
110
package assertions
211

312
import (

0 commit comments

Comments
 (0)