fix(helm): mlserver env var parallel workers (#6974)

domsolutions · web-flow · commit e9e510514530 · 2025-12-09T13:04:43.000Z
* set parallel workers on mlserver to updated env var: MLSERVER_PARALLEL_WORKERS

* copyright
diff --git a/k8s/helm-charts/seldon-core-v2-setup/templates/_components-deployments.tpl b/k8s/helm-charts/seldon-core-v2-setup/templates/_components-deployments.tpl
@@ -1546,14 +1546,14 @@ spec:
       - mountPath: /mnt/tracing
         name: tracing-config-volume
     - env:
+      - name: MLSERVER_PARALLEL_WORKERS
+        value: '{{ .Values.serverConfig.mlserver.parallel_workers }}'
       - name: MLSERVER_HTTP_PORT
         value: "9000"
       - name: MLSERVER_GRPC_PORT
         value: "9500"
       - name: MLSERVER_MODELS_DIR
         value: /mnt/agent/models
-      - name: MLSERVER_MODEL_PARALLEL_WORKERS
-        value: "1"
       - name: MLSERVER_LOAD_MODELS_AT_STARTUP
         value: "false"
       - name: MLSERVER_GRPC_MAX_MESSAGE_LENGTH
diff --git a/k8s/helm-charts/seldon-core-v2-setup/templates/_components-statefulsets.tpl b/k8s/helm-charts/seldon-core-v2-setup/templates/_components-statefulsets.tpl
@@ -1579,14 +1579,14 @@ spec:
       - mountPath: /mnt/tracing
         name: tracing-config-volume
     - env:
+      - name: MLSERVER_PARALLEL_WORKERS
+        value: '{{ .Values.serverConfig.mlserver.parallel_workers }}'
       - name: MLSERVER_HTTP_PORT
         value: "9000"
       - name: MLSERVER_GRPC_PORT
         value: "9500"
       - name: MLSERVER_MODELS_DIR
         value: /mnt/agent/models
-      - name: MLSERVER_MODEL_PARALLEL_WORKERS
-        value: "1"
       - name: MLSERVER_LOAD_MODELS_AT_STARTUP
         value: "false"
       - name: MLSERVER_GRPC_MAX_MESSAGE_LENGTH
diff --git a/k8s/helm-charts/seldon-core-v2-setup/values.yaml b/k8s/helm-charts/seldon-core-v2-setup/values.yaml
@@ -305,6 +305,7 @@ serverConfig:
       tag: 1.7.1
     serverCapabilities: "mlserver,alibi-detect,alibi-explain,huggingface,lightgbm,mlflow,python,sklearn,spark-mlib,xgboost"
     modelVolumeStorage: 1Gi
+    parallel_workers: 1
     resources:
       cpu: 100m
       memory: 1Gi
diff --git a/k8s/helm-charts/seldon-core-v2-setup/values.yaml.template b/k8s/helm-charts/seldon-core-v2-setup/values.yaml.template
@@ -305,6 +305,7 @@ serverConfig:
       tag: 1.7.1
     serverCapabilities: "mlserver,alibi-detect,alibi-explain,huggingface,lightgbm,mlflow,python,sklearn,spark-mlib,xgboost"
     modelVolumeStorage: 1Gi
+    parallel_workers: 1
     resources:
       cpu: 100m
       memory: 1Gi
diff --git a/k8s/kustomize-experimental/helm-components-ns/kustomization.yaml b/k8s/kustomize-experimental/helm-components-ns/kustomization.yaml
@@ -3,7 +3,7 @@ kind: Kustomization
 
 namespace: "{{ .Release.Namespace }}"
 
-bases:
+resources:
 - ../helm-components-sc
 
 
diff --git a/k8s/kustomize-experimental/helm-components-sc/patch_mlserver.yaml b/k8s/kustomize-experimental/helm-components-sc/patch_mlserver.yaml
@@ -91,6 +91,9 @@ spec:
     - image: '{{ .Values.serverConfig.mlserver.image.registry }}/{{ .Values.serverConfig.mlserver.image.repository }}:{{ .Values.serverConfig.mlserver.image.tag }}'
       imagePullPolicy: '{{ .Values.serverConfig.mlserver.image.pullPolicy }}'
       name: mlserver
+      env:
+        - name: MLSERVER_PARALLEL_WORKERS
+          value: '{{ .Values.serverConfig.mlserver.parallel_workers }}'
       resources:
         requests:
           cpu: '{{ .Values.serverConfig.mlserver.resources.cpu }}'
diff --git a/k8s/kustomize/helm-components-ns/kustomization.yaml b/k8s/kustomize/helm-components-ns/kustomization.yaml
@@ -3,8 +3,5 @@ kind: Kustomization
 
 namespace: "{{ .Release.Namespace }}"
 
-bases:
-- ../helm-components-sc
-
-
-
+resources:
+- ../helm-components-sc
diff --git a/k8s/kustomize/helm-components-sc/patch_mlserver.yaml b/k8s/kustomize/helm-components-sc/patch_mlserver.yaml
@@ -91,6 +91,9 @@ spec:
     - image: '{{ .Values.serverConfig.mlserver.image.registry }}/{{ .Values.serverConfig.mlserver.image.repository }}:{{ .Values.serverConfig.mlserver.image.tag }}'
       imagePullPolicy: '{{ .Values.serverConfig.mlserver.image.pullPolicy }}'
       name: mlserver
+      env:
+        - name: MLSERVER_PARALLEL_WORKERS
+          value: '{{ .Values.serverConfig.mlserver.parallel_workers }}'
       resources:
         requests:
           cpu: '{{ .Values.serverConfig.mlserver.resources.cpu }}'
diff --git a/k8s/yaml/components.yaml b/k8s/yaml/components.yaml
@@ -1389,14 +1389,14 @@ spec:
       - mountPath: /mnt/tracing
         name: tracing-config-volume
     - env:
+      - name: MLSERVER_PARALLEL_WORKERS
+        value: '1'
       - name: MLSERVER_HTTP_PORT
         value: "9000"
       - name: MLSERVER_GRPC_PORT
         value: "9500"
       - name: MLSERVER_MODELS_DIR
         value: /mnt/agent/models
-      - name: MLSERVER_MODEL_PARALLEL_WORKERS
-        value: "1"
       - name: MLSERVER_LOAD_MODELS_AT_STARTUP
         value: "false"
       - name: MLSERVER_GRPC_MAX_MESSAGE_LENGTH
diff --git a/operator/config/serverconfigs-experimental/mlserver.yaml b/operator/config/serverconfigs-experimental/mlserver.yaml
@@ -136,7 +136,7 @@ spec:
         value: "9500"
       - name: MLSERVER_MODELS_DIR
         value: "/mnt/agent/models"
-      - name: MLSERVER_MODEL_PARALLEL_WORKERS
+      - name: MLSERVER_PARALLEL_WORKERS
         value: "1"
       - name: MLSERVER_LOAD_MODELS_AT_STARTUP
         value: "false"
diff --git a/operator/config/serverconfigs/mlserver.yaml b/operator/config/serverconfigs/mlserver.yaml
@@ -173,7 +173,7 @@ spec:
         value: "9500"
       - name: MLSERVER_MODELS_DIR
         value: "/mnt/agent/models"
-      - name: MLSERVER_MODEL_PARALLEL_WORKERS
+      - name: MLSERVER_PARALLEL_WORKERS
         value: "1"
       - name: MLSERVER_LOAD_MODELS_AT_STARTUP
         value: "false"
diff --git a/scheduler/k8s/mlserver/mlserver.yaml b/scheduler/k8s/mlserver/mlserver.yaml
@@ -148,7 +148,7 @@ spec:
           value: "9500"
         - name: MLSERVER_MODELS_DIR
           value: "/mnt/agent/models"
-        - name: MLSERVER_MODEL_PARALLEL_WORKERS
+        - name: MLSERVER_PARALLEL_WORKERS
           value: "1"
         - name: MLSERVER_LOAD_MODELS_AT_STARTUP
           value: "false"
diff --git a/tests/integration/godog/k8sclient/client.go b/tests/integration/godog/k8sclient/client.go
@@ -1,3 +1,12 @@
+/*
+Copyright (c) 2024 Seldon Technologies Ltd.
+
+Use of this software is governed BY
+(1) the license included in the LICENSE file or
+(2) if the license included in the LICENSE file is the Business Source License 1.1,
+the Change License after the Change Date as each is defined in accordance with the LICENSE file.
+*/
+
 package k8sclient
 
 import (
diff --git a/tests/integration/godog/k8sclient/watcher.go b/tests/integration/godog/k8sclient/watcher.go
@@ -1,3 +1,12 @@
+/*
+Copyright (c) 2024 Seldon Technologies Ltd.
+
+Use of this software is governed BY
+(1) the license included in the LICENSE file or
+(2) if the license included in the LICENSE file is the Business Source License 1.1,
+the Change License after the Change Date as each is defined in accordance with the LICENSE file.
+*/
+
 package k8sclient
 
 import (
diff --git a/tests/integration/godog/main_test.go b/tests/integration/godog/main_test.go
@@ -1,3 +1,12 @@
+/*
+Copyright (c) 2024 Seldon Technologies Ltd.
+
+Use of this software is governed BY
+(1) the license included in the LICENSE file or
+(2) if the license included in the LICENSE file is the Business Source License 1.1,
+the Change License after the Change Date as each is defined in accordance with the LICENSE file.
+*/
+
 package main
 
 import (
diff --git a/tests/integration/godog/scenario/assertions/model.go b/tests/integration/godog/scenario/assertions/model.go
@@ -1,3 +1,12 @@
+/*
+Copyright (c) 2024 Seldon Technologies Ltd.
+
+Use of this software is governed BY
+(1) the license included in the LICENSE file or
+(2) if the license included in the LICENSE file is the Business Source License 1.1,
+the Change License after the Change Date as each is defined in accordance with the LICENSE file.
+*/
+
 package assertions
 
 import (
diff --git a/tests/integration/godog/scenario/scenario.go b/tests/integration/godog/scenario/scenario.go
@@ -1,3 +1,12 @@
+/*
+Copyright (c) 2024 Seldon Technologies Ltd.
+
+Use of this software is governed BY
+(1) the license included in the LICENSE file or
+(2) if the license included in the LICENSE file is the Business Source License 1.1,
+the Change License after the Change Date as each is defined in accordance with the LICENSE file.
+*/
+
 package scenario
 
 import (
diff --git a/tests/integration/godog/steps/model_steps.go b/tests/integration/godog/steps/model_steps.go
@@ -1,3 +1,12 @@
+/*
+Copyright (c) 2024 Seldon Technologies Ltd.
+
+Use of this software is governed BY
+(1) the license included in the LICENSE file or
+(2) if the license included in the LICENSE file is the Business Source License 1.1,
+the Change License after the Change Date as each is defined in accordance with the LICENSE file.
+*/
+
 package steps
 
 import (
diff --git a/tests/integration/godog/steps/util.go b/tests/integration/godog/steps/util.go
@@ -1,3 +1,12 @@
+/*
+Copyright (c) 2024 Seldon Technologies Ltd.
+
+Use of this software is governed BY
+(1) the license included in the LICENSE file or
+(2) if the license included in the LICENSE file is the Business Source License 1.1,
+the Change License after the Change Date as each is defined in accordance with the LICENSE file.
+*/
+
 package steps
 
 import (
diff --git a/tests/integration/godog/steps/world.go b/tests/integration/godog/steps/world.go
@@ -1,3 +1,12 @@
+/*
+Copyright (c) 2024 Seldon Technologies Ltd.
+
+Use of this software is governed BY
+(1) the license included in the LICENSE file or
+(2) if the license included in the LICENSE file is the Business Source License 1.1,
+the Change License after the Change Date as each is defined in accordance with the LICENSE file.
+*/
+
 package steps
 
 import (
