Bump GeckoDriver to 0.28.0 (#1137)

* Bump GeckoDriver to 0.28.0

* Using new environment files in GitHub actions

Author: diemol

.github/workflows/build-test.yml

@@ -27,18 +27,18 @@ jobs:
           python-version: 3.8
       - name: Get branch name (only for push to branch)
         if: github.event_name == 'push'
-        run: echo "::set-env name=BRANCH::$(echo ${PUSH_BRANCH##*/})"
+        run: echo "BRANCH=$(echo ${PUSH_BRANCH##*/})" >> $GITHUB_ENV
         env:
           PUSH_BRANCH: ${{ github.ref }}
       - name: Get target branch name (only for PRs)
         if: github.event_name == 'pull_request'
-        run: echo "::set-env name=BRANCH::$(echo ${TARGET_BRANCH##*/})"
+        run: echo "BRANCH=$(echo ${TARGET_BRANCH##*/})" >> $GITHUB_ENV
         env:
           TARGET_BRANCH: ${{ github.head_ref }}
       - name: Output branch name
         run: echo ${BRANCH}
       - name: Sets build date
-        run: echo ::set-env name=BUILD_DATE::$(date '+%Y%m%d')
+        run: echo "BUILD_DATE=$(date '+%Y%m%d')" >> $GITHUB_ENV
       - name: Build Docker images
         run: VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make build
       - name: Test Docker images

.github/workflows/deploy.yml

@@ -20,25 +20,25 @@ jobs:
       - name: Output Docker info
         run: docker info
       - name: Sets build date
-        run: echo ::set-env name=BUILD_DATE::$(date '+%Y%m%d')
+        run: echo "BUILD_DATE=$(date '+%Y%m%d')" >> $GITHUB_ENV
       - name: Sets prerelease to false by default
-        run: echo ::set-env name=PRERELEASE::false
+        run: echo "PRERELEASE=false" >> $GITHUB_ENV
       - name: Build base image to get Grid version
         run: VERSION="local" BUILD_DATE=${BUILD_DATE} make base
       - name: Get Grid version
         # sed used to remove last comma of Selenium version output
-        run: echo ::set-env name=GRID_VERSION::$(docker run --rm selenium/base:local-${BUILD_DATE} java -jar /opt/selenium/selenium-server.jar hub --version | awk '{print $3}' | sed 's/\(.*\),/\1 /')
+        run: echo "BUILD_DATE=$(docker run --rm selenium/base:local-${BUILD_DATE} java -jar /opt/selenium/selenium-server.jar hub --version | awk '{print $3}' | sed 's/\(.*\),/\1 /')" >> $GITHUB_ENV
       - name: Is it a prerelease?
-        run: echo ::set-env name=GRID_VERSION::${GRID_VERSION}-prerelease && echo ::set-env name=PRERELEASE::true
+        run: echo "GRID_VERSION=${GRID_VERSION}-prerelease" >> $GITHUB_ENV && echo "PRERELEASE=true" >> $GITHUB_ENV
         if: contains(toJson(github.event.commits), '[prerelease]') == true
       - name: Display Grid version
         run: echo ${GRID_VERSION}
       - name: Remove local Docker tag
         run: docker rmi selenium/base:local-${BUILD_DATE}
       - name: Sets env var for the next tag
-        run: echo ::set-env name=NEXT_TAG::"${GRID_VERSION}"-${BUILD_DATE}
+        run: echo "NEXT_TAG=${GRID_VERSION}-${BUILD_DATE}" >> $GITHUB_ENV
       - name: Get latest tag
-        run: echo ::set-env name=LATEST_TAG::$(git tag | tail -1)
+        run: echo "LATEST_TAG=$(git tag | tail -1)" >> $GITHUB_ENV
       - name: Display latest tag
         run: echo ${LATEST_TAG}
       - name: Update tag in docs and files

.github/workflows/test-video.yml

@@ -27,18 +27,18 @@ jobs:
           python-version: 3.8
       - name: Get branch name (only for push to branch)
         if: github.event_name == 'push'
-        run: echo "::set-env name=BRANCH::$(echo ${PUSH_BRANCH##*/})"
+        run: echo "BRANCH=$(echo ${PUSH_BRANCH##*/})" >> $GITHUB_ENV
         env:
           PUSH_BRANCH: ${{ github.ref }}
       - name: Get target branch name (only for PRs)
         if: github.event_name == 'pull_request'
-        run: echo "::set-env name=BRANCH::$(echo ${TARGET_BRANCH##*/})"
+        run: echo "BRANCH=$(echo ${TARGET_BRANCH##*/})" >> $GITHUB_ENV
         env:
           TARGET_BRANCH: ${{ github.head_ref }}
       - name: Output branch name
         run: echo ${BRANCH}
       - name: Sets build date
-        run: echo ::set-env name=BUILD_DATE::$(date '+%Y%m%d')
+        run: echo "BUILD_DATE=$(date '+%Y%m%d')" >> $GITHUB_ENV
       - name: Run Docker Compose to record video
         run: USE_RANDOM_USER_ID=${USE_RANDOM_USER} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make test_video
         env:

NodeFirefox/Dockerfile.txt

@@ -20,7 +20,7 @@ RUN FIREFOX_DOWNLOAD_URL=$(if [ $FIREFOX_VERSION = "latest" ] || [ $FIREFOX_VERS
 # GeckoDriver
 #============
 ARG GECKODRIVER_VERSION=latest
-RUN GK_VERSION=$(if [ ${GECKODRIVER_VERSION:-latest} = "latest" ]; then echo "0.27.0"; else echo $GECKODRIVER_VERSION; fi) \
+RUN GK_VERSION=$(if [ ${GECKODRIVER_VERSION:-latest} = "latest" ]; then echo "0.28.0"; else echo $GECKODRIVER_VERSION; fi) \
   && echo "Using GeckoDriver version: "$GK_VERSION \
   && wget --no-verbose -O /tmp/geckodriver.tar.gz https://github.com/mozilla/geckodriver/releases/download/v$GK_VERSION/geckodriver-v$GK_VERSION-linux64.tar.gz \
   && rm -rf /opt/geckodriver \