Skip to content

Commit 41fab7a

Browse files
committed
[test]: update test for arm64
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 94da26e commit 41fab7a

File tree

3 files changed

+28
-3
lines changed

3 files changed

+28
-3
lines changed

.circleci/config.yml

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,54 +79,72 @@ workflows:
7979
use-random-user: true
8080
platforms: linux/arm64
8181
machine-type: ubuntu2204arm64
82+
firefox-install-lang-package: false
83+
enable-managed-downloads: false
8284
- docker-test:
8385
name: "Docker test - Use random user (false)"
8486
test-strategy: test
8587
use-random-user: false
8688
platforms: linux/arm64
8789
machine-type: ubuntu2204arm64
90+
firefox-install-lang-package: false
91+
enable-managed-downloads: false
8892
- docker-test:
8993
name: "Docker test - Video recording"
9094
test-strategy: test_video
9195
use-random-user: false
9296
platforms: linux/arm64
9397
machine-type: ubuntu2204arm64
98+
firefox-install-lang-package: true
99+
enable-managed-downloads: true
94100
- docker-test:
95101
name: "Docker test - Video recording dynamic file name"
96102
test-strategy: test_video_dynamic_name
97103
use-random-user: false
98104
platforms: linux/arm64
99105
machine-type: ubuntu2204arm64
106+
firefox-install-lang-package: true
107+
enable-managed-downloads: true
100108
- docker-test:
101109
name: "Docker test - Video recording standalone"
102110
test-strategy: test_video_standalone
103111
use-random-user: false
104112
platforms: linux/arm64
105113
machine-type: ubuntu2204arm64
114+
firefox-install-lang-package: true
115+
enable-managed-downloads: true
106116
- docker-test:
107117
name: "Docker test - Dynamic Grid"
108118
test-strategy: test_node_docker
109119
use-random-user: false
110120
platforms: linux/arm64
111121
machine-type: ubuntu2204arm64
122+
firefox-install-lang-package: true
123+
enable-managed-downloads: true
112124
- docker-test:
113125
name: "Docker test - Dynamic Grid Standalone"
114126
test-strategy: test_standalone_docker
115127
use-random-user: false
116128
platforms: linux/arm64
117129
machine-type: ubuntu2204arm64
130+
firefox-install-lang-package: true
131+
enable-managed-downloads: true
118132
- docker-test:
119133
name: "Docker test - Parallel execution"
120134
test-strategy: test_parallel
121135
use-random-user: false
122136
platforms: linux/arm64
123137
machine-type: ubuntu2204arm64
138+
firefox-install-lang-package: true
139+
enable-managed-downloads: true
124140
- docker-test:
125141
name: "Docker test - Node relay commands"
126142
test-strategy: test_node_relay
127143
use-random-user: false
128144
platforms: linux/arm64
129145
machine-type: ubuntu2204arm64
146+
firefox-install-lang-package: true
147+
enable-managed-downloads: true
130148

131149
executors:
132150
ubuntu2204arm64:
@@ -149,13 +167,19 @@ jobs:
149167
type: string
150168
use-random-user:
151169
type: boolean
170+
firefox-install-lang-package:
171+
type: boolean
172+
enable-managed-downloads:
173+
type: boolean
152174
executor: << parameters.machine-type >>
153175
environment:
154176
NAMESPACE: selenium
155177
BUILD_DATE: today
156178
PLATFORMS: << parameters.platforms >>
157179
TEST_STRATEGY: << parameters.test-strategy >>
158180
USE_RANDOM_USER: << parameters.use-random-user >>
181+
TEST_FIREFOX_INSTALL_LANG_PACKAGE: << parameters.firefox-install-lang-package >>
182+
SELENIUM_ENABLE_MANAGED_DOWNLOADS: << parameters.enable-managed-downloads >>
159183
steps:
160184
- run:
161185
name: "Prepare workflow environment variables"
@@ -195,7 +219,9 @@ jobs:
195219
command: |
196220
N=3
197221
while [ $N -gt 0 ]; do
198-
output=$(eval "USE_RANDOM_USER_ID=${USE_RANDOM_USER} PLATFORMS=${PLATFORMS} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make ${TEST_STRATEGY}")
222+
output=$(eval "USE_RANDOM_USER_ID=${USE_RANDOM_USER} PLATFORMS=${PLATFORMS} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} \
223+
TEST_FIREFOX_INSTALL_LANG_PACKAGE=${TEST_FIREFOX_INSTALL_LANG_PACKAGE} SELENIUM_ENABLE_MANAGED_DOWNLOADS=${SELENIUM_ENABLE_MANAGED_DOWNLOADS} \
224+
make ${TEST_STRATEGY}")
199225
status=$?
200226
if [ $status -eq 0 ]; then
201227
echo "Tests passed"

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@ test_firefox_download_lang_packs:
629629

630630
test_firefox: test_firefox_download_lang_packs
631631
PLATFORMS=$(PLATFORMS) VERSION=$(TAG_VERSION) NAMESPACE=$(NAMESPACE) BASE_RELEASE=$(BASE_RELEASE) BASE_VERSION=$(BASE_VERSION) BINDING_VERSION=$(BINDING_VERSION) SKIP_BUILD=true \
632-
TEST_FIREFOX_INSTALL_LANG_PACKAGE=true ./tests/bootstrap.sh NodeFirefox
632+
TEST_FIREFOX_INSTALL_LANG_PACKAGE=$(or $(TEST_FIREFOX_INSTALL_LANG_PACKAGE), "true") ./tests/bootstrap.sh NodeFirefox
633633

634634
test_firefox_standalone:
635635
PLATFORMS=$(PLATFORMS) VERSION=$(TAG_VERSION) NAMESPACE=$(NAMESPACE) BASE_RELEASE=$(BASE_RELEASE) BASE_VERSION=$(BASE_VERSION) BINDING_VERSION=$(BINDING_VERSION) SKIP_BUILD=true ./tests/bootstrap.sh StandaloneFirefox

tests/SeleniumTests/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ def test_download_file(self):
9999
driver = self.driver
100100
driver.get('https://the-internet.herokuapp.com/download')
101101
file_name = 'some-file.txt'
102-
is_continue = True
103102
wait = WebDriverWait(driver, 30)
104103
file_link = wait.until(
105104
EC.element_to_be_clickable((By.LINK_TEXT, file_name))

0 commit comments

Comments
 (0)