Skip to content

Commit 547f97e

Browse files
authored
feat(chart): add support for revisionhistorylimit (#2339)
* add support for revisionhistorylimit Signed-off-by: drfaust92 <[email protected]> * add support for revisionhistorylimit Signed-off-by: drfaust92 <[email protected]> --------- Signed-off-by: drfaust92 <[email protected]>
1 parent 3433334 commit 547f97e

10 files changed

+23
-14
lines changed

charts/selenium-grid/templates/chrome-node-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ spec:
1818
{{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
1919
replicas: {{ .Values.chromeNode.replicas }}
2020
{{end}}
21+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
2122
selector:
2223
matchLabels:
2324
app: {{ template "seleniumGrid.chromeNode.fullname" . }}

charts/selenium-grid/templates/distributor-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.distributor.fullname" . }}

charts/selenium-grid/templates/edge-node-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ spec:
1818
{{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
1919
replicas: {{ .Values.edgeNode.replicas }}
2020
{{end}}
21+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
2122
selector:
2223
matchLabels:
2324
app: {{ template "seleniumGrid.edgeNode.fullname" . }}

charts/selenium-grid/templates/event-bus-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.eventBus.fullname" . }}

charts/selenium-grid/templates/firefox-node-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ spec:
1818
{{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
1919
replicas: {{ .Values.firefoxNode.replicas }}
2020
{{end}}
21+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
2122
selector:
2223
matchLabels:
2324
app: {{ template "seleniumGrid.firefoxNode.fullname" . }}

charts/selenium-grid/templates/hub-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ metadata:
1616
{{- end }}
1717
spec:
1818
replicas: 1
19+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
1920
selector:
2021
matchLabels:
2122
app: {{ template "seleniumGrid.hub.fullname" . }}

charts/selenium-grid/templates/router-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.router.fullname" . }}

charts/selenium-grid/templates/session-map-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.sessionMap.fullname" . }}

charts/selenium-grid/templates/session-queue-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.sessionQueue.fullname" . }}

charts/selenium-grid/values.yaml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ global:
2727
defaultComponentLivenessProbe: exec
2828
# probe logs output can be retrieved using `kubectl logs`
2929
stdoutProbeLog: false
30+
# specify how many old ReplicaSets for this Deployment you want to retain. The rest will be garbage-collected in the background.
31+
revisionHistoryLimit: 10
3032

3133
tls:
3234
# Name of external secret containing the TLS certificate and key
@@ -273,7 +275,6 @@ secrets:
273275

274276
# Configuration for isolated components (applied only if `isolateComponents: true`)
275277
components:
276-
277278
# Configuration for router component
278279
router:
279280
# imageRegistry: selenium
@@ -626,15 +627,15 @@ tracing:
626627
enabled: false
627628
enabledWithExistingEndpoint: false
628629
exporter: otlp
629-
exporterEndpoint: 'http://{{ .Release.Name }}-jaeger-collector.{{ .Release.Namespace }}:4317'
630+
exporterEndpoint: "http://{{ .Release.Name }}-jaeger-collector.{{ .Release.Namespace }}:4317"
630631
globalAutoConfigure: true
631632
ingress:
632633
enabled: true
633634
annotations:
634635
paths:
635636
- backend:
636637
service:
637-
name: '{{ .Release.Name }}-jaeger-query'
638+
name: "{{ .Release.Name }}-jaeger-query"
638639
port:
639640
number: 16686
640641
path: &jaegerBasePath "/jaeger"
@@ -842,9 +843,9 @@ chromeNode:
842843
# scaledObjectOptions:
843844
hpa:
844845
url: '{{ template "seleniumGrid.graphqlURL" . }}'
845-
browserName: 'chrome'
846-
sessionBrowserName: 'chrome'
847-
platformName: 'linux'
846+
browserName: "chrome"
847+
sessionBrowserName: "chrome"
848+
platformName: "linux"
848849
# browserVersion: '91.0' # Optional. Only required when supporting multiple versions of browser in your Selenium Grid.
849850
unsafeSsl: '{{ template "seleniumGrid.graphqlURL.unsafeSsl" . }}' # Optional
850851

@@ -857,7 +858,6 @@ chromeNode:
857858
# It should be set using the --set-json option
858859
sidecars: []
859860

860-
861861
# Configuration for firefox nodes
862862
firefoxNode:
863863
# Enable firefox nodes
@@ -1003,9 +1003,9 @@ firefoxNode:
10031003
# scaledObjectOptions:
10041004
hpa:
10051005
url: '{{ template "seleniumGrid.graphqlURL" . }}'
1006-
browserName: 'firefox'
1007-
sessionBrowserName: 'firefox'
1008-
platformName: 'linux'
1006+
browserName: "firefox"
1007+
sessionBrowserName: "firefox"
1008+
platformName: "linux"
10091009
unsafeSsl: '{{ template "seleniumGrid.graphqlURL.unsafeSsl" . }}' # Optional
10101010

10111011
# It is used to add initContainers in the same pod of the browser node.
@@ -1162,9 +1162,9 @@ edgeNode:
11621162
# scaledObjectOptions:
11631163
hpa:
11641164
url: '{{ template "seleniumGrid.graphqlURL" . }}'
1165-
browserName: 'MicrosoftEdge'
1166-
sessionBrowserName: 'msedge'
1167-
platformName: 'linux'
1165+
browserName: "MicrosoftEdge"
1166+
sessionBrowserName: "msedge"
1167+
platformName: "linux"
11681168
unsafeSsl: '{{ template "seleniumGrid.graphqlURL.unsafeSsl" . }}' # Optional
11691169

11701170
# It is used to add initContainers in the same pod of the browser node.
@@ -1218,7 +1218,7 @@ videoRecorder:
12181218
# RCLONE_CONFIG_GS_ENDPOINT: "https://storage.googleapis.com"
12191219
# RCLONE_CONFIG_GS_NO_CHECK_BUCKET: "true"
12201220
ports:
1221-
- 9000
1221+
- 9000
12221222
resources:
12231223
requests:
12241224
memory: "1Gi"

0 commit comments

Comments
 (0)