Skip to content

Commit 5d143a8

Browse files
den-isden-is
authored
Add ability to mount extra volumes into nodes pods (#1585)
* Add ability to mount extra volumes into nodes pods * release 0.5.0
1 parent b0c8118 commit 5d143a8

File tree

7 files changed

+63
-2
lines changed

7 files changed

+63
-2
lines changed

‎charts/selenium-grid/CHANGELOG.md‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
All notable changes to this helm chart will be documented in this file.
44

5+
## :heavy_check_mark: 0.5.0
6+
7+
### Added
8+
- Added ability to mount arbitrary volumes into browser nodes
9+
510
## :heavy_check_mark: 0.4.2
611

712
### Changed
@@ -12,7 +17,6 @@ All notable changes to this helm chart will be documented in this file.
1217
### Changed
1318
- Update image tag to 4.2.1-20220608
1419

15-
1620
## :heavy_check_mark: 0.4.0
1721

1822
### Added

‎charts/selenium-grid/Chart.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ apiVersion: v2
22
name: selenium-grid
33
description: A Helm chart for creating a Selenium Grid Server in Kubernetes
44
type: application
5-
version: 0.4.2
5+
version: 0.5.0
66
appVersion: 4.2.2-20220609

‎charts/selenium-grid/README.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ This table contains the configuration parameters of the chart and their default
8585
| `chromeNode.service.type` | `ClusterIP` | Service type |
8686
| `chromeNode.service.annotations` | `{}` | Custom annotations for service |
8787
| `chromeNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
88+
| `chromeNode.extraVolumeMounts` | `[]` | Extra mounts of declared ExtraVolumes into pod |
89+
| `chromeNode.extraVolumes` | `[]` | Extra Volumes declarations to be used in the pod (can be any supported volume type: ConfigMap, Secret, PVC, NFS, etc.) |
8890
| `firefoxNode.enabled` | `true` | Enable firefox nodes |
8991
| `firefoxNode.replicas` | `1` | Number of firefox nodes |
9092
| `firefoxNode.imageName` | `selenium/node-firefox` | Image of firefox nodes |
@@ -104,6 +106,8 @@ This table contains the configuration parameters of the chart and their default
104106
| `firefoxNode.service.type` | `ClusterIP` | Service type |
105107
| `firefoxNode.service.annotations` | `{}` | Custom annotations for service |
106108
| `firefoxNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
109+
| `firefoxNode.extraVolumeMounts` | `[]` | Extra mounts of declared ExtraVolumes into pod |
110+
| `firefoxNode.extraVolumes` | `[]` | Extra Volumes declarations to be used in the pod (can be any supported volume type: ConfigMap, Secret, PVC, NFS, etc.) |
107111
| `edgeNode.enabled` | `true` | Enable edge nodes |
108112
| `edgeNode.replicas` | `1` | Number of edge nodes |
109113
| `edgeNode.imageName` | `selenium/node-edge` | Image of edge nodes |
@@ -123,6 +127,8 @@ This table contains the configuration parameters of the chart and their default
123127
| `edgeNode.service.type` | `ClusterIP` | Service type |
124128
| `edgeNode.service.annotations` | `{}` | Custom annotations for service |
125129
| `edgeNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
130+
| `edgeNode.extraVolumeMounts` | `[]` | Extra mounts of declared ExtraVolumes into pod |
131+
| `edgeNode.extraVolumes` | `[]` | Extra Volumes declarations to be used in the pod (can be any supported volume type: ConfigMap, Secret, PVC, NFS, etc.) |
126132
| `customLabels` | `{}` | Custom labels for k8s resources |
127133

128134

‎charts/selenium-grid/templates/chrome-node-deployment.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ spec:
5252
volumeMounts:
5353
- name: dshm
5454
mountPath: /dev/shm
55+
{{- if .Values.chromeNode.extraVolumeMounts }}
56+
{{- toYaml .Values.chromeNode.extraVolumeMounts | nindent 12 }}
57+
{{- end }}
5558
{{- with .Values.chromeNode.resources }}
5659
resources: {{- toYaml . | nindent 12 }}
5760
{{- end }}
@@ -67,4 +70,7 @@ spec:
6770
emptyDir:
6871
medium: Memory
6972
sizeLimit: {{ default "1Gi" .Values.chromeNode.dshmVolumeSizeLimit }}
73+
{{- if .Values.chromeNode.extraVolumes }}
74+
{{ toYaml .Values.chromeNode.extraVolumes | nindent 8 }}
75+
{{- end }}
7076
{{- end }}

‎charts/selenium-grid/templates/edge-node-deployment.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ spec:
5252
volumeMounts:
5353
- name: dshm
5454
mountPath: /dev/shm
55+
{{- if .Values.edgeNode.extraVolumeMounts }}
56+
{{- toYaml .Values.edgeNode.extraVolumeMounts | nindent 12 }}
57+
{{- end }}
5558
{{- with .Values.edgeNode.resources }}
5659
resources: {{- toYaml . | nindent 12 }}
5760
{{- end }}
@@ -67,4 +70,7 @@ spec:
6770
emptyDir:
6871
medium: Memory
6972
sizeLimit: {{ default "1Gi" .Values.edgeNode.dshmVolumeSizeLimit }}
73+
{{- if .Values.edgeNode.extraVolumes }}
74+
{{ toYaml .Values.edgeNode.extraVolumes | nindent 8 }}
75+
{{- end }}
7076
{{- end }}

‎charts/selenium-grid/templates/firefox-node-deployment.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ spec:
5252
volumeMounts:
5353
- name: dshm
5454
mountPath: /dev/shm
55+
{{- if .Values.firefoxNode.extraVolumeMounts }}
56+
{{- toYaml .Values.firefoxNode.extraVolumeMounts | nindent 12 }}
57+
{{- end }}
5558
{{- with .Values.firefoxNode.resources }}
5659
resources: {{- toYaml . | nindent 12 }}
5760
{{- end }}
@@ -67,4 +70,7 @@ spec:
6770
emptyDir:
6871
medium: Memory
6972
sizeLimit: {{ default "1Gi" .Values.firefoxNode.dshmVolumeSizeLimit }}
73+
{{- if .Values.firefoxNode.extraVolumes }}
74+
{{ toYaml .Values.firefoxNode.extraVolumes | nindent 8 }}
75+
{{- end }}
7076
{{- end }}

‎charts/selenium-grid/values.yaml‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,17 @@ chromeNode:
311311
# Size limit for DSH volume mounted in container (if not set, default is "1Gi")
312312
dshmVolumeSizeLimit: 1Gi
313313

314+
extraVolumeMounts: []
315+
# - name: my-extra-volume
316+
# mountPath: /home/seluser/Downloads
317+
318+
extraVolumes: []
319+
# - name: my-extra-volume
320+
# emptyDir: {}
321+
# - name: my-extra-volume-from-pvc
322+
# persistentVolumeClaim:
323+
# claimName: my-pv-claim
324+
314325
# Configuration for firefox nodes
315326
firefoxNode:
316327
# Enable firefox nodes
@@ -372,6 +383,17 @@ firefoxNode:
372383
# Size limit for DSH volume mounted in container (if not set, default is "1Gi")
373384
dshmVolumeSizeLimit: 1Gi
374385

386+
extraVolumeMounts: []
387+
# - name: my-extra-volume
388+
# mountPath: /home/seluser/Downloads
389+
390+
extraVolumes: []
391+
# - name: my-extra-volume
392+
# emptyDir: {}
393+
# - name: my-extra-volume-from-pvc
394+
# persistentVolumeClaim:
395+
# claimName: my-pv-claim
396+
375397
# Configuration for edge nodes
376398
edgeNode:
377399
# Enable edge nodes
@@ -433,5 +455,16 @@ edgeNode:
433455
# Size limit for DSH volume mounted in container (if not set, default is "1Gi")
434456
dshmVolumeSizeLimit: 1Gi
435457

458+
extraVolumeMounts: []
459+
# - name: my-extra-volume
460+
# mountPath: /home/seluser/Downloads
461+
462+
extraVolumes: []
463+
# - name: my-extra-volume
464+
# emptyDir: {}
465+
# - name: my-extra-volume-from-pvc
466+
# persistentVolumeClaim:
467+
# claimName: my-pv-claim
468+
436469
# Custom labels for k8s resources
437470
customLabels: {}

0 commit comments

Comments
 (0)