Merge pull request #578 from salemove/fix_chrome_beta_support

Fix Chrome beta support for NodeChrome

Author: diemol

NodeChrome/Dockerfile.txt

@@ -19,6 +19,12 @@ RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key
   && rm /etc/apt/sources.list.d/google-chrome.list \
   && rm -rf /var/lib/apt/lists/* /var/cache/apt/*
 
+#=================================
+# Chrome Launch Script Wrapper
+#=================================
+COPY wrap_chrome_binary /opt/bin/wrap_chrome_binary
+RUN /opt/bin/wrap_chrome_binary
+
 USER seluser
 
 #============================================
@@ -40,10 +46,5 @@ RUN CD_VERSION=$(if [ ${CHROME_DRIVER_VERSION:-latest} = "latest" ]; then echo $
 
 COPY generate_config /opt/bin/generate_config
 
-#=================================
-# Chrome Launch Script Modification
-#=================================
-COPY chrome_launcher.sh /opt/google/chrome/google-chrome
-
 # Generating a default config during build time
 RUN /opt/bin/generate_config > /opt/selenium/config.json

NodeChrome/chrome_launcher.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-CHROME_VERSION=$(/opt/google/chrome/chrome -version | awk '{ print $3 }')
+CHROME_VERSION=$(/usr/bin/google-chrome -version | awk '{ print $3 }')
 
 cat <<_EOF
 {

NodeChrome/generate_config

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+WRAPPER_PATH=$(readlink -f /usr/bin/google-chrome)
+BASE_PATH="$WRAPPER_PATH-base"
+mv "$WRAPPER_PATH" "$BASE_PATH"
+
+cat > "$WRAPPER_PATH" <<_EOF
+#!/bin/bash
+
+# Note: exec -a below is a bashism.
+exec -a "\$0" "$BASE_PATH" --no-sandbox "\$@"
+_EOF
+chmod +x "$WRAPPER_PATH"