Skip to content

Commit 81e0712

Browse files
authored
Improving tags for docker images (#1086)
* Generating build date automatically * Script to tag browser images verbosely and with short version tags * Adapting GitHub action to build on tags and push them
1 parent 5f0c4e6 commit 81e0712

File tree

4 files changed

+285
-110
lines changed

4 files changed

+285
-110
lines changed

.github/workflows/build-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010

1111
jobs:
1212
build-and-test:
13-
# Skip job based on the commit message
13+
# Skip job based on the commit message, only works in push to branches for now
1414
if: contains(toJson(github.event.commits), '[skip ci]') == false
1515
name: Build & test Docker images with random user
1616
runs-on: ubuntu-18.04

.github/workflows/deploy.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ on:
77

88
jobs:
99
deploy:
10-
# Skip job based on the commit message
11-
if: contains(toJson(github.event.commits), '[skip ci]') == false
1210
name: Deploy Docker images
1311
runs-on: ubuntu-18.04
1412
steps:
@@ -26,8 +24,12 @@ jobs:
2624
env:
2725
DOCKER_USERNAME: ${{secrets.DOCKER_USERNAME}}
2826
DOCKER_PASSWORD: ${{secrets.DOCKER_PASSWORD}}
29-
- name: Deploy new images
30-
run: VERSION="${TAG}" make release
27+
# - name: Deploy new images
28+
# run: VERSION="${TAG}" make release
29+
- name: Tag browser images
30+
run: VERSION="${TAG}" make tag_and_push_browser_images
31+
- name: List Docker images
32+
run: docker images
3133
# - name: Deploy tag latest
3234
# run: VERSION="${TRAVIS_TAG}" make tag_latest
3335
# - name: Deploy release latest

0 commit comments

Comments
 (0)