Skip to content

Commit a74cab4

Browse files
committed
test: update to enable/disable managed downloads
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 4c0d9d9 commit a74cab4

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

tests/charts/ci/DeploymentAutoscaling-values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ chromeNode:
3939
- name: SE_BROWSER_ARGS_DISABLE_SEARCH_ENGINE
4040
value: "--disable-search-engine-choice-screen"
4141
- name: SE_NODE_ENABLE_MANAGED_DOWNLOADS
42-
value: "true"
42+
value: "${SELENIUM_ENABLE_MANAGED_DOWNLOADS}"
4343
- name: SE_VNC_NO_PASSWORD
4444
value: "true"
4545
- name: SE_SCREEN_WIDTH

tests/charts/ci/JobAutoscaling-values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ chromeNode:
1414
nameOverride: my-chrome-name
1515
extraEnvironmentVariables: &extraEnvironmentVariables
1616
- name: SE_NODE_ENABLE_MANAGED_DOWNLOADS
17-
value: "true"
17+
value: "${SELENIUM_ENABLE_MANAGED_DOWNLOADS}"
1818
- name: SE_VNC_NO_PASSWORD
1919
value: "true"
2020
- name: SE_SCREEN_WIDTH

tests/charts/ci/NoAutoscaling-values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ chromeNode:
55
nameOverride: my-chrome-name
66
extraEnvironmentVariables: &extraEnvironmentVariables
77
- name: SE_NODE_ENABLE_MANAGED_DOWNLOADS
8-
value: "true"
8+
value: "${SELENIUM_ENABLE_MANAGED_DOWNLOADS}"
99
- name: SE_VNC_NO_PASSWORD
1010
value: "true"
1111
- name: SE_SCREEN_WIDTH

tests/charts/make/chart_test.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ else
4646
SELENIUM_TLS_SECRET_NAME="${RELEASE_NAME}-selenium-tls-secret"
4747
fi
4848
EXTERNAL_TLS_SECRET_NAME=${EXTERNAL_TLS_SECRET_NAME:-"external-tls-secret"}
49+
SELENIUM_ENABLE_MANAGED_DOWNLOADS=${SELENIUM_ENABLE_MANAGED_DOWNLOADS:-"true"}
4950

5051
cleanup() {
5152
# Get the list of pods
@@ -93,9 +94,13 @@ export RELEASE_NAME=${RELEASE_NAME}
9394
export SELENIUM_NAMESPACE=${SELENIUM_NAMESPACE}
9495
export TEST_PV_CLAIM_NAME=${TEST_PV_CLAIM_NAME}
9596
export HOST_PATH=$(realpath ./tests/videos)
97+
export SELENIUM_ENABLE_MANAGED_DOWNLOADS=${SELENIUM_ENABLE_MANAGED_DOWNLOADS}
9698
RECORDER_VALUES_FILE=${TEST_VALUES_PATH}/base-recorder-values.yaml
99+
MATRIX_BROWSER_VALUES_FILE=${TEST_VALUES_PATH}/${MATRIX_BROWSER}-values.yaml
97100
envsubst < ${RECORDER_VALUES_FILE} > ./tests/tests/base-recorder-values.yaml
101+
envsubst < ${MATRIX_BROWSER_VALUES_FILE} > ./tests/tests/${MATRIX_BROWSER}-values.yaml
98102
RECORDER_VALUES_FILE=./tests/tests/base-recorder-values.yaml
103+
MATRIX_BROWSER_VALUES_FILE=./tests/tests/${MATRIX_BROWSER}-values.yaml
99104

100105
if [ "${TEST_UPGRADE_CHART}" != "true" ] && [ "${RENDER_HELM_TEMPLATE_ONLY}" != "true" ]; then
101106
LOCAL_PVC_YAML="${TEST_VALUES_PATH}/local-pvc.yaml"
@@ -305,7 +310,7 @@ if [ "${SELENIUM_GRID_PROTOCOL}" = "https" ]; then
305310
fi
306311

307312
HELM_COMMAND_SET_BASE_VALUES="${HELM_COMMAND_SET_BASE_VALUES} \
308-
--values ${TEST_VALUES_PATH}/${MATRIX_BROWSER}-values.yaml \
313+
--values ${MATRIX_BROWSER_VALUES_FILE} \
309314
"
310315

311316
HELM_COMMAND_ARGS="${RELEASE_NAME} \

0 commit comments

Comments
 (0)