Skip to content

Commit e976dd7

Browse files
committed
chart: Deployment scale metricType should be Value instead of AverageValue
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent bf73ae9 commit e976dd7

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

NodeChromium/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ USER root
99
# Install Chromium
1010
ARG CHROMIUM_VERSION="latest"
1111
ARG CHROMIUM_DEB_SITE="http://deb.debian.org/debian"
12-
RUN echo "deb ${CHROMIUM_DEB_SITE}/ sid main" >> /etc/apt/sources.list \
12+
RUN echo "deb ${CHROMIUM_DEB_SITE}/ stable main" >> /etc/apt/sources.list \
1313
&& wget -qO- https://ftp-master.debian.org/keys/archive-key-12.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/debian-archive-keyring.gpg \
1414
&& wget -qO- https://ftp-master.debian.org/keys/archive-key-12-security.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/debian-archive-security-keyring.gpg \
1515
&& apt-get update -qqy \

charts/selenium-grid/CONFIGURATION.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
344344
| autoscaling.scaledJobOptions.failedJobsHistoryLimit | int | `0` | Number of Failed jobs should be kept (for troubleshooting purposes) |
345345
| autoscaling.scaledJobOptions.jobTargetRef | object | `{"backoffLimit":0,"completions":1,"parallelism":1}` | Specify job target ref for KEDA ScaledJob |
346346
| autoscaling.scaledObjectOptions.scaleTargetRef.kind | string | `"Deployment"` | Target reference for KEDA ScaledObject |
347+
| autoscaling.scaledObjectOptions.advanced.scalingModifiers.metricType | string | `"Value"` | |
347348
| autoscaling.terminationGracePeriodSeconds | int | `3600` | Define terminationGracePeriodSeconds for scalingType "deployment". Period for `deregisterLifecycle` to gracefully shut down the node before force terminating it |
348349
| autoscaling.deregisterLifecycle | string | `nil` | Define preStop command to shut down the node gracefully when scalingType is set to "deployment" |
349350
| chromeNode.enabled | bool | `true` | Enable chrome nodes |

charts/selenium-grid/templates/_helpers.tpl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,7 @@ Common autoscaling spec template
239239
{{- if not $.Values.autoscaling.scaledOptions.triggers }}
240240
triggers:
241241
- type: selenium-grid
242+
name: selenium-grid
242243
metadata:
243244
nodeMaxSessions: {{ $nodeMaxSessions | quote }}
244245
{{- with .node.hpa }}

charts/selenium-grid/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -894,6 +894,10 @@ autoscaling:
894894
scaleTargetRef:
895895
# -- Target reference for KEDA ScaledObject
896896
kind: Deployment
897+
advanced:
898+
scalingModifiers:
899+
metricType: "Value"
900+
formula: "selenium-grid"
897901
# -- Define terminationGracePeriodSeconds for scalingType "deployment". Period for `deregisterLifecycle` to gracefully shut down the node before force terminating it
898902
terminationGracePeriodSeconds: 3600
899903
# -- Define preStop command to shut down the node gracefully when scalingType is set to "deployment"

0 commit comments

Comments
 (0)