Skip to content

Commit ed2b538

Browse files
committed
update: noVNC and websockify checkout latest source in NodeBase
Take latest version for possible fixes could have #2154 Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 71266a4 commit ed2b538

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

NodeBase/Dockerfile

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,14 @@ ARG AUTHORS
44
FROM ${NAMESPACE}/base:${VERSION}
55
LABEL authors=${AUTHORS}
66

7-
ARG NOVNC_VERSION="1.4.0"
8-
ARG WEBSOCKIFY_VERSION="0.11.0"
7+
# Inputs: heads, tags
8+
ARG NOVNC_SOURCE="heads"
9+
# Inputs: master, "v1.4.0"
10+
ARG NOVNC_VERSION="master"
11+
# Inputs: heads, tags
12+
ARG WEBSOCKIFY_SOURCE="heads"
13+
# Inputs: master, "v0.11.0"
14+
ARG WEBSOCKIFY_VERSION="master"
915

1016
USER root
1117

@@ -97,13 +103,13 @@ RUN apt-get -qqy update \
97103
# noVNC exposes VNC through a web page #
98104
########################################
99105
RUN wget -nv -O noVNC.zip \
100-
"https://github.com/novnc/noVNC/archive/refs/tags/v${NOVNC_VERSION}.zip" \
106+
"https://github.com/novnc/noVNC/archive/refs/${NOVNC_SOURCE}/${NOVNC_VERSION}.zip" \
101107
&& unzip -x noVNC.zip \
102108
&& mv noVNC-${NOVNC_VERSION} /opt/bin/noVNC \
103109
&& cp /opt/bin/noVNC/vnc.html /opt/bin/noVNC/index.html \
104110
&& rm noVNC.zip \
105111
&& wget -nv -O websockify.zip \
106-
"https://github.com/novnc/websockify/archive/refs/tags/v${WEBSOCKIFY_VERSION}.zip" \
112+
"https://github.com/novnc/websockify/archive/refs/${WEBSOCKIFY_SOURCE}/${WEBSOCKIFY_VERSION}.zip" \
107113
&& unzip -x websockify.zip \
108114
&& rm websockify.zip \
109115
&& mv websockify-${WEBSOCKIFY_VERSION} /opt/bin/noVNC/utils/websockify \

0 commit comments

Comments
 (0)