-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Multiple nodes browser in Helm configs #2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This pull request includes several changes to the Selenium Grid Helm chart to enhance its configuration and scalability. The key changes involve renaming deployment names for consistency, adding support for cross-browser nodes, and updating templates to accommodate these new configurations.
Example Usage
Cross-Browser Support:
charts/selenium-grid/CONFIGURATION.md: [1]charts/selenium-grid/cross-browsers-values.yaml: [2]Template Updates:
charts/selenium-grid/templates/chrome-node-deployment.yaml: [1]charts/selenium-grid/templates/chrome-node-hpa.yaml: [2]charts/selenium-grid/templates/chrome-node-scaledjobs.yaml: [3]charts/selenium-grid/templates/chrome-node-service.yaml: [4]charts/selenium-grid/templates/edge-node-deployment.yaml: [5]Name Helper Template:
charts/selenium-grid/templates/_nameHelpers.tpl: charts/selenium-grid/templates/_nameHelpers.tplL126-R155)Motivation and Context
Types of changes
Checklist
PR Type
enhancement, tests
Description
values.yamlandcross-browsers-values.yaml.CONFIGURATION.md.Changes walkthrough 📝
2 files
bootstrap.sh
Add cross-browser values to Helm template commandstests/charts/bootstrap.sh
test.py
Update resource names in test casestests/charts/templates/test.py
9 files
_nameHelpers.tpl
Rename node templates and add relay node supportcharts/selenium-grid/templates/_nameHelpers.tpl
chrome-node-deployment.yaml
Support multiple Chrome node configurationscharts/selenium-grid/templates/chrome-node-deployment.yaml
chrome-node-hpa.yaml
Add HPA configuration for multiple Chrome nodescharts/selenium-grid/templates/chrome-node-hpa.yaml
chrome-node-scaledjobs.yaml
Add scaled job configuration for Chrome nodescharts/selenium-grid/templates/chrome-node-scaledjobs.yaml
chrome-node-service.yaml
Add service configuration for Chrome nodescharts/selenium-grid/templates/chrome-node-service.yaml
edge-node-deployment.yaml
Support multiple Edge node configurationscharts/selenium-grid/templates/edge-node-deployment.yaml
edge-node-hpa.yaml
Add HPA configuration for multiple Edge nodescharts/selenium-grid/templates/edge-node-hpa.yaml
edge-node-scaledjob.yaml
Add scaled job configuration for Edge nodescharts/selenium-grid/templates/edge-node-scaledjob.yaml
edge-node-service.yaml
Add service configuration for Edge nodescharts/selenium-grid/templates/edge-node-service.yaml
3 files
selenium-grid-scaler.md
Update deployment names in KEDA scaler configuration.keda/scalers/selenium-grid-scaler.md
cross-browsers-values.yaml
Add configurations for additional browser nodescharts/selenium-grid/cross-browsers-values.yaml
values.yaml
Add cross-browser configurations to values.yamlcharts/selenium-grid/values.yaml
Relay nodes.
1 files
CONFIGURATION.md
Document cross-browser node configurationscharts/selenium-grid/CONFIGURATION.md