Skip to content

feat: Deploy Node/Standalone Edge browser version from v114 to v131 #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2025
Merged

feat: Deploy Node/Standalone Edge browser version from v114 to v131 #2628

merged 2 commits into from
Feb 1, 2025

Conversation

@VietND96
Copy link
Member

@VietND96 VietND96 commented Feb 1, 2025 •
edited by qodo-merge-pro bot
Loading

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Documentation

Description

  • Added support for deploying Edge versions 114 to 132.

  • Introduced edge_only and standalone_edge_only build targets.

  • Updated Makefile for reusable Edge image builds.

  • Added changelogs for Edge versions 114 through 132.

Changes walkthrough 📝

Relevant files
Enhancement
2 files
bootstrap.sh
Conditional build logic for Edge with reusable base           
+5/-1     
Makefile
Added reusable Edge build targets and logic                           
+6/-2     
Documentation
19 files
edge_114.md
Changelog for Edge version 114                                                     
+19/-0   
edge_115.md
Changelog for Edge version 115                                                     
+19/-0   
edge_116.md
Changelog for Edge version 116                                                     
+19/-0   
edge_117.md
Changelog for Edge version 117                                                     
+19/-0   
edge_118.md
Changelog for Edge version 118                                                     
+19/-0   
edge_119.md
Changelog for Edge version 119                                                     
+19/-0   
edge_120.md
Changelog for Edge version 120                                                     
+19/-0   
edge_121.md
Changelog for Edge version 121                                                     
+19/-0   
edge_122.md
Changelog for Edge version 122                                                     
+19/-0   
edge_123.md
Changelog for Edge version 123                                                     
+19/-0   
edge_124.md
Changelog for Edge version 124                                                     
+19/-0   
edge_125.md
Changelog for Edge version 125                                                     
+19/-0   
edge_126.md
Changelog for Edge version 126                                                     
+19/-0   
edge_127.md
Changelog for Edge version 127                                                     
+19/-0   
edge_128.md
Changelog for Edge version 128                                                     
+19/-0   
edge_129.md
Changelog for Edge version 129                                                     
+19/-0   
edge_130.md
Changelog for Edge version 130                                                     
+19/-0   
edge_131.md
Changelog for Edge version 131                                                     
+19/-0   
edge_132.md
Changelog for Edge version 132                                                     
+19/-0   
Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 1, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Build Logic

    The new conditional logic for Edge builds introduces branching based on REUSE_BASE flag. Verify that both build paths (reuse vs non-reuse) work as expected and produce correct images.

    if [ "${REUSE_BASE}" = "true" ]; then
  BUILD_ARGS="${BUILD_ARGS}" make edge_only standalone_edge_only
else
  BUILD_ARGS="${BUILD_ARGS}" make standalone_edge
fi

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 1, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Add missing error validation

    Add error handling for the case when REUSE_BASE is set but BUILD_ARGS is empty or
    invalid, to prevent potential build failures.

    tests/build-backward-compatible/bootstrap.sh [42-46]

     if [ "${REUSE_BASE}" = "true" ]; then
+  if [ -z "${BUILD_ARGS}" ]; then
+    echo "Error: BUILD_ARGS is empty but required when REUSE_BASE=true"
+    exit 1
+  fi
   BUILD_ARGS="${BUILD_ARGS}" make edge_only standalone_edge_only
 else
   BUILD_ARGS="${BUILD_ARGS}" make standalone_edge
 fi
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion adds important error handling to validate BUILD_ARGS when REUSE_BASE is true, which could prevent silent failures in the build process. This is a meaningful improvement for robustness and debugging.

    		7

    @VietND96 VietND96 merged commit 3fd6392 into trunk Feb 1, 2025
    27 checks passed
    @VietND96 VietND96 deleted the edge-version branch February 1, 2025 10:28
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort [1-5]: 2

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @VietND96 @selenium-ci