skips empty commands when saving

Author: corevo

packages/selenium-ide/src/neo/IO/SideeX/playback.js

@@ -55,6 +55,10 @@ function executionLoop() {
   // reached the end
   if (PlaybackState.currentPlayingIndex >= PlaybackState.runningQueue.length && PlaybackState.isPlaying) return false;
   const { id, command, target, value, isBreakpoint } = PlaybackState.runningQueue[PlaybackState.currentPlayingIndex];
+  // is command empty?
+  if (!command) {
+    return executionLoop();
+  }
   // breakpoint
   PlaybackState.setCommandState(id, PlaybackStates.Pending);
   if (!ignoreBreakpoint && isBreakpoint) PlaybackState.break();

packages/selianize/__tests__/command.spec.js

@@ -19,13 +19,13 @@ import CommandEmitter from "../src/command";
 import { CommandsArray } from "../../selenium-ide/src/neo/models/Command";
 
 describe("command code emitter", () => {
-  it("should fail to emit with no command", () => {
+  it("should skip empty commands", () => {
     const command = {
       command: "",
       target: "",
       value: ""
     };
-    return expect(CommandEmitter.emit(command)).rejects.toThrow("Command can not be empty");
+    return expect(CommandEmitter.emit(command)).resolves.toBeUndefined();
   });
   it("should fail to emit unknown command", () => {
     const command = {

packages/selianize/src/command.js

@@ -94,7 +94,11 @@ export function emit(command) {
         rej(e);
       }
     } else {
-      rej(command.command ? `Unknown command ${command.command}` : "Command can not be empty");
+      if (!command.command) {
+        res();
+      } else {
+        rej(`Unknown command ${command.command}`);
+      }
     }
   });
 }