option to enable/disable notifications, Fixes #82

Author: corevo

packages/selenium-ide/src/editor.js

@@ -25,7 +25,6 @@ var openedWindowIds = new Object();
 var openedTabCount = 1;
 var selfWindowId = -1;
 var contentWindowId;
-var notificationCount = 0;
 
 /* playing */
 var playingFrameLocations = {};
@@ -272,19 +271,3 @@ browser.runtime.onMessage.addListener(function contentWindowIdListener(message)
         browser.runtime.onMessage.removeListener(contentWindowIdListener);
     }
 })
-
-function notification(command, target, value) {
-    let tempCount = String(notificationCount);
-    notificationCount++;
-    // In Chrome, notification.create must have "iconUrl" key in notificationOptions
-    browser.notifications.create(tempCount, {
-        "type": "basic",
-        "iconUrl": "/icons/icon128.png",
-        "title": "Record command!",
-        "message": "command: " + String(command) + "\ntarget: " + String(target[0][0]) + "\nvalue: " + String(value) 
-    });
-
-    setTimeout(function() {
-        browser.notifications.clear(tempCount);
-    }, 1500);
-}

packages/selenium-ide/src/neo/IO/notifications.js

@@ -0,0 +1,36 @@
+// Licensed to the Software Freedom Conservancy (SFC) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The SFC licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import UiState from "../stores/view/UiState";
+
+export function sendRecordNotification(command, target, value) {
+  if (UiState.options.recordNotifications) {
+    // In Chrome, notification.create must have "iconUrl" key in notificationOptions
+    browser.notifications.create({
+      "type": "basic",
+      "iconUrl": "/icons/icon128.png",
+      "title": "Command was recorded",
+      "message": `command: ${command} \ntarget: ${target[0][0]} \nvalue: ${value}`
+    }).then(id => {
+      setTimeout(function() {
+        browser.notifications.clear(id);
+      }, 1500);
+    });
+  }
+}
+
+window.notification = sendRecordNotification;

packages/selenium-ide/src/neo/components/ProjectHeader/index.jsx

@@ -20,12 +20,15 @@ import PropTypes from "prop-types";
 import classNames from "classnames";
 import Title from "react-document-title";
 import ContentEditable from "react-contenteditable";
+import { observer } from "mobx-react";
 import OpenButton from "../ActionButtons/Open";
 import SaveButton from "../ActionButtons/Save";
 import MoreButton from "../ActionButtons/More";
 import ListMenu, { ListMenuItem } from "../ListMenu";
+import UiState from "../../stores/view/UiState";
 import "./style.css";
 
+@observer
 export default class ProjectHeader extends React.Component {
   constructor(props) {
     super(props);
@@ -47,6 +50,7 @@ export default class ProjectHeader extends React.Component {
     this.props.changeName(e.target.value);
   }
   render() {
+    console.log(UiState.options.recordNotifications);
     return (
       <div className={classNames("header", {"changed": this.props.changed})}>
         <Title title={`Selenium IDE - ${this.props.title}${this.props.changed ? "*" : ""}`} />
@@ -61,6 +65,9 @@ export default class ProjectHeader extends React.Component {
             <MoreButton canFocus={true} />
           }>
             <ListMenuItem onClick={this.props.export}>Export to JavaScript code</ListMenuItem>
+            <ListMenuItem onClick={() => { UiState.setOptions({ recordNotifications: !UiState.options.recordNotifications }); }}>
+              {UiState.options.recordNotifications ? "Disable record notifications" : "Enable record notifications"}
+            </ListMenuItem>
           </ListMenu>
         </span>
       </div>

packages/selenium-ide/src/neo/containers/Panel/index.jsx

@@ -42,6 +42,7 @@ import "../../styles/resizer.css";
 import "../../styles/markdown.css";
 
 import { loadProject, exportProject, saveProject } from "../../IO/filesystem";
+import "../../IO/notifications";
 import "../../IO/SideeX/record";
 import "../../IO/SideeX/playback";
 

packages/selenium-ide/src/neo/stores/view/UiState.js

@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-import { action, computed, observable, observe } from "mobx";
+import { action, computed, observable, observe, extendObservable } from "mobx";
 import storage from "../../IO/storage";
 import SuiteState from "./SuiteState";
 import TestState from "./TestState";
@@ -41,6 +41,9 @@ class UiState {
   @observable navigationDragging = false;
   @observable pristineCommand = new Command();
   @observable lastFocus = {};
+  @observable options = {
+    recordNotifications: true
+  };
 
   constructor() {
     this.suiteStates = {};
@@ -54,6 +57,9 @@ class UiState {
       if (data.navigationSize !== undefined && data.navigationSize >= this.minNavigationWidth) {
         this.resizeNavigation(data.navigationSize);
       }
+      if (data.options) {
+        this.setOptions(data.options);
+      }
     });
   }
 
@@ -195,6 +201,13 @@ class UiState {
     this.navigationDragging = isDragging;
   }
 
+  @action.bound setOptions(options) {
+    extendObservable(this.options, options);
+    storage.set({
+      options: this.options
+    });
+  }
+
   @action.bound observePristine() {
     this.pristineDisposer = observe(this.pristineCommand, () => {
       this.pristineDisposer();