silence errors by default

Author: corevo

packages/selenium-ide/src/neo/IO/filesystem.js

@@ -84,7 +84,7 @@ function downloadProject(project) {
 
 function exportProject(project) {
   return Manager.validatePluginExport(project).then(() => {
-    return Selianize(project).catch(err => {
+    return Selianize(project, { silenceErrors: true }).catch(err => {
       const markdown = ParseError(err && err.message || err);
       ModalState.showAlert({
         title: "Error saving project",

packages/selianize/__tests__/testcase.spec.js

@@ -118,4 +118,22 @@ describe("test case code emitter", () => {
     };
     return expect(TestCaseEmitter.emit(test)).rejects.toMatchObject(testErrors);
   });
+  it("should hardcode errors on silenceErrors option", () => {
+    const test = {
+      id: "1",
+      name: "silence",
+      commands: [
+        {
+          command: "doesntExist",
+          target: "",
+          value: ""
+        }
+      ]
+    };
+    return expect(TestCaseEmitter.emit(test, { silenceErrors: true })).resolves.toEqual({
+      name: "silence",
+      test: "it(\"silence\", async () => {await tests.silence(driver, vars);await driver.getTitle().then(title => {expect(title).toBeDefined();});});",
+      function: "tests.silence = async function silence(driver, vars) {throw new Error(\"Unknown command doesntExist\");}"
+    });
+  });
 });

packages/selianize/src/config.js

@@ -0,0 +1,21 @@
+// Licensed to the Software Freedom Conservancy (SFC) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The SFC licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+export default {
+  silenceErrors: false
+};
+

packages/selianize/src/index.js

@@ -20,15 +20,17 @@ import SuiteEmitter from "./suite";
 import TestCaseEmitter from "./testcase";
 import CommandEmitter from "./command";
 import LocationEmitter from "./location";
+import config from "./config";
 
-export default function Selianize(project) {
+export default function Selianize(project, _opts) {
+  const options = { ...config, ..._opts };
   return new Promise(async (res, rej) => { // eslint-disable-line no-unused-vars
     let result = "";
 
     result += await ConfigurationEmitter.emit(project);
 
     let errors = [];
-    const tests = (await Promise.all(project.tests.map((test) => TestCaseEmitter.emit(test).catch(e => {
+    const tests = (await Promise.all(project.tests.map((test) => TestCaseEmitter.emit(test, options).catch(e => {
       errors.push(e);
     }))));
 

packages/selianize/src/testcase.js

@@ -16,10 +16,11 @@
 // under the License.
 
 import CommandEmitter from "./command";
+import config from "./config";
 
 const hooks = [];
 
-export function emit(test) {
+export function emit(test, options = config) {
   return new Promise(async (res, rej) => { // eslint-disable-line no-unused-vars
     const hookResults = await Promise.all(hooks.map((hook) => hook(test)));
 
@@ -33,11 +34,15 @@ export function emit(test) {
     let func = `tests.${convertToSnake(test.name)} = async function ${convertToSnake(test.name)}(driver, vars) {`;
     let errors = [];
     func += (await Promise.all(test.commands.map((command, index) => (CommandEmitter.emit(command).catch(e => {
-      errors.push({
-        index: index + 1,
-        ...command,
-        message: e
-      });
+      if (options.silenceErrors) {
+        return `throw new Error("${e.message}");`;
+      } else {
+        errors.push({
+          index: index + 1,
+          ...command,
+          message: e
+        });
+      }
     }))))).join("");
     func += "}";