add select's implicit label locator strategy

Author: corevo

packages/selianize/__tests__/selection.spec.js

@@ -21,6 +21,9 @@ describe("selection location code emitter", () => {
   it("should fail to emit unknown selection locator", () => {
     return expect(SelectionEmitter.emit("notExists=element")).rejects.toThrow("Unknown selection locator notExists");
   });
+  it("should assume when no selector is given that it is the label locator", () => {
+    return expect(SelectionEmitter.emit("label")).resolves.toBe("By.xpath(`//option[. = 'label']`)");
+  });
   it("should emit label locator", () => {
     const type = "label";
     const selector = "a label";

packages/selianize/src/selection.js

@@ -25,9 +25,12 @@ const emitters = {
 export function emit(location) {
   return new Promise(async (res, rej) => {
     const [type, selector] = location.split("=");
-    if (emitters[type]) {
+    if (emitters[type] && selector) {
       let result = await emitters[type](selector);
       res(result);
+    } else if (!selector) {
+      // no selector strategy given, assuming label
+      res(await emitters["label"](type));
     } else {
       rej(new Error(`Unknown selection locator ${type}`));
     }

tests/examples/select-examples.side

@@ -27,14 +27,46 @@
       "targets": [],
       "value": "One"
     }]
+  }, {
+    "id": "58c35d38-9091-4f2e-a42f-c85ff8fdb30e",
+    "name": "select strategies",
+    "commands": [{
+      "id": "ff2730d3-b18d-4425-9f9c-5f9364bfef1f",
+      "comment": "",
+      "command": "open",
+      "target": "/select.html",
+      "targets": [],
+      "value": ""
+    }, {
+      "id": "48d4aacc-418b-4684-bfe8-cbb75356adbb",
+      "comment": "",
+      "command": "store",
+      "target": "Two",
+      "targets": [],
+      "value": "label"
+    }, {
+      "id": "34c991ee-db67-4e15-be7d-9f84be17bdda",
+      "comment": "",
+      "command": "select",
+      "target": "id=select",
+      "targets": [],
+      "value": "${label}"
+    }, {
+      "id": "951c9516-0dda-4d66-82b2-59ffa9837c99",
+      "comment": "",
+      "command": "assertSelectedLabel",
+      "target": "id=select",
+      "targets": [],
+      "value": "Two"
+    }]
   }],
   "suites": [{
     "id": "e7102959-f85f-4d57-9a39-846e52239b1b",
     "name": "select",
     "persistSession": false,
     "parallel": false,
     "timeout": 300,
-    "tests": ["6acbf258-048b-4493-8478-accfc444fb3d"]
+    "tests": ["6acbf258-048b-4493-8478-accfc444fb3d", "58c35d38-9091-4f2e-a42f-c85ff8fdb30e"]
   }],
   "urls": ["https://en.wikipedia.org/"],
   "plugins": [],
@@ -43,11 +75,14 @@
     "suites": [{
       "name": "select",
       "persistSession": false,
-      "code": "global.BASE_URL = configuration.baseUrl || 'http://nginx:80';let vars = {};jest.setTimeout(300000);describe(\"select\", () => {it(\"select-verify-labels\", async () => {await tests.select_verify_labels(driver, vars);await driver.getTitle().then(title => {expect(title).toBeDefined();});});});"
+      "code": "global.BASE_URL = configuration.baseUrl || 'http://nginx:80';let vars = {};jest.setTimeout(300000);describe(\"select\", () => {it(\"select-verify-labels\", async () => {await tests.select_verify_labels(driver, vars);await driver.getTitle().then(title => {expect(title).toBeDefined();});});it(\"select strategies\", async () => {await tests.select_strategies(driver, vars);await driver.getTitle().then(title => {expect(title).toBeDefined();});});});"
     }],
     "tests": [{
       "name": "select-verify-labels",
       "code": "tests.select_verify_labels = async function select_verify_labels(driver, vars) {await driver.get(BASE_URL + \"/select.html\");await driver.wait(until.elementLocated(By.id(`select`)), configuration.timeout);await driver.findElement(By.id(`select`)).then(element => {element.getAttribute(\"value\").then(selectedValue => {element.findElement(By.xpath('option[@value=\"'+selectedValue+'\"]')).then(selectedOption => {selectedOption.getText().then(selectedLabel => {expect(selectedLabel).toBe(`One`);});});});});await driver.wait(until.elementLocated(By.id(`select`)), configuration.timeout);await driver.findElement(By.id(`select`)).then(element => {element.getAttribute(\"value\").then(selectedValue => {element.findElement(By.xpath('option[@value=\"'+selectedValue+'\"]')).then(selectedOption => {selectedOption.getText().then(selectedLabel => {expect(selectedLabel).toBe(`One`);});});});});}"
+    }, {
+      "name": "select strategies",
+      "code": "tests.select_strategies = async function select_strategies(driver, vars) {await driver.get(BASE_URL + \"/select.html\");vars[\"label\"] = `Two`;await driver.wait(until.elementLocated(By.id(`select`)), configuration.timeout);await driver.findElement(By.id(`select`)).then(element => {element.findElement(By.xpath(`//option[. = '${vars.label}']`)).then(option => {option.click();});});await driver.wait(until.elementLocated(By.id(`select`)), configuration.timeout);await driver.findElement(By.id(`select`)).then(element => {element.getAttribute(\"value\").then(selectedValue => {element.findElement(By.xpath('option[@value=\"'+selectedValue+'\"]')).then(selectedOption => {selectedOption.getText().then(selectedLabel => {expect(selectedLabel).toBe(`Two`);});});});});}"
     }]
   },
   "dependencies": {}