handle moving duplicates between different suites

Author: corevo

packages/selenium-ide/src/neo/components/Suite/index.jsx

@@ -33,7 +33,7 @@ import "./style.css";
 const testTarget = {
   canDrop(props, monitor) {
     const test = monitor.getItem().test;
-    return !props.suite.containsTest(props.suite.tests, test);
+    return !props.suite.containsTest(test);
   },
   hover(props, monitor) {
     // check if they are different suites

packages/selenium-ide/src/neo/components/Test/index.jsx

@@ -39,7 +39,7 @@ const testSource = {
     };
   },
   isDragging(props, monitor) {
-    return (props.test.id === monitor.getItem().id);
+    return (props.test.id === monitor.getItem().id && props.suite.id === monitor.getItem().suite.id);
   }
 };
 
@@ -65,6 +65,9 @@ const testTarget = {
       dragged.suite = props.suite;
       dragged.index = props.suite.tests.length - 1;
       return;
+    } else if (!monitor.canDrop() && props.suite !== dragged.suite) {
+      // trying to move a duplicate
+      return;
     }
     const dragIndex = dragged.index;
     const hoverIndex = props.index;