defensive crash if chromedriver fails to start

Author: toddtarsi

package.json

@@ -15,7 +15,7 @@
     "test:e2e": "jest --testMatch \"**/packages/**/__tests__/**/*.e2e.js\"",
     "lint": "yarn lint:scripts",
     "lint:scripts": "eslint --ignore-pattern node_modules --ignore-pattern third-party --ignore-pattern dist --ignore-pattern build --ignore-pattern json --ext .ts,.tsx --ext .js packages/",
-    "test:side-runner": "./node_modules/@seleniumhq/side-runner/dist/bin.js ./tests/examples/*.side",
+    "test:side-runner": "./node_modules/@seleniumhq/side-runner/dist/bin.js ./tests/examples/simple-parent.side",
     "typecheck": "tsc --noEmit --composite false",
     "watch": "run-p watch:ts watch:webpack",
     "watch:webpack": "lerna run --parallel --stream --scope @seleniumhq/selenium-ide --loglevel verbose watch",

packages/selenium-ide/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@seleniumhq/selenium-ide",
-  "version": "4.0.0-alpha.6",
+  "version": "4.0.0-alpha.7",
   "private": true,
   "description": "Selenium IDE electron app",
   "author": "Todd <[email protected]>",

packages/selenium-ide/src/main/session/controllers/Driver/index.ts

@@ -3,7 +3,7 @@ import { WebDriverExecutor } from '@seleniumhq/side-runtime'
 import { ChildProcess } from 'child_process'
 import { BrowserInfo, Session } from 'main/types'
 import downloadDriver from './download'
-import startDriver, { WebdriverDebugLog } from './start'
+import startDriver, { port, WebdriverDebugLog } from './start'
 import BaseController from '../Base'
 
 // Escape hatch to avoid dealing with rootDir complexities in TS
@@ -59,7 +59,7 @@ export default class DriverController extends BaseController {
       },
     },
     // The "9515" is the port opened by chrome driver.
-    server = 'http://localhost:9515',
+    server = 'http://localhost:' + port,
   }: DriverOptions): Promise<WebDriverExecutor> {
     const driver: WebDriverExecutor = new WebDriverExecutor({
       capabilities: {
@@ -136,6 +136,7 @@ export default class DriverController extends BaseController {
       this.driverProcess = results.driver
       return null
     }
+    console.error('Failed to start chromedriver process', results.error)
     return results.error
   }
 

packages/selenium-ide/src/main/session/controllers/Driver/start.ts

@@ -1,5 +1,6 @@
 import { resolveDriverName } from '@seleniumhq/get-driver'
 import { ChildProcess, spawn } from 'child_process'
+import { app } from 'electron'
 import * as fs from 'fs-extra'
 import { BrowserInfo, Session } from 'main/types'
 import * as path from 'path'
@@ -19,6 +20,8 @@ export interface DriverStartFailure {
 export const WebdriverDebugLog = vdebuglog('webdriver', COLOR_MAGENTA)
 export const WebdriverDebugLogErr = vdebuglog('webdriver-error', COLOR_YELLOW)
 
+export const port = app.isPackaged ? 9516 : 9515
+
 /**
  * This module is just an async function that does the following:
  *   1. Grab driver from the node_modules, as fetched by electron-driver
@@ -57,9 +60,9 @@ export type StartDriver = (
   session: Session
 ) => (info: BrowserInfo) => Promise<DriverStartSuccess | DriverStartFailure>
 const startDriver: StartDriver = () => (info) =>
-  new Promise((resolve, reject) => {
+  new Promise((resolve) => {
     let initialized = false
-    const args = ['--verbose']
+    const args = ['--verbose', `--port=${port}`]
     const driverPath = getDriver(info)
     if (fs.existsSync(driverPath)) {
       const driver = spawn(driverPath.replace(/\s/g, '\ '), args, {
@@ -85,9 +88,12 @@ const startDriver: StartDriver = () => (info) =>
       })
       driver.on('close', (code: number) => {
         if (code) {
-          WebdriverDebugLogErr(`driver has exited with code${code}`)
+          WebdriverDebugLogErr(`driver has exited with code ${code}`)
           if (!initialized) {
-            reject(code)
+            resolve({
+              success: false,
+              error: 'Process has exited before starting with code ' + code,
+            })
           }
         }
       })

packages/selenium-ide/src/main/session/controllers/System/index.ts

@@ -11,8 +11,10 @@ export default class SystemController extends BaseController {
   }
   async startup() {
     if (this.isDown) {
-      // await this.session.windows.open('chromedriver')
-      await this.session.driver.startProcess()
+      const startupError = await this.session.driver.startProcess()
+      if (startupError) {
+        await this.crash(`Unable to startup due to chromedriver error: ${startupError}`);
+      }
       await this.session.projects.select(firstTime)
       this.isDown = false
       firstTime = false

packages/selenium-ide/src/main/util.ts

@@ -11,7 +11,7 @@ export const COLOR_CYAN = '\x1b[36m'
 export const COLOR_WHITE = '\x1b[37m'
 
 export const vdebuglog = (namespace: string, color: string) => {
-  const isBin = app.isPackaged
+  const isBin = true || app.isPackaged
   const prefix = isBin ? `${namespace}: ` : color
   const log = isBin ? console.log : debuglog(namespace)
   const suffix = isBin ? '' : '\x1b[0m'