upgrade mobx3 to mobx5

Author: corevo

packages/selenium-ide/package.json

@@ -54,8 +54,8 @@
     "fuse.js": "^3.3.0",
     "google-closure-library": "^20170521.0.0",
     "js-beautify": "^1.7.5",
-    "mobx": "^3.3.1",
-    "mobx-react": "^4.3.3",
+    "mobx": "^5.9.0",
+    "mobx-react": "^5.4.3",
     "modifier-keys": "^1.2.1",
     "project-name-generator": "^2.1.4",
     "prop-types": "^15.5.10",

packages/selenium-ide/src/neo/__test__/IO/legacy/migrate.spec.js

@@ -17,7 +17,7 @@
 
 import fs from 'fs'
 import path from 'path'
-import { useStrict } from 'mobx'
+import { configure } from 'mobx'
 import {
   verifyFile,
   FileTypes,
@@ -27,7 +27,9 @@ import {
   migrateUrls,
 } from '../../../IO/legacy/migrate'
 
-useStrict(true)
+configure({
+  enforceActions: 'observed',
+})
 
 describe('file classifier', () => {
   it('should recognize suite', () => {

packages/selenium-ide/src/neo/__test__/models/Suite.spec.js

@@ -15,12 +15,14 @@
 // specific language governing permissions and limitations
 // under the License.
 
-import { useStrict } from 'mobx'
+import { configure } from 'mobx'
 import ProjectStore from '../../stores/domain/ProjectStore'
 import Suite from '../../models/Suite'
 import TestCase from '../../models/TestCase'
 
-useStrict(true)
+configure({
+  enforceActions: 'observed',
+})
 
 describe('Suite model', () => {
   it("new suite should be named 'Utitled Suite'", () => {

packages/selenium-ide/src/neo/__test__/models/TestCase.spec.js

@@ -15,11 +15,13 @@
 // specific language governing permissions and limitations
 // under the License.
 
-import { useStrict } from 'mobx'
+import { configure } from 'mobx'
 import TestCase from '../../models/TestCase'
 import Command from '../../models/Command'
 
-useStrict(true)
+configure({
+  enforceActions: 'observed',
+})
 
 describe('TestCase model', () => {
   it("new test should be named 'Untitled Test'", () => {

packages/selenium-ide/src/neo/__test__/stores/domain/ProjectStore.spec.js

@@ -15,12 +15,14 @@
 // specific language governing permissions and limitations
 // under the License.
 
-import { useStrict } from 'mobx'
+import { configure } from 'mobx'
 import ProjectStore from '../../../stores/domain/ProjectStore'
 import Suite from '../../../models/Suite'
 import TestCase from '../../../models/TestCase'
 
-useStrict(true)
+configure({
+  enforceActions: 'observed',
+})
 
 describe('Project Store', () => {
   it('should have an id', () => {

packages/selenium-ide/src/neo/__test__/stores/view/Variables.spec.js

@@ -15,10 +15,12 @@
 // specific language governing permissions and limitations
 // under the License.
 
-import { useStrict } from 'mobx'
+import { configure } from 'mobx'
 import Variables from '../../../stores/view/Variables'
 
-useStrict(true)
+configure({
+  enforceActions: 'observed',
+})
 
 describe('variables', () => {
   let variables

packages/selenium-ide/src/neo/components/CommandInput/index.jsx

@@ -39,7 +39,7 @@ export default class CommandInput extends React.Component {
           items={
             this.props.value
               ? Commands.search(this.props.value)
-              : Commands.list.values()
+              : Array.from(Commands.list.values())
           }
           renderDefaultStyledItem={item => (
             <span key={item.name}>{item.name}</span>

packages/selenium-ide/src/neo/containers/Root/index.jsx

@@ -18,10 +18,12 @@
 import React from 'react'
 import ReactDOM from 'react-dom'
 import { AppContainer } from 'react-hot-loader'
-import { useStrict } from 'mobx'
+import { configure } from 'mobx'
 import Panel from '../Panel'
 
-useStrict(true)
+configure({
+  enforceActions: 'observed',
+})
 
 const render = Component => {
   ReactDOM.render(

packages/selenium-ide/src/neo/models/Command/index.js

@@ -200,7 +200,7 @@ class CommandList {
 
   @computed
   get array() {
-    return this.list.keys()
+    return Array.from(this.list.keys())
   }
 
   @computed
@@ -213,7 +213,7 @@ class CommandList {
 
   @computed
   get fuse() {
-    return new Fuse(this.list.values(), {
+    return new Fuse(Array.from(this.list.values()), {
       shouldSort: true,
       threshold: 0.4,
       location: 0,

packages/selenium-ide/src/neo/models/Suite.js

@@ -53,7 +53,7 @@ export default class Suite {
   @computed
   get tests() {
     return this.isParallel
-      ? this._tests.sort((t1, t2) => naturalCompare(t1.name, t2.name))
+      ? this._tests.slice().sort((t1, t2) => naturalCompare(t1.name, t2.name))
       : this._tests
   }