move isOpen and setOpen to the suite model

Author: corevo

packages/selenium-ide/src/neo/components/Suite/index.jsx

@@ -76,7 +76,7 @@ class Suite extends React.Component {
     setContextMenu: PropTypes.func,
   }
   handleClick() {
-    this.store.setOpen(!this.store.isOpen)
+    this.suite.setOpen(!this.suite.isOpen)
   }
   handleKeyDown(event) {
     const e = event.nativeEvent
@@ -86,7 +86,7 @@ class Suite extends React.Component {
     if (noModifiers && e.key === 'ArrowLeft') {
       event.preventDefault()
       event.stopPropagation()
-      this.store.setOpen(false)
+      this.suite.setOpen(false)
       UiState.selectTestByIndex(-1, this.props.suite)
     }
   }
@@ -119,7 +119,7 @@ class Suite extends React.Component {
               tabIndex="-1"
               className={classNames(
                 PlaybackState.suiteState.get(this.props.suite.id),
-                { active: this.store.isOpen }
+                { active: this.suite.isOpen }
               )}
               onClick={this.handleClick}
             >
@@ -136,7 +136,7 @@ class Suite extends React.Component {
           {listMenu}
         </div>
         <TestList
-          collapsed={!this.store.isOpen}
+          collapsed={!this.suite.isOpen}
           suite={this.props.suite}
           tests={this.store.filteredTests.get()}
           removeTest={test => {

packages/selenium-ide/src/neo/models/Suite.js

@@ -36,6 +36,8 @@ export default class Suite {
   _tests = []
   @observable
   modified = false
+  @observable
+  isOpen = false
 
   constructor(id = uuidv4(), name = 'Untitled Suite') {
     this.id = id
@@ -96,6 +98,11 @@ export default class Suite {
     }
   }
 
+  @action.bound
+  setOpen(isOpen) {
+    this.isOpen = isOpen
+  }
+
   containsTest(test) {
     // WARNING: do not turn this into a bound action, the observables it will set will cause react-dnd to fail!
     return this._tests.includes(test)

packages/selenium-ide/src/neo/stores/seed.js

@@ -598,8 +598,7 @@ export default function seed(store, numberOfSuites = 0) {
   waitSuite.addTestCase(waitTest5)
 
   UiState.changeView('Test suites')
-  let suiteState = UiState.getSuiteState(suiteAll)
-  suiteState.setOpen(true)
+  suiteAll.setOpen(true)
   UiState.selectTest(selectWindow, suiteAll)
   UiState.selectCommand(click)
 

packages/selenium-ide/src/neo/stores/view/SuiteState.js

@@ -18,17 +18,9 @@
 import { action, computed, observable } from 'mobx'
 
 export default class SuiteState {
-  @observable
-  isOpen = false
-
   constructor(UiState, suite) {
     this.filteredTests = computed(() =>
       suite.tests.filter(UiState.filterFunction)
     )
   }
-
-  @action.bound
-  setOpen(isOpen) {
-    this.isOpen = isOpen
-  }
 }

packages/selenium-ide/src/neo/stores/view/UiState.js

@@ -255,7 +255,7 @@ class UiState {
       const test = selectTestInArray(index, tests)
       const suiteIndex = this._project.suites.indexOf(suite)
       if (test) {
-        suiteState.setOpen(true)
+        suite.setOpen(true)
         this.selectTest(test, suite)
       } else if (suiteIndex > 0 && index < 0) {
         const previousSuite = this._project.suites[suiteIndex - 1]