Skip to content

Commit 59229ca

Browse files
committed
fix binary release pathing
1 parent b01ceb6 commit 59229ca

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

packages/selenium-ide/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "selenium-ide",
3-
"version": "4.0.1-alpha.68",
3+
"version": "4.0.1-alpha.69",
44
"private": false,
55
"description": "Selenium IDE electron app",
66
"author": "Todd <[email protected]>",

packages/selenium-ide/src/main/session/controllers/Driver/start.ts

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,25 @@ export const port = app.isPackaged ? 9516 : 9515
3030
* 4. When Electron is quitting, close the child driver process
3131
*/
3232

33-
const ourElectronPath = __non_webpack_require__.resolve(
34-
path.join(
35-
'electron-chromedriver',
36-
'bin',
37-
'chromedriver' + (os.platform() === 'win32' ? '.exe' : '')
38-
)
39-
)
33+
const electronBinary = `chromedriver${os.platform() === 'win32' ? '.exe' : ''}`
34+
const ourElectronPath = app.isPackaged
35+
? path.resolve(
36+
path.join(
37+
__dirname,
38+
'..',
39+
'node_modules',
40+
'electron-chromedriver',
41+
'bin',
42+
electronBinary
43+
)
44+
)
45+
: __non_webpack_require__.resolve(
46+
path.join(
47+
'electron-chromedriver',
48+
'bin',
49+
electronBinary
50+
)
51+
)
4052

4153
const getDriver = ({ browser, version }: BrowserInfo) =>
4254
(browser === 'electron'

0 commit comments

Comments
 (0)