Skip to content

Commit 5952174

Browse files
committed
latest ide patches:
1. show recent files from menu 2. make window usage a bit more resilient in playback 3. remove invalid characters from logs on windows
1 parent c6c9c5a commit 5952174

File tree

5 files changed

+15
-7
lines changed

5 files changed

+15
-7
lines changed

packages/selenium-ide/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@seleniumhq/selenium-ide",
3-
"version": "4.0.0-alpha.4",
3+
"version": "4.0.0-alpha.5",
44
"private": true,
55
"description": "Selenium IDE electron app",
66
"author": "Todd <[email protected]>",

packages/selenium-ide/src/main/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import installReactDevtools from './install-react-devtools'
88
import { join } from 'path'
99

1010
// Configure log file
11-
const logFile = new Date().toISOString() + '.main.log'
11+
const logFile = Date.now() + '.main.log'
1212
log.transports.file.resolvePath = () => join(app.getPath('logs'), logFile)
1313
Object.assign(console, log.functions);
1414

packages/selenium-ide/src/main/session/controllers/Driver/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ export default class DriverController extends BaseController {
7979
setWindowSize: async (_executor, width, height) => {
8080
const window = this.session.windows.getLastPlaybackWindow()
8181
const pbWinCount = this.session.windows.playbackWindows.length
82-
console.log(pbWinCount, window);
8382
const b = await window.getBounds()
8483
const calcNewX = b.x + Math.floor(b.width / 2) - Math.floor(width / 2)
8584
const calcNewY =

packages/selenium-ide/src/main/session/controllers/Menu/menus/projectEditor.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,16 @@ export const projectEditorCommands: MenuComponent = (session) => async () =>
2222
},
2323
{
2424
accelerator: 'CommandOrControl+R',
25-
label: 'Load Recent',
25+
label: 'Recent Projects',
2626
click: async () => {
2727
await session.projects.showRecents()
2828
},
29+
submenu: (await session.projects.getRecent()).map((project) => ({
30+
click: async () => {
31+
await session.api.projects.load(project)
32+
},
33+
label: project,
34+
})),
2935
},
3036
{ type: 'separator' },
3137
{

packages/selenium-ide/src/main/session/controllers/Playback/index.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,11 @@ export default class PlaybackController extends BaseController {
3535
}) => {
3636
const { driver } = executor
3737
const { windows } = this.session
38-
if (this.playRange[0] === 0) {
39-
await windows.initializePlaybackWindow()
40-
}
4138
const playbackWindow = await windows.getPlaybackWindow()
4239

4340
// Figure out playback window from document.title
4441
const handles = await driver.getAllWindowHandles()
42+
let success = false
4543
for (let i = 0, ii = handles.length; i !== ii; i++) {
4644
try {
4745
await driver.switchTo().window(handles[i])
@@ -51,12 +49,17 @@ export default class PlaybackController extends BaseController {
5149
title === playbackWindow.getTitle() &&
5250
url === playbackWindow.webContents.getURL()
5351
) {
52+
success = true
5453
break
5554
}
5655
} catch (e) {
5756
console.warn('Failed to switch to window', e)
5857
}
5958
}
59+
if (!success) {
60+
await windows.initializePlaybackWindow()
61+
await this.onBeforePlay({ driver: executor })
62+
}
6063
}
6164

6265
async pause() {

0 commit comments

Comments
 (0)