Skip to content

Commit 59df0fa

Browse files
committed
clean up client less aggressively
1 parent 1294889 commit 59df0fa

File tree

3 files changed

+21
-11
lines changed

3 files changed

+21
-11
lines changed

packages/selenium-ide/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@seleniumhq/selenium-ide",
3-
"version": "4.0.0-alpha.29",
3+
"version": "4.0.0-alpha.30",
44
"private": true,
55
"description": "Selenium IDE electron app",
66
"author": "Todd <[email protected]>",

packages/selenium-ide/src/browser/windows/PlaybackWindow/preload/find-select.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,16 @@ const init = () => {
2929
processHighlightCommand
3030
)
3131
window.addEventListener('beforeunload', () => {
32-
window.sideAPI.recorder.onRequestSelectElement.removeListener(
33-
processSelectionCommand
34-
)
35-
window.sideAPI.recorder.onHighlightElement.removeListener(
36-
processHighlightCommand
37-
)
32+
try {
33+
window.sideAPI.recorder.onRequestSelectElement.removeListener(
34+
processSelectionCommand
35+
)
36+
window.sideAPI.recorder.onHighlightElement.removeListener(
37+
processHighlightCommand
38+
)
39+
} catch (e) {
40+
// ignore
41+
}
3842
})
3943
}
4044

packages/selenium-ide/src/browser/windows/PlaybackWindow/preload/recorder.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,13 @@ export default class Recorder {
5959
this.getFrameLocation
6060
)
6161
this.window.addEventListener('beforeunload', () => {
62-
this.window.sideAPI.recorder.onFrameRecalculate.removeListener(
63-
this.getFrameLocation
64-
)
62+
try {
63+
this.window.sideAPI.recorder.onFrameRecalculate.removeListener(
64+
this.getFrameLocation
65+
)
66+
} catch (e) {
67+
// ignore
68+
}
6569
})
6670
// @ts-expect-error
6771
this.recordingState = {}
@@ -244,7 +248,9 @@ export default class Recorder {
244248
callback: MutationCallback,
245249
config: any
246250
) {
247-
const observer = new MutationObserver(callback.bind(this)) as ExpandedMutationObserver
251+
const observer = new MutationObserver(
252+
callback.bind(this)
253+
) as ExpandedMutationObserver
248254
observer.observerName = observerName
249255
observer.config = config
250256
this.mutationObservers[observerName] = observer

0 commit comments

Comments
 (0)