several thousand lines of test typing

Author: toddtarsi

jest.config.js

@@ -1,5 +1,13 @@
 module.exports = {
-  testURL: 'http://localhost/index.html',
+  globals: {
+    'ts-jest': {
+      tsConfig: 'tsconfig.base.json',
+    },
+  },
+  testEnvironment: 'jsdom',
+  testEnvironmentOptions: {
+    url: 'http://localhost/index.html',
+  },
   moduleNameMapper: {
     '^.+\\.(css|scss)$': 'identity-obj-proxy',
   },

package.json

@@ -62,6 +62,7 @@
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.5.0",
     "jest-cli": "^29.5.0",
+    "jest-environment-jsdom": "^29.5.0",
     "npm-run-all": "^4.1.5",
     "npm-run-bg": "^1.0.7",
     "prettier": "^2.6.0",

packages/browser-info/__tests__/chrome.spec.ts

@@ -51,7 +51,6 @@ describe('chrome browser info', () => {
       try {
         await getBrowserInfo(ChromeChannel.stable)
       } catch (err) {
-        // @ts-expect-error
         expect(err.message).toBe('Unable to find Chrome installation')
       }
     })
@@ -154,7 +153,6 @@ describe('chrome browser info', () => {
       try {
         await getBrowserInfo(ChromeChannel.stable)
       } catch (err) {
-        // @ts-expect-error
         expect(err.message).toBe('Unable to find Chrome installation')
       }
     })
@@ -163,7 +161,6 @@ describe('chrome browser info', () => {
       try {
         await getBrowserInfo(ChromeChannel.canary)
       } catch (err) {
-        // @ts-expect-error
         expect(err.message).toBe('Unsupported channel canary')
       }
     })

packages/browser-info/__tests__/sh.spec.ts

@@ -42,11 +42,8 @@ describe('sh', () => {
         'console.log(`out`);console.error(`err`);process.exit(1);',
       ])
     } catch (err) {
-      // @ts-expect-error
       expect(err.stdout).toBe('out\n')
-      // @ts-expect-error
       expect(err.stderr).toBe('err\n')
-      // @ts-expect-error
       expect(err.code).toBe(1)
     }
   })
@@ -55,7 +52,6 @@ describe('sh', () => {
     try {
       await sh('command-that-does-not-exist')
     } catch (err) {
-      // @ts-expect-error
       expect(err.code).toBe(1)
     }
   })

packages/browser-info/jest.config.js

@@ -0,0 +1,16 @@
+module.exports = {
+  testEnvironment: 'jsdom',
+  testEnvironmentOptions: {
+    url: 'http://localhost/index.html',
+  },
+  moduleNameMapper: {
+    '^.+\\.(css|scss)$': 'identity-obj-proxy',
+  },
+  setupFilesAfterEnv: ['./scripts/jest/test.config.js'],
+  testMatch: ['**/packages/**/__test?(s)__/**/*.spec.[jt]s?(x)'],
+  testPathIgnorePatterns: ['/node_modules/'],
+  transform: {
+    '^.+\\.jsx?$': 'babel-jest',
+    '^.+\\.tsx?$': 'ts-jest',
+  },
+}

packages/get-driver/tsconfig.json

@@ -7,5 +7,5 @@
     "strictNullChecks": true
   },
   "include": ["src/**/*.ts"],
-  "exclude": ["**/__mocks__", "**/__tests__"]
+  "exclude": ["**/__mocks__"]
 }

packages/side-api/tsconfig.json

@@ -6,7 +6,7 @@
     "outDir": "dist"
   },
   "include": ["src/**/*.ts"],
-  "exclude": ["**/__mocks__", "**/__tests__"],
+  "exclude": ["**/__mocks__"],
   "references": [
     {
       "path": "../browser-info"

…rt/__test__/src/code-export/emit.spec.js …test__/src/code-export/emit.spec.ts.skippackages/side-code-export/__test__/src/code-export/emit.spec.js renamed to packages/side-code-export/__test__/src/code-export/emit.spec.ts.skip packages/side-code-export/__test__/src/code-export/emit.spec.js renamed to packages/side-code-export/__test__/src/code-export/emit.spec.ts.skip

@@ -20,6 +20,7 @@ import {
   emitLocation,
   emitSelection,
   emitOriginTracing,
+  SelectionEmitters,
 } from '../../../src/code-export/emit'
 import TestCase from '../../../../selenium-ide/src/neo/models/TestCase'
 import Command from '../../../../selenium-ide/src/neo/models/Command'
@@ -76,15 +77,15 @@ describe('Command emitter', () => {
 describe('Location emitter', () => {
   it('emits by sync emitter', () => {
     const emitters = {
-      id: selector => {
+      id: (selector) => {
         return `By.id("${selector}")`
       },
     }
     expect(emitLocation('id=blah', emitters)).toEqual(`By.id("blah")`)
   })
   it('emits by async emitter', () => {
     const emitters = {
-      id: selector => {
+      id: (selector) => {
         return Promise.resolve(`By.id("${selector}")`)
       },
     }
@@ -103,20 +104,20 @@ describe('Location emitter', () => {
 describe('Selection emitter', () => {
   it('emits by sync emitter', () => {
     const emitters = {
-      id: id => {
+      id: (id) => {
         return `By.css(\`*[id="${id}"]\`)`
       },
-    }
+    } as unknown as SelectionEmitters
     expect(emitSelection('id=blah', emitters)).toEqual(
       `By.css(\`*[id="blah"]\`)`
     )
   })
   it('emits by async emitter', () => {
     const emitters = {
-      id: id => {
+      id: (id) => {
         return Promise.resolve(`By.css(\`*[id="${id}"]\`)`)
       },
-    }
+    } as unknown as SelectionEmitters
     expect(emitSelection('id=blah', emitters)).resolves.toBe(
       `By.css(\`*[id="blah"]\`)`
     )
@@ -138,25 +139,27 @@ describe('Trace emitter', () => {
     const test = new TestCase()
     test.createCommand(undefined, 'a', 'foo', 'bar')
     test.createCommand(undefined, 'b', 'baz', 'qux', 'a comment')
-    expect(emitOriginTracing(test, { commentPrefix: '//' }, true, false)).toEqual([
+    expect(
+      emitOriginTracing(test, { commentPrefix: '//' }, true, false)
+    ).toEqual([
       '// Test name: Untitled Test',
       '// Step # | name | target | value | comment',
       '// 1 | a | foo | bar | ',
       '// 2 | b | baz | qux | a comment',
     ])
-    expect(emitOriginTracing(test, { commentPrefix: '//' }, true, true)).toEqual([
+    expect(
+      emitOriginTracing(test, { commentPrefix: '//' }, true, true)
+    ).toEqual([
       '// Test name: Untitled Test',
       '// Step # | name | target | value',
       '// 1 | a | foo | bar',
       '// 2 | b | baz | qux\n// a comment',
     ])
-    expect(emitOriginTracing(test, { commentPrefix: '//' }, false, true)).toEqual([
-      '',
-      '// a comment',
-    ])
-    expect(emitOriginTracing(test, { commentPrefix: '//' }, false, false)).toEqual([
-      '',
-      '',
-    ])
+    expect(
+      emitOriginTracing(test, { commentPrefix: '//' }, false, true)
+    ).toEqual(['', '// a comment'])
+    expect(
+      emitOriginTracing(test, { commentPrefix: '//' }, false, false)
+    ).toEqual(['', ''])
   })
 })

…rt/__test__/src/code-export/find.spec.js …test__/src/code-export/find.spec.js.skippackages/side-code-export/__test__/src/code-export/find.spec.js renamed to packages/side-code-export/__test__/src/code-export/find.spec.js.skip packages/side-code-export/__test__/src/code-export/find.spec.js renamed to packages/side-code-export/__test__/src/code-export/find.spec.js.skip

@@ -16,6 +16,7 @@
 // under the License.
 
 import Hook from '../../../src/code-export/hook'
+import { ExportCommandsShape } from '../../../src/types'
 
 describe('Hooks', () => {
   it('should clear registered commands', () => {
@@ -28,7 +29,7 @@ describe('Hooks', () => {
   })
   it('should not error when no emitters registered', async () => {
     const hook = new Hook()
-    const result = await hook.emit()
+    const result = (await hook.emit({})) as ExportCommandsShape
     expect(result.commands).toEqual([])
   })
   it('should emit command object', () => {
@@ -37,8 +38,8 @@ describe('Hooks', () => {
       endingSyntax: 'blah99',
       registrationLevel: 1,
     })
-    hook.register(() => {
-      return Promise.resolve('blah2')
+    hook.register(async () => {
+      return await 'blah2'
     })
     hook.register(() => {
       return 'blah3'
@@ -81,10 +82,10 @@ describe('Hooks', () => {
       return 'blah'
     })
     hook.register(() => {
-      return 1234
+      return '1234'
     })
     expect(hook.isRegistered('blah')).resolves.toBeTruthy()
-    expect(hook.isRegistered(1234)).resolves.toBeTruthy()
+    expect(hook.isRegistered('1234')).resolves.toBeTruthy()
     expect(hook.isRegistered('halb')).resolves.toBeFalsy()
   })
 })